#10346 closed enhancement (fixed)
drop rendering of bridge/tunnel/oneway = true/1
Reported by: | Klumbumbus | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 15.03 |
Component: | Internal mappaint style | Version: | |
Keywords: | Cc: |
Description
Currently elemstyles.mapcss is often written like way[bridge?]{}
So it also renders for bridge=true and bridge=1. I think this is bad tagging because only "yes" should be used. Same for tunnel, oneway, noexit, motorroad, area, ford,... I would change this to way[bridge=yes]{}
. Same for the other keys. I would create the diff file, if it gets accepted. I just want to ask before I do the work.
Attachments (0)
Change History (8)
comment:1 by , 10 years ago
comment:2 by , 10 years ago
It should not be dropped at the rendering, but fixed in the data itself.
Or, if you like, have another validator rule for these values (which could also include a fix for true|1
→ yes
)
follow-up: 6 comment:3 by , 10 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
There is no added value in changing the rendering, let's keep it as it is.
I checked the numbers of *=true
, this tag is already very uncommon, and does not need a specific test neither.
comment:6 by , 10 years ago
Replying to Don-vip:
I checked the numbers of
*=true
, this tag is already very uncommon, and does not need a specific test neither.
I'm happy that I succeeded here. It was my decision that I don't like multiple boolean values and JOSM should only produce yes and no whenever possible. :-) JOSM has influence!
follow-up: 8 comment:7 by , 10 years ago
Replying to Klumbumbus:
Currently elemstyles.mapcss is often written like
way[bridge?]{}
So it also renders for bridge=true and bridge=1. I think this is bad tagging because only "yes" should be used.
You mean bridge=yes and bridge=<some of the different types of bridge> is to be supported.
comment:8 by , 10 years ago
Replying to aceman:
You mean bridge=yes and bridge=<some of the different types of bridge> is to be supported.
Yes, see http://josm.openstreetmap.de/browser/josm/trunk/styles/standard/elemstyles.mapcss#L111 for supportet values.
I agree this is bad tagging but I don't think this is worth the trouble.