Changeset 32705 in osm for applications/editors


Ignore:
Timestamp:
2016-07-23T23:51:48+02:00 (8 years ago)
Author:
donvip
Message:

fix error-prone warnings

Location:
applications/editors/josm/plugins/sds/src/org/openstreetmap/hot/sds
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • applications/editors/josm/plugins/sds/src/org/openstreetmap/hot/sds/DetermineSdsModificationsUploadHook.java

    r32703 r32705  
    134134                       }
    135135                       break;
     136                   default: throw new AssertionError("unexpected case: " + old.getType());
    136137                   }
    137138               }
  • applications/editors/josm/plugins/sds/src/org/openstreetmap/hot/sds/SdsApi.java

    r32703 r32705  
    1717import java.net.URL;
    1818import java.net.UnknownHostException;
     19import java.nio.charset.StandardCharsets;
    1920import java.util.HashMap;
    2021import java.util.List;
     
    399400                    // Unauthorized, see #3887.
    400401                    //
    401                     BufferedReader in = new BufferedReader(new InputStreamReader(i));
     402                    BufferedReader in = new BufferedReader(new InputStreamReader(i, StandardCharsets.UTF_8));
    402403                    String s;
    403404                    while ((s = in.readLine()) != null) {
     
    496497                        InputStream i = FixEncoding(activeConnection.getErrorStream(), encoding);
    497498                        if (i != null) {
    498                             BufferedReader in = new BufferedReader(new InputStreamReader(i));
     499                            BufferedReader in = new BufferedReader(new InputStreamReader(i, StandardCharsets.UTF_8));
    499500                            String s;
    500501                            while ((s = in.readLine()) != null) {
  • applications/editors/josm/plugins/sds/src/org/openstreetmap/hot/sds/SdsMenu.java

    r32703 r32705  
    8282    }
    8383
    84     private class SdsAboutAction extends JosmAction {
     84    private static class SdsAboutAction extends JosmAction {
    8585
    8686        SdsAboutAction() {
     
    123123    }
    124124
    125     private final class SdsPreferencesAction extends JosmAction implements Runnable {
     125    private static final class SdsPreferencesAction extends JosmAction implements Runnable {
    126126
    127127        private SdsPreferencesAction() {
  • applications/editors/josm/plugins/sds/src/org/openstreetmap/hot/sds/SdsPluginPreferences.java

    r32703 r32705  
    8383                Main.pref.put(SDS_PASSWORD, new String(password.getPassword()));
    8484                try {
    85                     api.requestShadowsFromSds(Collections.singletonList(new Long(1)), null, null, null);
     85                    api.requestShadowsFromSds(Collections.singletonList(Long.valueOf(1L)), null, null, null);
    8686                    JOptionPane.showMessageDialog(
    8787                            Main.parent,
  • applications/editors/josm/plugins/sds/src/org/openstreetmap/hot/sds/SeparateDataStorePlugin.java

    r32703 r32705  
    5151    };
    5252
    53     class QueueItem {
     53    static class QueueItem {
    5454        public IPrimitive primitive;
    5555        public HashMap<String, String> tags;
     
    9797        case WAY: return originalWays.get(other.getId());
    9898        case RELATION: return originalRelations.get(other.getId());
     99        default: throw new AssertionError("unexpected case: " + other.getType());
    99100        }
    100         return null;
    101101    }
    102102
Note: See TracChangeset for help on using the changeset viewer.