Changeset 32705 in osm

Timestamp:

2016-07-23T23:51:48+02:00 (8 years ago)

Author:

donvip

Message:

fix error-prone warnings

Location:

applications/editors/josm/plugins/sds/src/org/openstreetmap/hot/sds

Files:

• DetermineSdsModificationsUploadHook.java (modified) (1 diff)
• SdsApi.java (modified) (3 diffs)
• SdsMenu.java (modified) (2 diffs)
• SdsPluginPreferences.java (modified) (1 diff)
• SeparateDataStorePlugin.java (modified) (2 diffs)

applications/editors/josm/plugins/sds/src/org/openstreetmap/hot/sds/DetermineSdsModificationsUploadHook.java

@@ -134 +134 @@
                        }
                        break;
+                   default: throw new AssertionError("unexpected case: " + old.getType());
                    }
                }

applications/editors/josm/plugins/sds/src/org/openstreetmap/hot/sds/SdsApi.java

@@ -17 +17 @@
 import java.net.URL;
 import java.net.UnknownHostException;
+import java.nio.charset.StandardCharsets;
 import java.util.HashMap;
 import java.util.List;
@@ -399 +400 @@
                     // Unauthorized, see #3887.
                     //
-                    BufferedReader in = new BufferedReader(new InputStreamReader(i));
+                    BufferedReader in = new BufferedReader(new InputStreamReader(i, StandardCharsets.UTF_8));
                     String s;
                     while ((s = in.readLine()) != null) {
@@ -496 +497 @@
                         InputStream i = FixEncoding(activeConnection.getErrorStream(), encoding);
                         if (i != null) {
-                            BufferedReader in = new BufferedReader(new InputStreamReader(i));
+                            BufferedReader in = new BufferedReader(new InputStreamReader(i, StandardCharsets.UTF_8));
                             String s;
                             while ((s = in.readLine()) != null) {

applications/editors/josm/plugins/sds/src/org/openstreetmap/hot/sds/SdsMenu.java

@@ -82 +82 @@
     }
 
-    private class SdsAboutAction extends JosmAction {
+    private static class SdsAboutAction extends JosmAction {
 
         SdsAboutAction() {
@@ -123 +123 @@
     }
 
-    private final class SdsPreferencesAction extends JosmAction implements Runnable {
+    private static final class SdsPreferencesAction extends JosmAction implements Runnable {
 
         private SdsPreferencesAction() {

applications/editors/josm/plugins/sds/src/org/openstreetmap/hot/sds/SdsPluginPreferences.java

@@ -83 +83 @@
                 Main.pref.put(SDS_PASSWORD, new String(password.getPassword()));
                 try {
-                    api.requestShadowsFromSds(Collections.singletonList(new Long(1)), null, null, null);
+                    api.requestShadowsFromSds(Collections.singletonList(Long.valueOf(1L)), null, null, null);
                     JOptionPane.showMessageDialog(
                             Main.parent,

applications/editors/josm/plugins/sds/src/org/openstreetmap/hot/sds/SeparateDataStorePlugin.java

@@ -51 +51 @@
     };
 
-    class QueueItem {
+    static class QueueItem {
         public IPrimitive primitive;
         public HashMap<String, String> tags;
@@ -97 +97 @@
         case WAY: return originalWays.get(other.getId());
         case RELATION: return originalRelations.get(other.getId());
+        default: throw new AssertionError("unexpected case: " + other.getType());
         }
-        return null;
     }