Changeset 19050 in josm for trunk/scripts/TagInfoExtract.java

Timestamp:

2024-04-22T20:59:26+02:00 (7 months ago)

Author:

taylor.smock

Message:

Revert most var changes from r19048, fix most new compile warnings and checkstyle issues

Also, document why various ErrorProne checks were originally disabled and fix
generic SonarLint issues.

File:

• trunk/scripts/TagInfoExtract.java (modified) (6 diffs)

trunk/scripts/TagInfoExtract.java

@@ -1 +1 @@
 // License: GPL. For details, see LICENSE file.
+
 import java.awt.Graphics2D;
 import java.awt.image.BufferedImage;
@@ -32 +33 @@
 
 import javax.imageio.ImageIO;
-import jakarta.json.Json;
-import jakarta.json.JsonArrayBuilder;
-import jakarta.json.JsonObjectBuilder;
-import jakarta.json.JsonWriter;
-import jakarta.json.stream.JsonGenerator;
 
 import org.openstreetmap.josm.actions.DeleteAction;
@@ -85 +81 @@
 import org.xml.sax.SAXException;
 
+import jakarta.json.Json;
+import jakarta.json.JsonArrayBuilder;
+import jakarta.json.JsonObjectBuilder;
+import jakarta.json.JsonWriter;
+import jakarta.json.stream.JsonGenerator;
+
 /**
  * Extracts tag information for the taginfo project.
@@ -163 +165 @@
     }
 
-    private static class Options {
+    private static final class Options {
         Mode mode;
         int josmSvnRevision = Version.getInstance().getVersion();
@@ -314 +316 @@
     }
 
-    private class ExternalPresets extends Presets {
+    private final class ExternalPresets extends Presets {
 
         @Override
@@ -341 +343 @@
     }
 
-    private class StyleSheet extends Extractor {
+    private final class StyleSheet extends Extractor {
         private MapCSSStyleSource styleSource;