Changeset 18960 in josm for trunk/src/org/openstreetmap/josm/data/validation/util/AggregatePrimitivesVisitor.java

Timestamp:

2024-01-30T09:04:11+01:00 (8 months ago)

Author:

GerdP

Message:

fix #23397: Improve the results of partial validations

• pass also parent ways and relations of uploaded/selected objects to the testers, child objects are already added, this allows to find e.g. overlapping polygons problems with tags in members of relations
• let CrossingWays find a problem if at least one of the crossing ways is in the partial selection.
• let DuplicatWays find a problem if at least one of the duplicated ways is in the partial selection
• add code to filter the detected issues so that those issues which are clearly not related to the original list of objects are removed. A few issues from mapcss tests may remain.
• add new preference validator.partial.add.parents to disable the addition of parent objects, default is enabled
• add new preference validator.partial.removeIrrelevant to disable the filtering of irrelevant errors, default is enabled
• duplicated code to call AggregatePrimitivesVisitor was moved to ValidationTask

File:

• trunk/src/org/openstreetmap/josm/data/validation/util/AggregatePrimitivesVisitor.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/validation/util/AggregatePrimitivesVisitor.java

@@ -15 +15 @@
  * A visitor that aggregates all primitives it visits.
  * <p>
- * The primitives are sorted according to their type: first nodes, then ways.
  *
  * @author frsantos
@@ -25 +24 @@
     /**
      * Visits a collection of primitives
-     * @param data The collection of primitives
+     * @param data The collection of primitives in no specific order.
      * @return The aggregated primitives
      */