Changeset 18871 in josm for trunk/ivysettings.xml

Timestamp:

2023-10-16T19:03:11+02:00 (9 months ago)

Author:

taylor.smock

Message:

See #23218: Use newer error_prone versions when compiling on Java 11+

error_prone 2.11 dropped support for compiling with Java 8, although it still
supports compiling for Java 8. The "major" new check for us is NotJavadoc since
we used /** in quite a few places which were not javadoc.

Other "new" checks that are of interest:

• AlreadyChecked: if (foo) { doFoo(); } else if (!foo) { doBar(); }
• UnnecessaryStringBuilder: Avoid StringBuilder (Java converts + to StringBuilder behind-the-scenes, but may also do something else if it performs better)
• NonApiType: Avoid specific interface types in function definitions
• NamedLikeContextualKeyword: Avoid using restricted names for classes and methods
• UnusedMethod: Unused private methods should be removed

This fixes most of the new error_prone issues and some SonarLint issues.

File:

• trunk/ivysettings.xml (modified) (1 diff)

trunk/ivysettings.xml

@@ -6 +6 @@
     <ibiblio name="josm-nexus" m2compatible="true" root="https://josm.openstreetmap.de/nexus/content/repositories/public/" />
   </resolvers>
+  <!-- Remove error_prone 2.10.0 specific statements in build.xml when we drop Java 8 as a build platform -->
+  <property name="versions.error_prone" value="2.10.0" unlessset="isJava11"/>
+  <property name="versions.error_prone" value="2.22.0" ifset="isJava11"/>
 </ivysettings>