Changeset 18690 in josm for trunk/test/unit/org/openstreetmap/josm/io/nmea/NmeaReaderTest.java

Timestamp:

2023-03-13T21:59:27+01:00 (2 years ago)

Author:

taylor.smock

Message:

See #16567: Convert all assertion calls to JUnit 5 (patch by gaben, modified)

The modifications are as follows:

• Merge DomainValidatorTest.testIDN and DomainValidatorTest.testIDNJava6OrLater
• Update some tests to use @ParameterizedTest (DomainValidatorTest)
• Replace various exception blocks with assertThrows. These typically looked like

      try {
          // Something that should throw an exception here
          fail("An exception should have been thrown");
      } catch (Exception e) {
          // Verify the exception matches expectations here
      }
  

• Replace assertTrue(val instanceof Clazz) with assertInstanceOf
• Replace JUnit 4 @Suite with JUnit 5 @Suite

Both the original patch and the modified patch fix various lint issues.

File:

• trunk/test/unit/org/openstreetmap/josm/io/nmea/NmeaReaderTest.java (modified) (2 diffs)

trunk/test/unit/org/openstreetmap/josm/io/nmea/NmeaReaderTest.java

@@ -4 +4 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
@@ -70 +71 @@
         assertEquals("3d", wayPoints.get(0).get(GpxConstants.PT_FIX));
         assertEquals("0.7", wayPoints.get(0).get(GpxConstants.PT_HDOP).toString().trim());
-        assertEquals(null, wayPoints.get(0).get(GpxConstants.PT_VDOP));
-        assertEquals(null, wayPoints.get(0).get(GpxConstants.PT_PDOP));
+        assertNull(wayPoints.get(0).get(GpxConstants.PT_VDOP));
+        assertNull(wayPoints.get(0).get(GpxConstants.PT_PDOP));
     }