Changeset 18212 in josm for trunk/src/org/openstreetmap

Timestamp:

2021-09-12T02:15:34+02:00 (3 years ago)

Author:

Don-vip

Message:

fix coverity 1437552 (infinite loop)

File:

• trunk/src/org/openstreetmap/josm/tools/ListenableWeakReference.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/tools/ListenableWeakReference.java

@@ -56 +56 @@
     private static void clean() {
         boolean running = true;
-        try {
-            while (running) {
+        while (running) {
+            try {
                 Reference<? extends Object> ref = GLOBAL_QUEUE.remove();
                 if (ref instanceof ListenableWeakReference) {
                     ((ListenableWeakReference<?>) ref).onDereference();
                 }
+            } catch (InterruptedException e) {
+                running = false;
+                BugReport.intercept(e).warn();
+                Thread.currentThread().interrupt();
             }
-        } catch (InterruptedException e) {
-            running = false;
-            BugReport.intercept(e).warn();
-            Thread.currentThread().interrupt();
         }
     }