Changeset 18211 in josm for trunk/src/org/openstreetmap

Timestamp:

2021-09-12T02:10:25+02:00 (3 years ago)

Author:

Don-vip

Message:

global use of !Utils.isEmpty/isBlank

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/AboutAction.java (modified) (2 diffs)
• actions/AbstractInfoAction.java (modified) (2 diffs)
• actions/AutoScaleAction.java (modified) (2 diffs)
• actions/CopyAction.java (modified) (2 diffs)
• actions/DownloadReferrersAction.java (modified) (1 diff)
• actions/ImageryAdjustAction.java (modified) (3 diffs)
• actions/SelectNonBranchingWaySequences.java (modified) (2 diffs)
• actions/SessionLoadAction.java (modified) (1 diff)
• actions/SplitWayAction.java (modified) (2 diffs)
• actions/downloadtasks/DownloadOsmTask.java (modified) (1 diff)
• actions/mapmode/AddNoteAction.java (modified) (2 diffs)
• actions/relation/AddSelectionToRelations.java (modified) (1 diff)
• actions/relation/ExportRelationToGpxAction.java (modified) (2 diffs)
• data/UserIdentityManager.java (modified) (1 diff)
• data/Version.java (modified) (1 diff)
• data/gpx/GpxImageCorrelation.java (modified) (1 diff)
• data/gpx/GpxTrack.java (modified) (2 diffs)
• data/imagery/ImageryInfo.java (modified) (5 diffs)
• data/imagery/ImageryLayerInfo.java (modified) (1 diff)
• data/imagery/TMSCachedTileLoaderJob.java (modified) (1 diff)
• data/imagery/vectortile/mapbox/style/Layers.java (modified) (3 diffs)
• data/imagery/vectortile/mapbox/style/MapboxVectorStyle.java (modified) (2 diffs)
• data/osm/Tagged.java (modified) (2 diffs)
• data/osm/visitor/paint/relations/Multipolygon.java (modified) (2 diffs)
• data/preferences/NamedColorProperty.java (modified) (2 diffs)
• data/projection/datum/NTV2Proj4DirGridShiftFileSource.java (modified) (1 diff)
• data/sources/SourceInfo.java (modified) (3 diffs)
• data/validation/OsmValidator.java (modified) (1 diff)
• data/validation/tests/MapCSSTagChecker.java (modified) (1 diff)
• data/validation/tests/TagChecker.java (modified) (3 diffs)
• data/validation/util/MultipleNameVisitor.java (modified) (2 diffs)
• gui/ExtendedDialog.java (modified) (1 diff)
• gui/MapStatus.java (modified) (2 diffs)
• gui/MapView.java (modified) (2 diffs)
• gui/NavigatableComponent.java (modified) (1 diff)
• gui/SplashScreen.java (modified) (1 diff)
• gui/bbox/JosmMapViewer.java (modified) (2 diffs)
• gui/dialogs/LatLonDialog.java (modified) (1 diff)
• gui/dialogs/RelationListDialog.java (modified) (1 diff)
• gui/dialogs/ToggleDialog.java (modified) (2 diffs)
• gui/dialogs/properties/HelpAction.java (modified) (1 diff)
• gui/dialogs/relation/GenericRelationEditor.java (modified) (1 diff)
• gui/download/BookmarkSelection.java (modified) (1 diff)
• gui/io/CloseChangesetDialog.java (modified) (3 diffs)
• gui/io/LayerNameAndFilePathTableCell.java (modified) (1 diff)
• gui/io/UploadParameterSummaryPanel.java (modified) (2 diffs)
• gui/layer/NoteLayer.java (modified) (1 diff)
• gui/layer/geoimage/ImageDisplay.java (modified) (2 diffs)
• gui/layer/gpx/ConvertFromGpxLayerAction.java (modified) (1 diff)
• gui/layer/gpx/ImportAudioAction.java (modified) (1 diff)
• gui/preferences/PreferenceTabbedPane.java (modified) (1 diff)
• gui/preferences/advanced/ListEditor.java (modified) (2 diffs)
• gui/preferences/display/GPXSettingsPanel.java (modified) (1 diff)
• gui/preferences/imagery/ImageryProvidersPanel.java (modified) (1 diff)
• gui/preferences/map/MapPaintPreference.java (modified) (2 diffs)
• gui/preferences/plugin/PluginListPanel.java (modified) (1 diff)
• gui/preferences/plugin/PluginPreference.java (modified) (3 diffs)
• gui/preferences/projection/CodeProjectionChoice.java (modified) (2 diffs)
• gui/preferences/projection/CustomProjectionChoice.java (modified) (2 diffs)
• gui/preferences/projection/ListProjectionChoice.java (modified) (1 diff)
• gui/tagging/ac/AutoCompletionManager.java (modified) (2 diffs)
• gui/widgets/AbstractIdTextField.java (modified) (2 diffs)
• gui/widgets/ChangesetIdTextField.java (modified) (2 diffs)
• gui/widgets/EditableList.java (modified) (4 diffs)
• gui/widgets/JosmTextField.java (modified) (2 diffs)
• gui/widgets/UrlLabel.java (modified) (2 diffs)
• io/DefaultProxySelector.java (modified) (2 diffs)
• io/GpxReader.java (modified) (2 diffs)
• io/GpxWriter.java (modified) (4 diffs)
• io/MessageNotifier.java (modified) (2 diffs)
• io/OsmApiException.java (modified) (1 diff)
• io/OsmChangeReader.java (modified) (2 diffs)
• io/OverpassDownloadReader.java (modified) (1 diff)
• io/auth/CredentialsManager.java (modified) (2 diffs)
• io/imagery/WMSImagery.java (modified) (1 diff)
• io/remotecontrol/RequestProcessor.java (modified) (1 diff)
• io/remotecontrol/handler/ImportHandler.java (modified) (1 diff)
• io/remotecontrol/handler/RequestHandler.java (modified) (1 diff)
• plugins/PluginHandler.java (modified) (3 diffs)
• plugins/PluginInformation.java (modified) (1 diff)
• plugins/ReadRemotePluginInformationTask.java (modified) (1 diff)
• tools/ExceptionUtil.java (modified) (1 diff)
• tools/HttpClient.java (modified) (1 diff)
• tools/ImageProvider.java (modified) (2 diffs)
• tools/LanguageInfo.java (modified) (1 diff)
• tools/PlatformHookUnixoid.java (modified) (7 diffs)
• tools/template_engine/ContextSwitchTemplate.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/actions/AboutAction.java

@@ -140 +140 @@
         // Get the list of Launchpad contributors using customary msgid “translator-credits”
         String translators = tr("translator-credits");
-        if (translators != null && !translators.isEmpty() && !"translator-credits".equals(translators)) {
+        if (!Utils.isEmpty(translators) && !"translator-credits".equals(translators)) {
             about.addTab(tr("Translators"), createScrollPane(new JosmTextArea(translators)));
         }
@@ -211 +211 @@
         symbol.setFont(GuiHelper.getMonospacedFont(symbol));
         JosmTextArea dirLabel = new JosmTextArea();
-        if (dir != null && !dir.isEmpty()) {
+        if (!Utils.isEmpty(dir)) {
             dirLabel.setText(dir);
             dirLabel.setEditable(false);

trunk/src/org/openstreetmap/josm/actions/AbstractInfoAction.java

@@ -19 +19 @@
 import org.openstreetmap.josm.tools.OpenBrowser;
 import org.openstreetmap.josm.tools.Shortcut;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -115 +116 @@
     @Override
     protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
-        setEnabled(selection != null && !selection.isEmpty());
+        setEnabled(!Utils.isEmpty(selection));
     }
 }

trunk/src/org/openstreetmap/josm/actions/AutoScaleAction.java

@@ -40 +40 @@
 import org.openstreetmap.josm.spi.preferences.Config;
 import org.openstreetmap.josm.tools.Shortcut;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -421 +422 @@
     protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
         if (AutoScaleMode.SELECTION == mode) {
-            setEnabled(selection != null && !selection.isEmpty());
+            setEnabled(!Utils.isEmpty(selection));
         }
     }

trunk/src/org/openstreetmap/josm/actions/CopyAction.java

@@ -21 +21 @@
 import org.openstreetmap.josm.gui.layer.OsmDataLayer;
 import org.openstreetmap.josm.tools.Shortcut;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -70 +71 @@
     @Override
     protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
-        setEnabled(selection != null && !selection.isEmpty());
+        setEnabled(!Utils.isEmpty(selection));
     }
 

trunk/src/org/openstreetmap/josm/actions/DownloadReferrersAction.java

@@ -69 +69 @@
     protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
         updateEnabledStateOnModifiableSelection(selection);
-        if (isEnabled() && selection != null && !selection.isEmpty()
+        if (isEnabled() && !Utils.isEmpty(selection)
                 && DownloadPolicy.BLOCKED.equals(selection.iterator().next().getDataSet().getDownloadPolicy())) {
             setEnabled(false);

trunk/src/org/openstreetmap/josm/actions/ImageryAdjustAction.java

@@ -37 +37 @@
 import org.openstreetmap.josm.tools.JosmDecimalFormatSymbolsProvider;
 import org.openstreetmap.josm.tools.Logging;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -328 +329 @@
         protected void buttonAction(int buttonIndex, ActionEvent evt) {
             restoreOldMode = true;
-            if (buttonIndex == 0 && tBookmarkName.getText() != null && !tBookmarkName.getText().isEmpty() &&
+            if (buttonIndex == 0 && !Utils.isEmpty(tBookmarkName.getText()) &&
                     OffsetBookmark.getBookmarkByName(layer, tBookmarkName.getText()) != null &&
                     !confirmOverwriteBookmark()) {
@@ -346 +347 @@
                 if (getValue() != 1) {
                     layer.getDisplaySettings().setOffsetBookmark(old);
-                } else if (tBookmarkName.getText() != null && !tBookmarkName.getText().isEmpty()) {
+                } else if (!Utils.isEmpty(tBookmarkName.getText())) {
                     OffsetBookmark.bookmarkOffset(tBookmarkName.getText(), layer);
                 }

trunk/src/org/openstreetmap/josm/actions/SelectNonBranchingWaySequences.java

@@ -12 +12 @@
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
 import org.openstreetmap.josm.data.osm.Way;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -77 +78 @@
      */
     public boolean canExtend() {
-        return outerNodes != null && !outerNodes.isEmpty();
+        return !Utils.isEmpty(outerNodes);
     }
 

trunk/src/org/openstreetmap/josm/actions/SessionLoadAction.java

@@ -135 +135 @@
 
         private void addLayers() {
-            if (layers != null && !layers.isEmpty()) {
+            if (!Utils.isEmpty(layers)) {
                 boolean noMap = MainApplication.getMap() == null;
                 for (Layer l : layers) {

trunk/src/org/openstreetmap/josm/actions/SplitWayAction.java

@@ -51 +51 @@
 import org.openstreetmap.josm.tools.GBC;
 import org.openstreetmap.josm.tools.Shortcut;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -384 +385 @@
             UndoRedoHandler.getInstance().add(result);
             List<? extends PrimitiveId> newSel = result.getNewSelection();
-            if (newSel != null && !newSel.isEmpty()) {
+            if (!Utils.isEmpty(newSel)) {
                 way.getDataSet().setSelected(newSel);
             }

trunk/src/org/openstreetmap/josm/actions/downloadtasks/DownloadOsmTask.java

@@ -502 +502 @@
                 }
                 String remark = dataSet.getRemark();
-                if (remark != null && !remark.isEmpty()) {
+                if (!Utils.isEmpty(remark)) {
                     rememberErrorMessage(remark);
                 }

trunk/src/org/openstreetmap/josm/actions/mapmode/AddNoteAction.java

@@ -20 +20 @@
 import org.openstreetmap.josm.tools.ImageProvider;
 import org.openstreetmap.josm.tools.Logging;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -78 +79 @@
         }
         String input = dialog.getInputText();
-        if (input != null && !input.isEmpty()) {
+        if (!Utils.isEmpty(input)) {
             LatLon latlon = map.mapView.getLatLon(e.getPoint().x, e.getPoint().y);
             noteData.createNote(latlon, input);

trunk/src/org/openstreetmap/josm/actions/relation/AddSelectionToRelations.java

@@ -70 +70 @@
 
     private void selectionChanged(final Collection<? extends IPrimitive> newSelection) {
-        GuiHelper.runInEDT(() -> setEnabled(newSelection != null && !newSelection.isEmpty()
+        GuiHelper.runInEDT(() -> setEnabled(!Utils.isEmpty(newSelection)
                 && OsmUtils.isOsmCollectionEditable(relations)));
     }

trunk/src/org/openstreetmap/josm/actions/relation/ExportRelationToGpxAction.java

@@ -39 +39 @@
 import org.openstreetmap.josm.gui.layer.OsmDataLayer;
 import org.openstreetmap.josm.tools.SubclassFilteredCollection;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -214 +215 @@
     public void setPrimitives(Collection<? extends IPrimitive> primitives) {
         relations = Collections.<Relation>emptySet();
-        if (primitives != null && !primitives.isEmpty()) {
+        if (!Utils.isEmpty(primitives)) {
             relations = new SubclassFilteredCollection<>(primitives,
                 r -> r instanceof Relation && r.hasTag("type", Arrays.asList("route", "superroute")));

trunk/src/org/openstreetmap/josm/data/UserIdentityManager.java

@@ -217 +217 @@
         String credentialsUserName = CredentialsManager.getInstance().getUsername();
         if (isAnonymous()) {
-            if (credentialsUserName != null && !credentialsUserName.trim().isEmpty()) {
+            if (!Utils.isBlank(credentialsUserName)) {
                 setPartiallyIdentified(credentialsUserName);
             }

trunk/src/org/openstreetmap/josm/data/Version.java

@@ -178 +178 @@
         int v = getVersion();
         String s = (v == JOSM_UNKNOWN_VERSION) ? "UNKNOWN" : Integer.toString(v);
-        if (buildName != null && !buildName.isEmpty()) {
+        if (!Utils.isEmpty(buildName)) {
             s += ' ' + buildName;
         }

trunk/src/org/openstreetmap/josm/data/gpx/GpxImageCorrelation.java

@@ -197 +197 @@
         if (wp != null) {
             String value = wp.getString(GpxConstants.PT_ELE);
-            if (value != null && !value.isEmpty()) {
+            if (!Utils.isEmpty(value)) {
                 try {
                     return Double.valueOf(value);

trunk/src/org/openstreetmap/josm/data/gpx/GpxTrack.java

@@ -15 +15 @@
 import org.openstreetmap.josm.tools.Logging;
 import org.openstreetmap.josm.tools.StreamUtils;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -38 +39 @@
     public GpxTrack(Collection<Collection<WayPoint>> trackSegs, Map<String, Object> attributes) {
         this.segments = trackSegs.stream()
-                .filter(trackSeg -> trackSeg != null && !trackSeg.isEmpty())
+                .filter(trackSeg -> !Utils.isEmpty(trackSeg))
                 .map(GpxTrackSegment::new)
                 .collect(StreamUtils.toUnmodifiableList());

trunk/src/org/openstreetmap/josm/data/imagery/ImageryInfo.java

@@ -278 +278 @@
                 projections = String.join(",", i.serverProjections);
             }
-            if (i.noTileHeaders != null && !i.noTileHeaders.isEmpty()) {
+            if (!Utils.isEmpty(i.noTileHeaders)) {
                 noTileHeaders = new MultiMap<>(i.noTileHeaders);
             }
 
-            if (i.noTileChecksums != null && !i.noTileChecksums.isEmpty()) {
+            if (!Utils.isEmpty(i.noTileChecksums)) {
                 noTileChecksums = new MultiMap<>(i.noTileChecksums);
             }
 
-            if (i.metadataHeaders != null && !i.metadataHeaders.isEmpty()) {
+            if (!Utils.isEmpty(i.metadataHeaders)) {
                 metadataHeaders = i.metadataHeaders;
             }
@@ -363 +363 @@
         if (t != null) {
             this.sourceType = t;
-        } else if (type != null && !type.isEmpty()) {
+        } else if (!Utils.isEmpty(type)) {
             throw new IllegalArgumentException("unknown type: "+type);
         }
@@ -411 +411 @@
             }
         }
-        if (e.projections != null && !e.projections.isEmpty()) {
+        if (!Utils.isEmpty(e.projections)) {
             // split generates null element on empty string which gives one element Array[null]
             setServerProjections(Arrays.asList(e.projections.split(",", -1)));
@@ -717 +717 @@
         boolean html = false;
         String dateStr = getDate();
-        if (dateStr != null && !dateStr.isEmpty()) {
+        if (!Utils.isEmpty(dateStr)) {
             html = addNewLineInTooltip(res, tr("Date of imagery: {0}", dateStr), htmlSupported);
         }
@@ -730 +730 @@
         }
         String desc = getDescription();
-        if (desc != null && !desc.isEmpty()) {
+        if (!Utils.isEmpty(desc)) {
             html = addNewLineInTooltip(res, desc, htmlSupported);
         }

trunk/src/org/openstreetmap/josm/data/imagery/ImageryLayerInfo.java

@@ -333 +333 @@
     // some additional checks to respect extended URLs in preferences (legacy workaround)
     private static boolean isSimilar(String a, String b) {
-        return Objects.equals(a, b) || (a != null && b != null && !a.isEmpty() && !b.isEmpty() && (a.contains(b) || b.contains(a)));
+        return Objects.equals(a, b) || (!Utils.isEmpty(a) && !Utils.isEmpty(b) && (a.contains(b) || b.contains(a)));
     }
 

trunk/src/org/openstreetmap/josm/data/imagery/TMSCachedTileLoaderJob.java

@@ -142 +142 @@
         if (isNotImage(headers, statusCode)) {
             String message = detectErrorMessage(new String(content, StandardCharsets.UTF_8));
-            if (message != null && !message.isEmpty()) {
+            if (!Utils.isEmpty(message)) {
                 tile.setError(message);
             }

trunk/src/org/openstreetmap/josm/data/imagery/vectortile/mapbox/style/Layers.java

@@ -1 +1 @@
 // License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.data.imagery.vectortile.mapbox.style;
-
-import org.openstreetmap.josm.gui.mappaint.StyleKeys;
 
 import java.awt.Font;
@@ -22 +20 @@
 import javax.json.JsonString;
 import javax.json.JsonValue;
+
+import org.openstreetmap.josm.gui.mappaint.StyleKeys;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -267 +268 @@
         if (layoutObject.containsKey("icon-image")) {
             sb.append(/* NO-ICON */"icon-image:concat(");
-            if (this.styleId != null && !this.styleId.trim().isEmpty()) {
+            if (!Utils.isBlank(this.styleId)) {
                 sb.append('"').append(this.styleId).append('/').append("\",");
             }

trunk/src/org/openstreetmap/josm/data/imagery/vectortile/mapbox/style/MapboxVectorStyle.java

@@ -37 +37 @@
 import org.openstreetmap.josm.spi.preferences.Config;
 import org.openstreetmap.josm.tools.Logging;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -141 +142 @@
                 this.sources.put(source, new ElemStyles(Collections.singleton(style)));
             }
-            if (this.spriteUrl != null && !this.spriteUrl.trim().isEmpty()) {
+            if (!Utils.isBlank(this.spriteUrl)) {
                 MainApplication.worker.execute(this::fetchSprites);
             }

trunk/src/org/openstreetmap/josm/data/osm/Tagged.java

@@ -8 +8 @@
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
+
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -111 +113 @@
      */
     default boolean hasTag(String key) {
-        String v = get(key);
-        return v != null && !v.isEmpty();
+        return !Utils.isEmpty(get(key));
     }
 

trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/relations/Multipolygon.java

@@ -32 +32 @@
 import org.openstreetmap.josm.tools.Geometry.AreaAndPerimeter;
 import org.openstreetmap.josm.tools.Logging;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -100 +101 @@
             Collection<String> literals;
             literals = Config.getPref().getList(PREF_KEY_OUTER_ROLES);
-            if (literals != null && !literals.isEmpty()) {
+            if (!Utils.isEmpty(literals)) {
                 setNormalized(literals, outerExactRoles);
             }
             literals = Config.getPref().getList(PREF_KEY_OUTER_ROLE_PREFIXES);
-            if (literals != null && !literals.isEmpty()) {
+            if (!Utils.isEmpty(literals)) {
                 setNormalized(literals, outerRolePrefixes);
             }
             literals = Config.getPref().getList(PREF_KEY_INNER_ROLES);
-            if (literals != null && !literals.isEmpty()) {
+            if (!Utils.isEmpty(literals)) {
                 setNormalized(literals, innerExactRoles);
             }
             literals = Config.getPref().getList(PREF_KEY_INNER_ROLE_PREFIXES);
-            if (literals != null && !literals.isEmpty()) {
+            if (!Utils.isEmpty(literals)) {
                 setNormalized(literals, innerRolePrefixes);
             }

trunk/src/org/openstreetmap/josm/data/preferences/NamedColorProperty.java

@@ -10 +10 @@
 import org.openstreetmap.josm.tools.CheckParameterUtil;
 import org.openstreetmap.josm.tools.ColorHelper;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -84 +85 @@
     public Color get() {
         List<String> data = getPreferences().getList(getKey(), getDefaultValuePref()); // store default value
-        if (super.isSet() && data != null && !data.isEmpty()) {
+        if (super.isSet() && !Utils.isEmpty(data)) {
             return ColorHelper.html2color(data.get(0));
         }

trunk/src/org/openstreetmap/josm/data/projection/datum/NTV2Proj4DirGridShiftFileSource.java

@@ -51 +51 @@
         if (grid == null) {
             String projLib = Utils.getSystemProperty("PROJ_LIB");
-            if (projLib != null && !projLib.isEmpty()) {
+            if (!Utils.isEmpty(projLib)) {
                 File dir = new File(projLib);
                 if (dir.exists() && dir.isDirectory()) {

trunk/src/org/openstreetmap/josm/data/sources/SourceInfo.java

@@ -502 +502 @@
         }
         return entries.stream()
-                .filter(prefEntry -> prefEntry.id != null && !prefEntry.id.isEmpty())
+                .filter(prefEntry -> !Utils.isEmpty(prefEntry.id))
                 .map(prefEntry -> prefEntry.id)
                 .sorted()
@@ -517 +517 @@
         boolean html = false;
         String dateStr = getDate();
-        if (dateStr != null && !dateStr.isEmpty()) {
+        if (!Utils.isEmpty(dateStr)) {
             res.append("<br>").append(tr("Date of imagery: {0}", dateStr));
             html = true;
@@ -526 +526 @@
         }
         String desc = getDescription();
-        if (desc != null && !desc.isEmpty()) {
+        if (!Utils.isEmpty(desc)) {
             res.append("<br>").append(Utils.escapeReservedCharactersHTML(desc));
             html = true;

trunk/src/org/openstreetmap/josm/data/validation/OsmValidator.java

@@ -392 +392 @@
             DefaultMutableTreeNode branch;
 
-            if (description != null && !description.isEmpty()) {
+            if (!Utils.isEmpty(description)) {
                 trunk = inTree(root, description);
                 branch = inTree(trunk, key);

trunk/src/org/openstreetmap/josm/data/validation/tests/MapCSSTagChecker.java

@@ -297 +297 @@
     private static String findURLTitle(String url) {
         for (SourceEntry source : new ValidatorPrefHelper().get()) {
-            if (url.equals(source.url) && source.title != null && !source.title.isEmpty()) {
+            if (url.equals(source.url) && !Utils.isEmpty(source.title)) {
                 return source.title;
             }

trunk/src/org/openstreetmap/josm/data/validation/tests/TagChecker.java

@@ -240 +240 @@
                 continue;
             Set<String> values = TaggingPresets.getPresetValues(key);
-            boolean allNumerical = values != null && !values.isEmpty()
+            boolean allNumerical = !Utils.isEmpty(values)
                     && values.stream().allMatch(TagChecker::isNum);
             if (allNumerical) {
@@ -428 +428 @@
      */
     static boolean containsUnwantedNonPrintingControlCharacter(String s) {
-        return s != null && !s.isEmpty() && (
+        return !Utils.isEmpty(s) && (
                 isJoiningChar(s.charAt(0)) ||
                 isJoiningChar(s.charAt(s.length() - 1)) ||
@@ -640 +640 @@
                 checkSingleTagComplex(withErrors, p, key, value);
             }
-            if (checkFixmes && key != null && value != null && !value.isEmpty() && isFixme(key, value) && !withErrors.contains(p, "FIXME")) {
+            if (checkFixmes && key != null && !Utils.isEmpty(value) && isFixme(key, value) && !withErrors.contains(p, "FIXME")) {
                 errors.add(TestError.builder(this, Severity.OTHER, FIXME)
                         .message(tr("fixme"))

trunk/src/org/openstreetmap/josm/data/validation/util/MultipleNameVisitor.java

@@ -13 +13 @@
 import org.openstreetmap.josm.data.preferences.IntegerProperty;
 import org.openstreetmap.josm.tools.ImageProvider;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -44 +45 @@
         for (OsmPrimitive osm : data) {
             String name = osm.getDisplayName(DefaultNameFormatter.getInstance());
-            if (name != null && !name.isEmpty() && multipleName.length() <= MULTIPLE_NAME_MAX_LENGTH.get()) {
+            if (!Utils.isEmpty(name) && multipleName.length() <= MULTIPLE_NAME_MAX_LENGTH.get()) {
                 if (multipleName.length() > 0) {
                     multipleName.append(", ");

trunk/src/org/openstreetmap/josm/gui/ExtendedDialog.java

@@ -509 +509 @@
     @Override
     public final boolean toggleCheckState() {
-        toggleable = togglePref != null && !togglePref.isEmpty();
+        toggleable = !Utils.isEmpty(togglePref);
         toggleValue = ConditionalOptionPaneUtil.getDialogReturnValue(togglePref);
         return toggleable && toggleValue != -1;

trunk/src/org/openstreetmap/josm/gui/MapStatus.java

@@ -195 +195 @@
 
         private void updateText() {
-            if (customText != null && !customText.isEmpty()) {
+            if (!Utils.isEmpty(customText)) {
                 progressBar.setToolTipText(tr("{0} ({1})", title, customText));
             } else {
@@ -234 +234 @@
         @Override
         public void appendLogMessage(String message) {
-            if (message != null && !message.isEmpty()) {
+            if (!Utils.isEmpty(message)) {
                 Logging.info("appendLogMessage not implemented for background tasks. Message was: " + message);
             }

trunk/src/org/openstreetmap/josm/gui/MapView.java

@@ -76 +76 @@
 import org.openstreetmap.josm.tools.Logging;
 import org.openstreetmap.josm.tools.Shortcut;
+import org.openstreetmap.josm.tools.Utils;
 import org.openstreetmap.josm.tools.bugreport.BugReport;
 
@@ -819 +820 @@
     public String getLayerInformationForSourceTag() {
         return layerManager.getVisibleLayersInZOrder().stream()
-                .filter(layer -> layer.getChangesetSourceTag() != null && !layer.getChangesetSourceTag().trim().isEmpty())
+                .filter(layer -> !Utils.isBlank(layer.getChangesetSourceTag()))
                 .map(layer -> layer.getChangesetSourceTag().trim())
                 .distinct()

trunk/src/org/openstreetmap/josm/gui/NavigatableComponent.java

@@ -1345 +1345 @@
                     return ws;
                 }
-                if (preferredRefs != null && !preferredRefs.isEmpty()) {
+                if (!Utils.isEmpty(preferredRefs)) {
                     // prefer ways containing given nodes
                     if (preferredRefs.contains(ws.getFirstNode()) || preferredRefs.contains(ws.getSecondNode())) {

trunk/src/org/openstreetmap/josm/gui/SplashScreen.java

@@ -234 +234 @@
         @Override
         public void beginTask(String title) {
-            if (title != null && !title.isEmpty()) {
+            if (!Utils.isEmpty(title)) {
                 Logging.debug(title);
                 final MeasurableTask task = new MeasurableTask(title);

trunk/src/org/openstreetmap/josm/gui/bbox/JosmMapViewer.java

@@ -30 +30 @@
 import org.openstreetmap.josm.gui.layer.TMSLayer;
 import org.openstreetmap.josm.tools.Logging;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -77 +78 @@
                 Logging.trace(ex);
                 Logging.warn(ex.getMessage());
-                if (ex.getMessage() != null && !ex.getMessage().isEmpty()) {
+                if (!Utils.isEmpty(ex.getMessage())) {
                     new Notification(ex.getMessage()).setIcon(JOptionPane.WARNING_MESSAGE).show();
                 }

trunk/src/org/openstreetmap/josm/gui/dialogs/LatLonDialog.java

@@ -295 +295 @@
 
     private void setOkEnabled(boolean b) {
-        if (buttons != null && !buttons.isEmpty()) {
+        if (!Utils.isEmpty(buttons)) {
             buttons.get(0).setEnabled(b);
         }

trunk/src/org/openstreetmap/josm/gui/dialogs/RelationListDialog.java

@@ -588 +588 @@
          */
         public void setSelectedRelations(Collection<? extends IRelation<?>> sel) {
-            if (sel != null && !sel.isEmpty()) {
+            if (!Utils.isEmpty(sel)) {
                 if (!getVisibleRelations().containsAll(sel)) {
                     resetFilter();

trunk/src/org/openstreetmap/josm/gui/dialogs/ToggleDialog.java

@@ -75 +75 @@
 import org.openstreetmap.josm.tools.Logging;
 import org.openstreetmap.josm.tools.Shortcut;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -953 +954 @@
         }
         add(data, BorderLayout.CENTER);
-        if (!buttons.isEmpty() && buttons.get(0) != null && !buttons.get(0).isEmpty()) {
+        if (!buttons.isEmpty() && !Utils.isEmpty(buttons.get(0))) {
             buttonsPanel = new JPanel(new GridLayout(buttons.size(), 1));
             for (Collection<SideButton> buttonRow : buttons) {

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/HelpAction.java

@@ -87 +87 @@
         }
 
-        if (type != null && !type.isEmpty()) {
+        if (!Utils.isEmpty(type)) {
             pages.add(String.format("%sRelation:%s", lang, type));
             pages.add(String.format("Relation:%s", type));

trunk/src/org/openstreetmap/josm/gui/dialogs/relation/GenericRelationEditor.java

@@ -994 +994 @@
         return presets.stream()
                 .map(preset -> preset.suggestRoleForOsmPrimitive(p))
-                .filter(role -> role != null && !role.isEmpty())
+                .filter(role -> !Utils.isEmpty(role))
                 .collect(Collectors.toSet());
     }

trunk/src/org/openstreetmap/josm/gui/download/BookmarkSelection.java

@@ -204 +204 @@
             );
             b.setArea(currentArea);
-            if (b.getName() != null && !b.getName().isEmpty()) {
+            if (!Utils.isEmpty(b.getName())) {
                 ((DefaultListModel<BookmarkList.Bookmark>) bookmarks.getModel()).addElement(b);
                 bookmarks.save();

trunk/src/org/openstreetmap/josm/gui/io/CloseChangesetDialog.java

@@ -12 +12 @@
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.List;
 
 import javax.swing.AbstractAction;
@@ -32 +31 @@
 import org.openstreetmap.josm.tools.ImageProvider;
 import org.openstreetmap.josm.tools.InputMapUtils;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -128 +128 @@
 
         protected void refreshEnabledState() {
-            List<Changeset> list = lstOpenChangesets.getSelectedValuesList();
-            setEnabled(list != null && !list.isEmpty());
+            setEnabled(!Utils.isEmpty(lstOpenChangesets.getSelectedValuesList()));
         }
 

trunk/src/org/openstreetmap/josm/gui/io/LayerNameAndFilePathTableCell.java

@@ -184 +184 @@
     private String makePathFit(String t) {
         boolean hasEllipsis = false;
-        while (t != null && !t.isEmpty()) {
+        while (!Utils.isEmpty(t)) {
             int txtwidth = lblFilename.getFontMetrics(lblFilename.getFont()).stringWidth(t);
             if (txtwidth < lblFilename.getWidth() || t.lastIndexOf(File.separator) < ELLIPSIS.length()) {

trunk/src/org/openstreetmap/josm/gui/io/UploadParameterSummaryPanel.java

@@ -25 +25 @@
 import org.openstreetmap.josm.tools.ImageProvider;
 import org.openstreetmap.josm.tools.StreamUtils;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -167 +168 @@
                 .orElse("");
         final String html = Stream.of(buildChangesetSummary(), buildChangesetSummary2(), buildStrategySummary(), server)
-                .filter(s -> s != null && !s.isEmpty())
+                .filter(s -> !Utils.isEmpty(s))
                 .collect(StreamUtils.toHtmlList());
         jepMessage.setText(html);

trunk/src/org/openstreetmap/josm/gui/layer/NoteLayer.java

@@ -312 +312 @@
             String commentText = comment.getText();
             //closing a note creates an empty comment that we don't want to show
-            if (commentText != null && !commentText.trim().isEmpty()) {
+            if (!Utils.isBlank(commentText)) {
                 sb.append("<hr/>");
                 String userName = XmlWriter.encode(comment.getUser().getName());

trunk/src/org/openstreetmap/josm/gui/layer/geoimage/ImageDisplay.java

@@ -40 +40 @@
 import org.openstreetmap.josm.tools.ImageProcessor;
 import org.openstreetmap.josm.tools.Logging;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -792 +793 @@
             errorMessage = null;
         }
-        if (errorMessage != null && !errorMessage.trim().isEmpty()) {
+        if (!Utils.isBlank(errorMessage)) {
             Rectangle2D errorStringSize = g.getFontMetrics(g.getFont()).getStringBounds(errorMessage, g);
             if (Boolean.TRUE.equals(ERROR_MESSAGE_BACKGROUND.get())) {

trunk/src/org/openstreetmap/josm/gui/layer/gpx/ConvertFromGpxLayerAction.java

@@ -157 +157 @@
         for (GpxExtension ext : exts) {
             String value = ext.getValue();
-            if (value != null && !value.isEmpty()) {
+            if (!Utils.isEmpty(value)) {
                 String extpre = "extension:";
                 String pre = ext.getPrefix();

trunk/src/org/openstreetmap/josm/gui/layer/gpx/ImportAudioAction.java

@@ -124 +124 @@
     private void importAudio(File audioFile, MarkerLayer ml, double firstStartTime, Markers markers) {
         URL url = Utils.fileToURL(audioFile);
-        boolean hasTracks = layer.data.tracks != null && !layer.data.tracks.isEmpty();
-        boolean hasWaypoints = layer.data.waypoints != null && !layer.data.waypoints.isEmpty();
+        boolean hasTracks = !Utils.isEmpty(layer.data.tracks);
+        boolean hasWaypoints = !Utils.isEmpty(layer.data.waypoints);
         Collection<WayPoint> waypoints = new ArrayList<>();
         boolean timedMarkersOmitted = false;

trunk/src/org/openstreetmap/josm/gui/preferences/PreferenceTabbedPane.java

@@ -437 +437 @@
             final Set<PluginInformation> toDownload = preference.getPluginsScheduledForUpdateOrDownload();
             final PluginDownloadTask task;
-            if (toDownload != null && !toDownload.isEmpty()) {
+            if (!Utils.isEmpty(toDownload)) {
                 task = new PluginDownloadTask(this, toDownload, tr("Download plugins"));
             } else {

trunk/src/org/openstreetmap/josm/gui/preferences/advanced/ListEditor.java

@@ -21 +21 @@
 import org.openstreetmap.josm.tools.GBC;
 import org.openstreetmap.josm.tools.SubclassFilteredCollection;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -44 +45 @@
     @Override
     public List<String> getData() {
-        return new ArrayList<>(SubclassFilteredCollection.filter(model.getData(), object -> object != null && !object.isEmpty()));
+        return new ArrayList<>(SubclassFilteredCollection.filter(model.getData(), object -> !Utils.isEmpty(object)));
     }
 

trunk/src/org/openstreetmap/josm/gui/preferences/display/GPXSettingsPanel.java

@@ -696 +696 @@
         putPref("colormode.heatmap.lower-limit", colorTypeHeatMapLowerLimit.getValue());
 
-        if (!global && layers != null && !layers.isEmpty()) {
+        if (!global && !Utils.isEmpty(layers)) {
             layers.forEach(l -> l.data.invalidate());
         }

trunk/src/org/openstreetmap/josm/gui/preferences/imagery/ImageryProvidersPanel.java

@@ -369 +369 @@
                 int viewIndex = defaultTable.convertRowIndexToView(i);
                 List<Shape> shapes = bounds.getShapes();
-                if (shapes != null && !shapes.isEmpty()) {
+                if (!Utils.isEmpty(shapes)) {
                     if (defaultTable.getSelectionModel().isSelectedIndex(viewIndex)) {
                         if (!mapPolygons.containsKey(i)) {

trunk/src/org/openstreetmap/josm/gui/preferences/map/MapPaintPreference.java

@@ -32 +32 @@
 import org.openstreetmap.josm.tools.GBC;
 import org.openstreetmap.josm.tools.Logging;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -169 +170 @@
             final MapCSSStyleSource css = new MapCSSStyleSource(entry);
             css.loadStyleSource();
-            if (css.title != null && !css.title.isEmpty()) {
+            if (!Utils.isEmpty(css.title)) {
                 return css.title;
             }

trunk/src/org/openstreetmap/josm/gui/preferences/plugin/PluginListPanel.java

@@ -137 +137 @@
             final PluginCheckBox cbPlugin = new PluginCheckBox(pi, selected, this, model);
             String pluginText = tr("{0}: Version {1} (local: {2})", pi.getName(), remoteversion, localversion);
-            if (pi.requires != null && !pi.requires.isEmpty()) {
+            if (!Utils.isEmpty(pi.requires)) {
                 pluginText += tr(" (requires: {0})", pi.requires);
             }

trunk/src/org/openstreetmap/josm/gui/preferences/plugin/PluginPreference.java

@@ -63 +63 @@
 import org.openstreetmap.josm.tools.ImageProvider;
 import org.openstreetmap.josm.tools.Logging;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -556 +557 @@
                             JOptionPane.QUESTION_MESSAGE
                             );
-                    if (s != null && !s.isEmpty()) {
+                    if (!Utils.isEmpty(s)) {
                         model.addElement(s);
                     }
@@ -582 +583 @@
                             list.getSelectedValue()
                             );
-                    if (s != null && !s.isEmpty()) {
+                    if (!Utils.isEmpty(s)) {
                         model.setElementAt(s, list.getSelectedIndex());
                     }

trunk/src/org/openstreetmap/josm/gui/preferences/projection/CodeProjectionChoice.java

@@ -16 +16 @@
 import org.openstreetmap.josm.data.projection.Projection;
 import org.openstreetmap.josm.data.projection.Projections;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -78 +79 @@
     @Override
     public void setPreferences(Collection<String> args) {
-        if (args != null && !args.isEmpty()) {
+        if (!Utils.isEmpty(args)) {
             code = args.iterator().next();
         }

trunk/src/org/openstreetmap/josm/gui/preferences/projection/CustomProjectionChoice.java

@@ -31 +31 @@
 import org.openstreetmap.josm.tools.ImageProvider;
 import org.openstreetmap.josm.tools.Logging;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -187 +188 @@
     @Override
     public void setPreferences(Collection<String> args) {
-        if (args != null && !args.isEmpty()) {
+        if (!Utils.isEmpty(args)) {
             pref = args.iterator().next();
         }

trunk/src/org/openstreetmap/josm/gui/preferences/projection/ListProjectionChoice.java

@@ -70 +70 @@
     public void setPreferences(Collection<String> args) {
         String zone = null;
-        if (args != null && !args.isEmpty()) {
+        if (!Utils.isEmpty(args)) {
             zone = args.iterator().next();
         }

trunk/src/org/openstreetmap/josm/gui/tagging/ac/AutoCompletionManager.java

@@ -291 +291 @@
         CheckParameterUtil.ensureParameterNotNull(list, "list");
         Collection<TaggingPreset> presets = r != null ? TaggingPresets.getMatchingPresets(null, r.getKeys(), false) : null;
-        if (r != null && presets != null && !presets.isEmpty()) {
+        if (r != null && !Utils.isEmpty(presets)) {
             for (TaggingPreset tp : presets) {
                 if (tp.roles != null) {
@@ -481 +481 @@
                     tagCache = null;
                     roleCache = null;
-                    ds = null;                    
+                    ds = null;
                 }
             }

trunk/src/org/openstreetmap/josm/gui/widgets/AbstractIdTextField.java

@@ -6 +6 @@
 import org.openstreetmap.josm.gui.datatransfer.ClipboardUtils;
 import org.openstreetmap.josm.tools.Logging;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -80 +81 @@
      */
     public boolean tryToPasteFrom(String contents) {
-        if (contents != null && !contents.trim().isEmpty()) {
+        if (!Utils.isBlank(contents)) {
             setText(contents.trim());
             clearTextIfInvalid();

trunk/src/org/openstreetmap/josm/gui/widgets/ChangesetIdTextField.java

@@ -7 +7 @@
 
 import org.openstreetmap.josm.tools.Logging;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -74 +75 @@
         public boolean readChangesetId() {
             String value = getComponent().getText();
-            if (value != null && !value.trim().isEmpty()) {
+            if (!Utils.isBlank(value)) {
                 value = value.trim();
                 id = 0;

trunk/src/org/openstreetmap/josm/gui/widgets/EditableList.java

@@ -20 +20 @@
 import org.openstreetmap.josm.gui.MainApplication;
 import org.openstreetmap.josm.tools.GBC;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -66 +67 @@
                     title,
                     JOptionPane.QUESTION_MESSAGE);
-            if (source != null && !source.isEmpty()) {
+            if (!Utils.isEmpty(source)) {
                 ((DefaultListModel<String>) sourcesList.getModel()).addElement(source);
             }
@@ -81 +82 @@
                 if (sourcesList.getModel().getSize() == 0) {
                     String source1 = JOptionPane.showInputDialog(MainApplication.getMainFrame(), title, title, JOptionPane.QUESTION_MESSAGE);
-                    if (source1 != null && !source1.isEmpty()) {
+                    if (!Utils.isEmpty(source1)) {
                         ((DefaultListModel<String>) sourcesList.getModel()).addElement(source1);
                     }
@@ -98 +99 @@
                         JOptionPane.QUESTION_MESSAGE, null, null,
                         sourcesList.getSelectedValue());
-                if (source2 != null && !source2.isEmpty()) {
+                if (!Utils.isEmpty(source2)) {
                     ((DefaultListModel<String>) sourcesList.getModel()).setElementAt(source2, row);
                 }

trunk/src/org/openstreetmap/josm/gui/widgets/JosmTextField.java

@@ -20 +20 @@
 import org.openstreetmap.josm.gui.MapFrame;
 import org.openstreetmap.josm.tools.Destroyable;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -192 +193 @@
             icon.paintIcon(this, g, Math.min(leftInsets, h / 2), h / 2);
         }
-        if (hint != null && !hint.isEmpty() && getText().isEmpty() && !isFocusOwner()) {
+        if (!Utils.isEmpty(hint) && getText().isEmpty() && !isFocusOwner()) {
             // Taken from http://stackoverflow.com/a/24571681/2257172
             int h = getHeight();

trunk/src/org/openstreetmap/josm/gui/widgets/UrlLabel.java

@@ -92 +92 @@
 
     protected final void refresh() {
-        if (url != null && !url.isEmpty()) {
+        if (!Utils.isEmpty(url)) {
             refresh("<html><a color=\"" + JosmEditorPane.getLinkColor() + "\" href=\"" + url + "\">" + description + "</a></html>",
                     Cursor.getPredefinedCursor(Cursor.HAND_CURSOR),
@@ -147 +147 @@
     @Override
     public void mouseClicked(MouseEvent e) {
-        if (url != null && !url.isEmpty()) {
+        if (!Utils.isEmpty(url)) {
             if (SwingUtilities.isLeftMouseButton(e)) {
                 OpenBrowser.displayUrl(url);

trunk/src/org/openstreetmap/josm/io/DefaultProxySelector.java

@@ -142 +142 @@
         httpProxySocketAddress = null;
         if (proxyPolicy == ProxyPolicy.USE_HTTP_PROXY) {
-            if (host != null && !host.trim().isEmpty() && port > 0) {
+            if (!Utils.isBlank(host) && port > 0) {
                 httpProxySocketAddress = new InetSocketAddress(host, port);
             } else {
@@ -154 +154 @@
         socksProxySocketAddress = null;
         if (proxyPolicy == ProxyPolicy.USE_SOCKS_PROXY) {
-            if (host != null && !host.trim().isEmpty() && port > 0) {
+            if (!Utils.isBlank(host) && port > 0) {
                 socksProxySocketAddress = new InetSocketAddress(host, port);
             } else {

trunk/src/org/openstreetmap/josm/io/GpxReader.java

@@ -32 +32 @@
 import org.openstreetmap.josm.tools.Logging;
 import org.openstreetmap.josm.tools.UncheckedParseException;
+import org.openstreetmap.josm.tools.Utils;
 import org.openstreetmap.josm.tools.XmlUtils;
 import org.openstreetmap.josm.tools.date.DateUtils;
@@ -661 +662 @@
                         message += '.';
                 }
-                if (parser.data.creator != null && !parser.data.creator.trim().isEmpty()) {
+                if (!Utils.isBlank(parser.data.creator)) {
                     message += "\n" + tr("The file was created by \"{0}\".", parser.data.creator);
                 }

trunk/src/org/openstreetmap/josm/io/GpxWriter.java

@@ -36 +36 @@
 import org.openstreetmap.josm.tools.JosmRuntimeException;
 import org.openstreetmap.josm.tools.Logging;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -134 +135 @@
 
         for (XMLNamespace n : namespaces) {
-            if (n.getURI() != null && n.getPrefix() != null && !n.getPrefix().isEmpty()) {
+            if (n.getURI() != null && !Utils.isEmpty(n.getPrefix())) {
                 out.println(String.format("    xmlns:%s=\"%s\"", n.getPrefix(), n.getURI()));
                 if (n.getLocation() != null) {
@@ -323 +324 @@
      */
     private void simpleTag(String tag, String content) {
-        if (content != null && !content.isEmpty()) {
+        if (!Utils.isEmpty(content)) {
             open(tag);
             out.print(encode(content));
@@ -332 +333 @@
 
     private void simpleTag(String tag, String content, String attributes) {
-        if (content != null && !content.isEmpty()) {
+        if (!Utils.isEmpty(content)) {
             open(tag, attributes);
             out.print(encode(content));

trunk/src/org/openstreetmap/josm/io/MessageNotifier.java

@@ -149 +149 @@
                         String username = Config.getPref().get("osm-server.username", null);
                         String password = Config.getPref().get("osm-server.password", null);
-                        return username != null && !username.isEmpty() && password != null && !password.isEmpty();
+                        return !Utils.isEmpty(username) && !Utils.isEmpty(password);
                     }
                 } else {
@@ -157 +157 @@
                         String username = credentials.getUsername();
                         char[] password = credentials.getPassword();
-                        return username != null && !username.isEmpty() && password != null && password.length > 0;
+                        return !Utils.isEmpty(username) && password != null && password.length > 0;
                     }
                 }

trunk/src/org/openstreetmap/josm/io/OsmApiException.java

@@ -218 +218 @@
             sb.append(tr("The server replied an error with code {0}.", responseCode));
         } else {
-            if (header != null && !header.isEmpty()) {
+            if (!Utils.isEmpty(header)) {
                 sb.append(tr(header));
             }
-            if (body != null && !body.isEmpty() && !body.equals(header)) {
+            if (!Utils.isEmpty(body) && !body.equals(header)) {
                 if (sb.length() > 0) {
                     sb.append(". ");

trunk/src/org/openstreetmap/josm/io/OsmChangeReader.java

@@ -16 +16 @@
 import org.openstreetmap.josm.gui.progress.ProgressMonitor;
 import org.openstreetmap.josm.tools.Pair;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -122 +123 @@
             }
         }
-        if (location != null && text != null && !text.isEmpty()) {
+        if (location != null && !Utils.isEmpty(text)) {
             noteData.createNote(location, text);
         }

trunk/src/org/openstreetmap/josm/io/OverpassDownloadReader.java

@@ -265 +265 @@
         boolean javaDur = false;
         if (matcher.matches()) {
-            javaPer = matcher.group(1) != null && !matcher.group(1).isEmpty();
-            javaDur = matcher.group(3) != null && !matcher.group(3).isEmpty();
+            javaPer = !Utils.isEmpty(matcher.group(1));
+            javaDur = !Utils.isEmpty(matcher.group(3));
             duration = 'P' + matcher.group(1).replace('X', 'M') + matcher.group(2);
             if (javaDur) {

trunk/src/org/openstreetmap/josm/io/auth/CredentialsManager.java

@@ -12 +12 @@
 import org.openstreetmap.josm.tools.CheckParameterUtil;
 import org.openstreetmap.josm.tools.Logging;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -128 +129 @@
         if (requestorType == RequestorType.SERVER && Objects.equals(OsmApi.getOsmApi().getHost(), host)) {
             String username = credentials.getUserName();
-            if (username != null && !username.trim().isEmpty()) {
+            if (!Utils.isBlank(username)) {
                 UserIdentityManager.getInstance().setPartiallyIdentified(username);
             }

trunk/src/org/openstreetmap/josm/io/imagery/WMSImagery.java

@@ -705 +705 @@
             String name, List<LayerDetails> selectedLayers, List<String> selectedStyles, String format, boolean transparent) {
         ImageryInfo i = new ImageryInfo(name, buildGetMapUrl(selectedLayers, selectedStyles, format, transparent));
-        if (selectedLayers != null && !selectedLayers.isEmpty()) {
+        if (!selectedLayers.isEmpty()) {
             i.setServerProjections(getServerProjections(selectedLayers));
         }

trunk/src/org/openstreetmap/josm/io/remotecontrol/RequestProcessor.java

@@ -456 +456 @@
             usage.append("<li>")
                  .append(handler.getKey());
-            if (sample.getUsage() != null && !sample.getUsage().isEmpty()) {
+            if (!Utils.isEmpty(sample.getUsage())) {
                 usage.append(" &mdash; <i>").append(sample.getUsage()).append("</i>");
             }

trunk/src/org/openstreetmap/josm/io/remotecontrol/handler/ImportHandler.java

@@ -86 +86 @@
         // For user-friendliness, let's try to decode these OSM API calls to give a better confirmation message.
         Set<String> taskMessages = new LinkedHashSet<>();
-        if (suitableDownloadTasks != null && !suitableDownloadTasks.isEmpty()) {
+        if (!Utils.isEmpty(suitableDownloadTasks)) {
             for (DownloadTask task : suitableDownloadTasks) {
                 taskMessages.add(Utils.firstNonNull(task.getConfirmationMessage(url), url.toString()));

trunk/src/org/openstreetmap/josm/io/remotecontrol/handler/RequestHandler.java

@@ -343 +343 @@
     private <T> T get(String key, Function<String, T> parser, Supplier<T> defaultSupplier) {
         String val = args.get(key);
-        return val != null && !val.isEmpty() ? parser.apply(val) : defaultSupplier.get();
+        return !Utils.isEmpty(val) ? parser.apply(val) : defaultSupplier.get();
     }
 

trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java

@@ -1141 +1141 @@
                 plugins = buildListOfPluginsToLoad(parent, monitor.createSubTaskMonitor(1, false));
                 // If only some plugins have to be updated, filter the list
-                if (pluginsWanted != null && !pluginsWanted.isEmpty()) {
+                if (!Utils.isEmpty(pluginsWanted)) {
                     final Collection<String> pluginsWantedName = Utils.transform(pluginsWanted, piw -> piw.name);
                     plugins = SubclassFilteredCollection.filter(plugins, pi -> pluginsWantedName.contains(pi.name));
@@ -1594 +1594 @@
             PluginInformation pi = pp.getPluginInformation();
             pl.remove(pi.name);
-            pl.add(pi.name + " (" + (pi.localversion != null && !pi.localversion.isEmpty()
+            pl.add(pi.name + " (" + (!Utils.isEmpty(pi.localversion)
                     ? pi.localversion : "unknown") + ')');
         }
@@ -1608 +1608 @@
         for (final PluginInformation info : getPlugins()) {
             String name = info.name
-            + (info.localversion != null && !info.localversion.isEmpty() ? " Version: " + info.localversion : "");
+            + (!Utils.isEmpty(info.localversion) ? " Version: " + info.localversion : "");
             pluginTab.add(new JLabel(name), GBC.std());
             pluginTab.add(Box.createHorizontalGlue(), GBC.std().fill(GBC.HORIZONTAL));

trunk/src/org/openstreetmap/josm/plugins/PluginInformation.java

@@ -261 +261 @@
         stage = stageStr == null ? 50 : Integer.parseInt(stageStr);
         version = attr.getValue("Plugin-Version");
-        if (version != null && !version.isEmpty() && version.charAt(0) == '$') {
+        if (!Utils.isEmpty(version) && version.charAt(0) == '$') {
             invalidManifestEntries.add("Plugin-Version");
         }

trunk/src/org/openstreetmap/josm/plugins/ReadRemotePluginInformationTask.java

@@ -225 +225 @@
             }
             panel.add(new JLabel("<html><body width=\"500\"><b>"+b.toString().trim()+"</b></body></html>"), GBC.eol().insets(0, 0, 0, 10));
-            if (details != null && !details.isEmpty()) {
+            if (!Utils.isEmpty(details)) {
                 panel.add(new JLabel(tr("Details:")), GBC.eol().insets(0, 0, 0, 10));
                 JosmTextArea area = new JosmTextArea(details);

trunk/src/org/openstreetmap/josm/tools/ExceptionUtil.java

@@ -313 +313 @@
         String msg = e.getDisplayMessage();
 
-        if (msg != null && !msg.isEmpty()) {
+        if (!Utils.isEmpty(msg)) {
             return tr("<html>"
                     + "Authorisation at the OSM server failed.<br>"

trunk/src/org/openstreetmap/josm/tools/HttpClient.java

@@ -147 +147 @@
                 }
                 cr = performConnection();
-                final boolean hasReason = reasonForRequest != null && !reasonForRequest.isEmpty();
+                final boolean hasReason = !Utils.isEmpty(reasonForRequest);
                 logRequest("{0} {1}{2} -> {3} {4} ({5}{6})",
                         getRequestMethod(), getURL(), hasReason ? (" (" + reasonForRequest + ')') : "",

trunk/src/org/openstreetmap/josm/tools/ImageProvider.java

@@ -898 +898 @@
                 String cacheName = prefix + fullName;
                 /* cache separately */
-                if (dirs != null && !dirs.isEmpty()) {
+                if (!Utils.isEmpty(dirs)) {
                     cacheName = "id:" + id + ':' + fullName;
                     if (archive != null) {
@@ -1956 +1956 @@
     public String toString() {
         return ("ImageProvider ["
-                + (dirs != null && !dirs.isEmpty() ? "dirs=" + dirs + ", " : "") + (id != null ? "id=" + id + ", " : "")
-                + (subdir != null && !subdir.isEmpty() ? "subdir=" + subdir + ", " : "") + "name=" + name + ", "
+                + (!Utils.isEmpty(dirs) ? "dirs=" + dirs + ", " : "") + (id != null ? "id=" + id + ", " : "")
+                + (!Utils.isEmpty(subdir) ? "subdir=" + subdir + ", " : "") + "name=" + name + ", "
                 + (archive != null ? "archive=" + archive + ", " : "")
-                + (inArchiveDir != null && !inArchiveDir.isEmpty() ? "inArchiveDir=" + inArchiveDir : "") + ']').replaceAll(", \\]", "]");
+                + (!Utils.isEmpty(inArchiveDir) ? "inArchiveDir=" + inArchiveDir : "") + ']').replaceAll(", \\]", "]");
     }
 }

trunk/src/org/openstreetmap/josm/tools/LanguageInfo.java

@@ -306 +306 @@
         if (c.isEmpty())
             c = null;
-        if (v != null && !v.isEmpty()) {
+        if (!Utils.isEmpty(v)) {
             if (c != null)
                 list.add(lang+'_'+c+'@'+v);

trunk/src/org/openstreetmap/josm/tools/PlatformHookUnixoid.java

@@ -156 +156 @@
                     try {
                         String version = Utils.execOutput(Arrays.asList(args));
-                        if (version != null && !version.isEmpty()) {
+                        if (!Utils.isEmpty(version)) {
                             return packageName + ':' + version;
                         }
@@ -240 +240 @@
                 // see https://www.linuxbase.org/lsb-cert/productdir.php?by_prod )
                 String line = exec("lsb_release", "-ds");
-                if (line != null && !line.isEmpty()) {
+                if (!Utils.isEmpty(line)) {
                     line = line.replaceAll("\"+", "");
                     line = line.replace("NAME=", ""); // strange code for some Gentoo's
@@ -262 +262 @@
                 }) {
                     String description = info.extractDescription();
-                    if (description != null && !description.isEmpty()) {
+                    if (!Utils.isEmpty(description)) {
                         return "Linux " + description;
                     }
@@ -356 +356 @@
             }
             // Append prefix if any
-            if (result != null && !result.isEmpty() && prefix != null && !prefix.isEmpty()) {
+            if (!Utils.isEmpty(result) && !Utils.isEmpty(prefix)) {
                 result = prefix + result;
             }
@@ -390 +390 @@
         } else {
             String xdgCacheDir = getSystemEnv("XDG_CACHE_HOME");
-            if (xdgCacheDir != null && !xdgCacheDir.isEmpty()) {
+            if (!Utils.isEmpty(xdgCacheDir)) {
                 return new File(xdgCacheDir, Preferences.getJOSMDirectoryBaseName());
             } else {
@@ -405 +405 @@
         } else {
             String xdgConfigDir = getSystemEnv("XDG_CONFIG_HOME");
-            if (xdgConfigDir != null && !xdgConfigDir.isEmpty()) {
+            if (!Utils.isEmpty(xdgConfigDir)) {
                 return new File(xdgConfigDir, Preferences.getJOSMDirectoryBaseName());
             } else {
@@ -420 +420 @@
         } else {
             String xdgDataDir = getSystemEnv("XDG_DATA_HOME");
-            if (xdgDataDir != null && !xdgDataDir.isEmpty()) {
+            if (!Utils.isEmpty(xdgDataDir)) {
                 return new File(xdgDataDir, Preferences.getJOSMDirectoryBaseName());
             } else {

trunk/src/org/openstreetmap/josm/tools/template_engine/ContextSwitchTemplate.java

@@ -23 +23 @@
 import org.openstreetmap.josm.data.osm.search.SearchCompiler.Or;
 import org.openstreetmap.josm.data.osm.search.SearchCompiler.Parent;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -369 +370 @@
         if (dataProvider instanceof OsmPrimitive) {
             List<OsmPrimitive> primitives = context.getPrimitives((OsmPrimitive) dataProvider);
-            if (primitives != null && !primitives.isEmpty()) {
+            if (!Utils.isEmpty(primitives)) {
                 template.appendText(result, primitives.get(0));
             }
@@ -380 +381 @@
         if (dataProvider instanceof OsmPrimitive) {
             List<OsmPrimitive> primitives = context.getPrimitives((OsmPrimitive) dataProvider);
-            if (primitives != null && !primitives.isEmpty()) {
+            if (!Utils.isEmpty(primitives)) {
                 return template.isValid(primitives.get(0));
             }