Changeset 16509 in josm for trunk/src/org/openstreetmap/josm/actions/ExpertToggleAction.java

Timestamp:

2020-05-27T11:16:39+02:00 (4 years ago)

Author:

GerdP

Message:

see #19296: Actions should avoid to install listeners which are not needed

• either don't call installAdapters() or overwrite listenToSelectionChange()
• partly reverts previous changes so that installAdapters() is not overwritten

One has to be careful because installAdapters() also calls initEnabledState()

File:

• trunk/src/org/openstreetmap/josm/actions/ExpertToggleAction.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/actions/ExpertToggleAction.java

@@ -9 +9 @@
 import org.openstreetmap.josm.data.preferences.BooleanProperty;
 import org.openstreetmap.josm.gui.MainApplication;
+import org.openstreetmap.josm.tools.ImageProvider;
 import org.openstreetmap.josm.tools.ListenerList;
 
@@ -110 +111 @@
     public ExpertToggleAction() {
         super(tr("Expert Mode"),
-              "expert",
+                new ImageProvider("expert").setOptional(true),
               tr("Enable/disable expert mode"),
               null,
-              false /* register toolbar */
+              false /* register toolbar */, null, false
         );
         setToolbarId("expertmode");