Changeset 15912 in josm for trunk/src/com/kitfox/svg/SVGElement.java

Timestamp:

2020-02-23T13:40:09+01:00 (4 years ago)

Author:

simon04

Message:

see #18749 - Use efficient/unmodifiable maps for svgSalamander

File:

• trunk/src/com/kitfox/svg/SVGElement.java (modified) (4 diffs)

trunk/src/com/kitfox/svg/SVGElement.java

@@ -47 +47 @@
 import java.util.LinkedList;
 import java.util.List;
+import java.util.Map;
 import java.util.Set;
 import java.util.regex.Matcher;
@@ -89 +90 @@
      * Styles defined for this elemnt via the <b>style</b> attribute.
      */
-    protected final HashMap<String, String> inlineStyles = new HashMap<>();
+    private Map<String, String> inlineStyles = Collections.emptyMap();
     /**
      * Presentation attributes set for this element. Ie, any attribute other
      * than the <b>style</b> attribute.
      */
-    protected final HashMap<String, String> presAttributes = new HashMap<>();
+    private Map<String, String> presAttributes = Collections.emptyMap();
     /**
      * A list of presentation attributes to not include in the presentation
@@ -273 +274 @@
         if (style != null)
         {
-            XMLParseUtil.parseStyle(style, inlineStyles);
+            inlineStyles = XMLParseUtil.parseStyle(style);
         }
 
@@ -299 +300 @@
             String value = attrs.getValue(i);
 
+            if (i == 0)
+            {
+                presAttributes = new HashMap<>();
+            }
             presAttributes.put(name, value == null ? null : value.intern());
         }
+        presAttributes = XMLParseUtil.toUnmodifiableMap(presAttributes);
     }