Changeset 11889 in josm for trunk/src/org/openstreetmap/josm/data/validation/routines/UrlValidator.java

Timestamp:

2017-04-12T22:22:52+02:00 (8 years ago)

Author:

Don-vip

Message:

PMD - fix some InefficientEmptyStringCheck (new in PMD 5.5.5)

File:

• trunk/src/org/openstreetmap/josm/data/validation/routines/UrlValidator.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/validation/routines/UrlValidator.java

@@ -24 +24 @@
 import java.util.HashSet;
 import java.util.Locale;
+import java.util.Optional;
 import java.util.Set;
 import java.util.regex.Matcher;
@@ -428 +429 @@
         }
 
-        String extra = authorityMatcher.group(PARSE_AUTHORITY_EXTRA);
-        if (extra != null && !extra.trim().isEmpty()) {
-            return false;
-        }
-
-        return true;
+        return Optional.ofNullable(authorityMatcher.group(PARSE_AUTHORITY_EXTRA)).orElse("").trim().isEmpty();
     }