[Patch] Wrong preset for "Reitplatz"

[NopMap]

The preset for "Reitplatz" uses the tags sport=equestrian, leisure=horse_riding.

It should be leisure=pitch, sport=equestrian. Just the same like all other sports.

​http://wiki.openstreetmap.org/wiki/Pitch
​http://wiki.openstreetmap.org/wiki/Reitplatz#St.C3.A4lle_und_Reitanlagen

[skyper]

Replying to NopMap:

The preset for "Reitplatz" uses the tags sport=equestrian, leisure=horse_riding.

It should be leisure=pitch, sport=equestrian. Just the same like all other sports.

​http://wiki.openstreetmap.org/wiki/Pitch
​http://wiki.openstreetmap.org/wiki/Reitplatz#St.C3.A4lle_und_Reitanlagen

The whole situation is a bit unclear:

• The ​wiki page for leisure=horse_riding redirects to a proposed features "Riding Stable" and was created last autumn by a certain user who added several horse-specific tags in this period.
• On the ​German wiki page for horse features leisure=horse_riding is only used for nodes but for sport=horse_racing leisure=pitch is used and leisure=track is not even mentioned.

[skyper]

At least the German translation of leisure=track/pitch do not really work.

[skyper]

patch

[skyper]

Please find a patch attached.

Think translation for value track needs different cases for highway=track and leisure=track. Do not know how to change this in Launchpad and I suffer lots of timeout errors.

[stoecker]

You need to add a context to the preset to one of the two. Then they will get different in launchpad.

For timeouts, you can increase Bug-Heat for ​https://bugs.launchpad.net/bugs/736005.

[skyper]

Replying to stoecker:

You need to add a context to the preset to one of the two. Then they will get different in launchpad.

Do not really understand. Do you mean I need to add "track" as context to one preset.

Just noticed that my patch is needing some context for leisure=horse_riding to mark the difference.

For timeouts, you can increase Bug-Heat for ​https://bugs.launchpad.net/bugs/736005.

Done.

[skyper]

One problem is that leisure=track is named "Racetrack" in the preset. (line 4006,r5914)

[stoecker]

There is a key values_context="context" for values, name_context for name entries, ... (see TaggingPresets).

E.g. add add values_context="riding" to the horse related presets.

[skyper]

Replying to stoecker:

There is a key values_context="context" for values, name_context for name entries, ... (see TaggingPresets).

E.g. add add values_context="riding" to the horse related presets.

Thanks.

I fear we need some values_context for track.

[skyper]

I did rework the patch. Please have a look at version two.

[stoecker]

Hmm, that is no proper patch in unified diff format.

[skyper]

real patch version 2

[skyper]

Replying to stoecker:

Hmm, that is no proper patch in unified diff format.

Sorry, I did replace it.

[Don-vip]

In 5942/josm:

fix #8644 - Update of horse-related presets (patch by skyper)