[Patch] false warning: combination of sport and building:part

[Fred73000]

Note : I don't use JOSM so I cannot create a report for this ticket.

The problem in josm is here :
https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/combinations.mapcss#L545

The problem is : [!"building:part"] is missing.

To illustrate, see this building ​https://www.openstreetmap.org/way/71485515

This sports_hall has 2 building parts = one big area where people can play basketball, volleyball, handball. And a smaller room dedicated to boxing. The tag "sport" is on each "building:part" but osmose (and probably josm) shows a warning "sport without physical feature" while a physical feature is present.

[GerdP]

Thanks for the suggested fix. If nobody complains I'll commit the patch tomorrow.

[GerdP]

In 19035/josm:

fix #23604: false warning in osmose because of a problem in JOSM

• add tag key building:part as a physical feature for sport=*

[skyper]

I guess it does not matter for the assertNoMatch but building:part on a node is wrong, in general, and way would be a better choice.

[aceman]

I feel 'sport' without any of the 'leisure' tags is weird. How is that building part used for the sport? Do they do the sport on the walls or roof of the building (like maybe climbing could be done). Otherwise why don't the building parts have at least their own leisure=sports_hall tags, or leisure=pitch on a node inside the building.
See top of ​https://wiki.openstreetmap.org/wiki/Key:sport .

[GerdP]

That's a good question. I just added building:part because building was already listed, see #10918.

[skyper]

I think building:part=* is acceptable thinking about a sports_hall with several rooms inside the building for different types or sports like one common indoor pitch, sport=multi, a room for boxing and a room with equipment for training power and strength.
building=* without leisure=* is likely more problematic if you leave out outdoor sports like climbing and water sports.

[Fred73000]

Replying to aceman:

I understand what you mean.
But there is only one sports hall, with walls, 2 roofs and several rooms in it (2 places for sports and a cloakroom). To add leisure=sports_hall to each room will mean there are 3 sports halls, it is not the reality.
And leisure=pitch is for the area where people are playing : in the room where baskeball is played, there is the pitch but also bleachers for publics (the sports hall is used for official competitions). And for the boxing room, there is the boxing ring (which could be tagged with pitch) but also equipments for training : all the room is for boxing, the pitch is a small part in it (and I dont know where).