Modify ↓

Opened 3 months ago

Closed 3 months ago

#23521 closed defect (fixed)

[Patch] fix some memory leak(s)

Reported by: GerdP Owned by: Zverikk
Priority: normal Milestone:
Component: Plugin reltoolbox Version:
Keywords: Cc:

Description

I found some memory leaks regarding the plugin, most are related to #19885, some to a missing dlg.dispose() call.

Attachments (2)

23521-alpha.patch​ (51.7 KB ) - added by GerdP 3 months ago.
also fixes various checkstyle and sonar issues
23521.patch​ (56.3 KB ) - added by GerdP 3 months ago.
fixes all memory leaks that I found, replaces most ChangeCommand instances by better specialized alternatives

Download all attachments as: .zip

Change History (5)

by GerdP, 3 months ago

Attachment: 23521-alpha.patch​ added

also fixes various checkstyle and sonar issues

comment:1 by GerdP, 3 months ago

The major goal of the patch is to replace ChangeCommand by specialised commands which don't require a clone of the OSM object.
Some classes are not yet done because of complexity.

by GerdP, 3 months ago

Attachment: 23521.patch​ added

fixes all memory leaks that I found, replaces most ChangeCommand instances by better specialized alternatives

comment:2 by GerdP, 3 months ago

Summary: [WIP Patch] fix some memory leak(s) → [Patch] fix some memory leak(s)

I'll commit this patch in the next days if nobody complains.

comment:3 by GerdP, 3 months ago

Resolution: → fixed
Status: new → closed

In 36217/osm:

fix #23521: fix some memory leaks

  • dispose dialogs
  • either avoid to create clones of ways or relations or use setNodes(null) / setMembers(null)
  • replaces most ChangeCommand instances by better specialized alternatives
  • add some comments
  • fix some checkstyle / sonar issues

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Zverikk.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.