[Patch] Don't automatically enlarge "Validation Results" panel

[PPete2]

I'm using JOSM v18969 on Windows 10, installed with Windows-setup file.

Right now each time JOSM detects a validation warning, the "Validation Results" panel is enlarged. Undependend if its completely minimized, or opened with a small height.
Please keep the panel as it is before, and let the user enlarge it on its own. Reason: This panel is regularly undesiredly taking important space from other opened panels.

=>

[GerdP]

I can only reproduce that when the window is collapsed (as shown in the screen shot). When the window is opened the size is not changed.
It should be possible to add a new preference to keep a collapsed validation window in that state.

[GerdP]

implement new preference validator.force.unfurl.window with default value true , cleanup of duplicated / unnecessary code

[GerdP]

Furher thought:
A dialog that is collapsed is stored with a lastheight = 0 in the preferences, therefore it requires more code to unfurl a dialog (only) to its previous height.

[PPete2]

I uninstalled JOSM, completly deleted its %APPDATA%\josm\ folder and reinsalled JOSM and all former used Plugins. Now the height of opened "Validation Results" panel is kept.
I support the idea to also keep a collapsed validation window in its collapsed state.

[GerdP]

In 19000/josm:

fix #23519: Don't automatically enlarge "Validation Results" panel

• implement new preference validator.force.unfurl.window with default value true, if set to false the window is not unfurled
• code cleanup to remove duplicate or obsolete code

[GerdP]

@PPete2: I am not sure if the new preference validator.force.unfurl.window works as you intended. In the German discussion you mentioned that this happens on upload, here you didn't.
So, what should happen with validator.force.unfurl.window=false

• when there is no validator window and user starts the normal validation? With the current implementation, the validation window is not created.
• when the window is collapsed? With the current implementation, the validation window is stays collapsed.

[PPete2]

I have to say, that I just "use" automated validation during upload, I hardly use manual validation. But I think both variants can be treated the same way.

a) If there's no validation panel on the right => place panel and open it
b) If there's collapsed validation panel on the right => keep it collapsed
c) If there's opened validation panel on the right => keep it openend but don't change its height

[GerdP]

OK, thanks, that's good for me as well. I'll try to find a solution because a) doesn't happen now.

[GerdP]

In 19005/josm:

fix #23519: Don't automatically enlarge "Validation Results" panel

• show and unfurl "Validation Results" panel if not yet visible unless the tree is empty and the validation was triggered by an upload (see #23187)