Modify

Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#23514 closed defect (fixed)

Integration tests for tagging presets fail

Reported by: skyper Owned by: team
Priority: normal Milestone:
Component: Unit tests Version:
Keywords: regions tagging preset Cc: stoecker, taylor.smock

Description

Copied from 23290#comment:10:

The integration test jenkins/job/JOSM-Integration/9800/jdk=JDK8/testReport/junit/org.openstreetmap.josm.gui.preferences.map/TaggingPresetPreferenceTestIT/Internal_Preset___https___josm_openstreetmap_de_browser_trunk_data_defaultpresets_xml/ is failing, now:

Internal Preset => [resource://data/defaultpresets.xml => org.openstreetmap.josm.tools.XmlParsingException:
org.openstreetmap.josm.tools.XmlParsingException (at line 1,468, column 140)
java.lang.reflect.InvocationTargetException] ==> expected: <true> but was: <false>

This and the popular tags check (org.openstreetmap.josm.data.osm.TaginfoTestIT.testCheckPopularTags()) are still failing:

java.lang.NullPointerException
	at org.openstreetmap.josm.data.validation.tests.TagChecker.getPresetValues(TagChecker.java:566)
	at org.openstreetmap.josm.data.validation.tests.TagChecker.isTagInPresets(TagChecker.java:592)
	at org.openstreetmap.josm.data.osm.TaginfoTestIT.testCheckPopularTags(TaginfoTestIT.java:57)

I am not sure if there is a relation to introducing the "regions checks" (#23290) or if it just happened to come up coincidentally at the same time.

Attachments (0)

Change History (2)

comment:1 by GerdP, 2 months ago

Resolution: fixed
Status: newclosed

In 19003/josm:

fix #23514: add @Territories annotation

comment:2 by GerdP, 2 months ago

In 19004/josm:

see #23514: add @Territories annotation

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.