When hitting "Upload All Changes" button the upload proceeds without the Upload window showing before

[SekeRob]

What steps will reproduce the problem?

1. Open a WIP data file saved previous day or any time before JOSM was closed.
2. Open JOSM, select 1. file, hit the "Upload All Changes" toolbar button to get to the upload interface, normally prefaced with the window showing the validation check cycle.
3. The changes are uploaded without the Upload comment/sources interface showing up first nor the validation cycle is executed.

What is the expected result?

The Validation run to execute and the "Upload to ..." window to appear.

What happens instead?

See point 3. of step sequence.

Please provide any additional information below. Attach a screenshot if possible.

When opening the OSM website to view the change set history, ​example it shows no comment/no source references of imagery used.

The reason for hitting the upload button on toolbar is to get to the left pane list which shows the last node edited at top, for a zoom-to to continue where left off the previous session for the data set. No knowledge of shortcut to jump straight to the last added/changed node.
The UtilsPlugin2 shortcuts of Shift+Z and Alt+Shift+Z to select the last node/way edited but does not work on a newly opened data file with saved, not yet uploaded edits.

This has happened multiples times. At the very least I'd expect the pre-upload validation cycle to kick in, but does not.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2024-02-05 12:56:34 +0100 (Mon, 05 Feb 2024)
Revision:18969
Build-Date:2024-02-06 02:30:58
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18969 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19045)
Memory Usage: 3110 MB / 4084 MB (1185 MB allocated, but free)
Java version: 21.0.1+12-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Dicedtea-web.bin.location=%UserProfile%\AppData\Local\Programs\OpenWebStart\javaws, -Djava.util.Arrays.useLegacyMergeSort=true, --add-exports=jdk.deploy/com.sun.deploy.config=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-reads=java.naming=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.action=ALL-UNNAMED,java.desktop, --add-reads=java.base=ALL-UNNAMED,java.desktop, --add-exports=java.naming/com.sun.jndi.toolkit.url=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/sun.awt=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-exports=java.base/sun.security.validator=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.base/sun.net.www.protocol.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/jdk.internal.util.jar=ALL-UNNAMED,java.desktop, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, --add-exports=java.base/com.sun.net.ssl.internal.ssl=ALL-UNNAMED,java.desktop, --add-exports=javafx.graphics/com.sun.javafx.application=ALL-UNNAMED, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.desktop/sun.awt.X11=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,java.desktop,jdk.jsobject, --add-exports=java.base/sun.net.www.protocol.http=ALL-UNNAMED,java.desktop, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-exports=java.base/sun.security.util=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-reads=java.desktop=ALL-UNNAMED,java.naming, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-exports=java.base/sun.security.x509=ALL-UNNAMED,java.desktop, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-exports=java.desktop/javax.jnlp=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.provider=ALL-UNNAMED,java.desktop, -Djava.security.manager=allow]
Dataset consistency test: No problems found

Plugins:
+ KartaView (490)
+ Mapillary (2.2.0)
+ OpeningHoursEditor (36196)
+ Relation.Validation.Plugin (1.0.1)
+ RoadSigns (36196)
+ apache-commons (36176)
+ easypresets (1623509627)
+ editgpx (36126)
+ ejml (36176)
+ graphview (36196)
+ gridify (1606242219)
+ jaxb (36118)
+ jogl (1.2.3)
+ kendzi3d-resources (0.0.2)
+ log4j (36176)
+ lwjgl (36176)
+ lwjgl-windows (36176)
+ measurement (36200)
+ notesolver (0.5.0)
+ pmtiles (36156)
+ pt_assistant (632)
+ reltoolbox (36200)
+ reverter (36196)
+ rex (53)
+ routing (36200)
+ tageditor (36200)
+ todo (137)
+ turnlanes (36200)
+ turnlanes-tagging (0.0.5)
+ turnrestrictions (36200)
+ utilsplugin2 (36200)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/TurnLanes&zip=1
+ https://raw.githubusercontent.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml
+ <josm.pref>/EasyPresets.xml
+ https://github.com/kendzi/Simple3dBuildingsPreset/releases/download/0.9_2018-05-08/s3db-preset.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/AdvertisingPreset&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Golf_Course&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Maxspeed-zones&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/IT.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/Manholes&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Potlatch2&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Admin_Boundaries&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/IncompleteObjectWarnings&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings_en&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
- https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_EUR_OC.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/european-waterways-classification-style/CEMT-style.mapcss
- https://josm.openstreetmap.de/wiki/Styles/Waterways
- https://josm.openstreetmap.de/josmfile?page=Styles/Waterways&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/ColorWays&style
+ https://gitlab.com/cartocite/josm-style-traffic-signs-orientation/-/raw/main/traffic_sign_orientation_style.zip

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/ItalySpecific&zip=1

Last errors/warnings:
- 00088.328 E: Region [TMS_BLOCK_v2] : Failure getting from disk--IOException, key = Esri World Imagery (Clarity) Beta:https://clarity.maptiles.arcgis.com/arcgis/rest/services/World_Imagery/MapServer/tile/{zoom}/{y}/{x}/15/17633/12149
- 00088.328 E: Region [TMS_BLOCK_v2] : Failure getting from disk--IOException, key = Esri World Imagery (Clarity) Beta:https://clarity.maptiles.arcgis.com/arcgis/rest/services/World_Imagery/MapServer/tile/{zoom}/{y}/{x}/15/17630/12149
- 00088.329 E: Region [TMS_BLOCK_v2] : Failure getting from disk--IOException, key = Esri World Imagery (Clarity) Beta:https://clarity.maptiles.arcgis.com/arcgis/rest/services/World_Imagery/MapServer/tile/{zoom}/{y}/{x}/15/17632/12150
- 00088.329 E: Region [TMS_BLOCK_v2] : Failure getting from disk--IOException, key = Esri World Imagery (Clarity) Beta:https://clarity.maptiles.arcgis.com/arcgis/rest/services/World_Imagery/MapServer/tile/{zoom}/{y}/{x}/15/17630/12150
- 00113.937 E: org.openstreetmap.josm.io.IllegalDataException: Line 173,937 column 34: XML document structures must start and end within the same entity.. Cause: javax.xml.stream.XMLStreamException: ParseError at [row,col]:[173937,34]
- 00113.958 E: Error - <html>Could not read file '01 Maiella WIP.osm'.<br>Error is:<br>Line 173,937 column 34: XML document structures must start and end within the same entity.</html>
- 00122.197 E: org.openstreetmap.josm.io.IllegalDataException: Line 173,937 column 34: XML document structures must start and end within the same entity.. Cause: javax.xml.stream.XMLStreamException: ParseError at [row,col]:[173937,34]
- 00122.208 E: Error - <html>Could not read file '01 Maiella WIP.osm'.<br>Error is:<br>Line 173,937 column 34: XML document structures must start and end within the same entity.</html>
- 00147.567 E: org.openstreetmap.josm.io.IllegalDataException: Line 173,937 column 34: XML document structures must start and end within the same entity.. Cause: javax.xml.stream.XMLStreamException: ParseError at [row,col]:[173937,34]
- 00147.576 E: Error - <html>Could not read file '01 Maiella WIP.osm'.<br>Error is:<br>Line 173,937 column 34: XML document structures must start and end within the same entity.</html>

[taylor.smock]

I wasn't able to reproduce. Either I misunderstood the steps to reproduce, or there is something else going on. Can you share a sample file?

[SekeRob]

Hi, thanks for attempting to repro. As noted, happens sometimes not always. Will try to backup the file (actually, I've got JOSM set to always backup the previous version, so when it happens again, I'll make a copy of that one) and in actuality still have the .osm~ file post upload and save of the offending upload, were it not it hit the "Upload failed for 00 WIP Castel di Ieri.osm~" 20 MB restriction (it's 21.5MB). I've purged an area I know not to have been touching, saved it and see it's shrunk to 14MB. Theoretically if you hit Update data, it would fetch that what I've purged.

[skyper]

Tip: By choosing the proper file extension (file type) in the save file dialog you should be able to get small file sizes. Otherwise zipping an .osm file is no problem, either.