Resetting preference validator.selectionFilter results in broken validator

[GerdP]

What steps will reproduce the problem?

1. Start JOSM with clean home dir
2. enable expert mode
3. set preference validator.selectionFilter to true
4. download some data which contains problems and run validator, this should show the validation tree with errors and warnings
5. select an object which is not related to any of the warnings, the validation tree should be empty now because of the preference validator.selectionFilter
6. decide that you don't like the effect of the filter and reset the preference to false

What is the expected result?

Validator tree is refreshed so that all errors and warnings are shown

What happens instead?

tree remains empty, even when you clear the selection and run validator again

Please provide any additional information below. Attach a screenshot if possible.

Problem is in the implementation of the filter. It is not reset when the preference is changed and when it is set to false when the selection is not empty this selection is kept in the filter as long as JOSM runs.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2024-01-16 08:06:33 +0100 (Tue, 16 Jan 2024)
Revision:18940
Build-Date:2024-01-17 02:31:01
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18940 de) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19045)
Memory Usage: 529 MB / 1888 MB (135 MB allocated, but free)
Java version: 17.0.8+7-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: de_DE
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18789, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\HWConsole.exe]
Dataset consistency test: No problems found

Last errors/warnings:
- 00000.397 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.399 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00000.722 E: java.security.KeyStoreException: Windows-ROOT not found. Ursache: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available

[GerdP]

In 18951/josm:

fix #23430: Resetting preference validator.selectionFilter results in broken validator

• always set filter when selection was changed
• updateSelection when preferences were changed so that a change of the preference validator.selectionFilter is applied immediately

[GerdP]

In 18952/josm:

see #23430: Resetting preference validator.selectionFilter results in broken validator

• improve performance: only call tree.setFilter() when really needed, as it always triggers buildTree()

[taylor.smock]

Possible regression: #23540.