[Patch] Add "amenity=bicycle_wash" as a preset

[mcliquid]

Recognize ​amenity=bicycle_wash as a preset in "Transport/Bicycle/Bicycle Wash" and render tagged objects using a dedicated icon (see below).

Today the proposal for amenity=bicycle_wash was accepted. In this context, I would also like to request the acceptance of this tag in the main OpenStreetMap style. The use of the tag will remain low, as there will never be a bike wash station on every street corner, but the icon is already prepared and linked here, so it would be a good thing to find it on the map.

OSM Wiki: ​https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dbicycle_wash
Proposed Icon: ​https://wiki.openstreetmap.org/wiki/File:Bicycle_wash.svg
PR in iD tagging scheme: ​https://github.com/openstreetmap/id-tagging-schema/pull/1032

[taylor.smock]

If you are willing to write the preset, I would be more than willing to review and merge it.
Failing that, it will happen when usage of amenity=bicycle_wash hits 10k uses.

[mcliquid]

Does this goes in the right direction? ​https://github.com/mcliquid/josm/commit/2d648300993390b6c46ce6bfd4a79a98f0f65cdf

[taylor.smock]

Looks like it; you are missing the icon though.

[mcliquid]

I've added this Pull Request: ​https://github.com/JOSM/josm/pull/134

[gaben]

Please specify the icon rendering in resources/styles/standard/elemstyles.mapcss. Also see DevelopersGuide/DefaultPresets and make sure the icon is rectangular.

[mcliquid]

Hi gaben, I've added the mapcss to the PR. Does the icon have to be rectangular or square? Currently it is square just like the bicycle_rental icon I copied it from.

[gaben]

Sorry, square. I will use the excuse that I'm not a native speaker :)

[skyper]

Another option for tags below the minimal number is the external preset NewTags.

[mcliquid]

[PATCH] changed files

[mcliquid]

I've added the changed files here (same as on GitHub (​https://github.com/JOSM/josm/pull/134)) as I'm not able to commit them to SVN with my user.

[mcliquid]

Hello, as this is my first ticket with additions, I would just like to ask carefully what the next steps are without bothering anyone unnecessarily. I appreciate that everyone here is contributing voluntarily. But perhaps I have overlooked something very relevant that is still missing for a merge? Thank you very much!

[taylor.smock]

Just poke the ticket every two weeks if you don't see a response.

And if all else fails, cc me in the ticket.

Anyway, I'm targeting it for 24.02 instead of 24.01 since it is adding a translatable string; I could probably justify adding it now even so, but I prefer to give translators a chance to do the translation. And I'm intending to update the translations Friday, which isn't enough time to give translators for new/changed strings.

[skyper]

You could have added [Patch]to the ticket's summary to have it listed under Open tickets, with patches attached

[taylor.smock]

@mcliquid: There is an issue with the icon: it is only black. From wiki:DevelopersGuide/DefaultPresets:

Icons with transparent background must not be only black or only white. Otherwise if one uses a black or white background (no aerial imagery as background) in the Map View black or white icons would be invisible. Workaround: if you want to use a black icon add a square white background to the icon instead of a transparent background or better use a white halo.

I can add a background to the icon (a white background probably). Example:

[taylor.smock]

Add white background

[taylor.smock]

Ticket retargeted after milestone closed

[mcliquid]

@taylor.smock I've changed the icon and added the white background. ​https://github.com/JOSM/josm/pull/134/

Anything else missing?

[taylor.smock]

In 19026/josm:

Fix #23350: Add amenity=bicycle_wash as a preset (patch by mcliquid)

The proposal (​osmwiki:Proposal:Bicycle_Wash) was approved on 2023-12-18.