[Patch] Command stack shows "Set 1 tags for 0 objects"

[GerdP]

What steps will reproduce the problem?

1. in the tags/membership dialog, double click on a property of an object, e.g. natural=tree
2. click OK

What is the expected result?

nothing changes on the command stack since nothing was changed. I would also accept an entry "Set 0 tags for 1 object" which then allows to select the object.

What happens instead?

A new entry on the command stack "Set 1 tags for 0 objects" which doesn't seem to know the object that was not modified.

Please provide any additional information below. Attach a screenshot if possible.

I am often double checking the tags for guideposts which I've mapped recently since this is a very error prone task. So, my command stack is full of those useless entries.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-03-01 15:17:42 +0100 (Wed, 01 Mar 2023)
Revision:18678
Build-Date:2023-03-02 02:30:57
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18678 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19045)
Memory Usage: 1970 MB / 1972 MB (725 MB allocated, but free)
Java version: 17.0.4+8-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_DE
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18531, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\HWConsole.exe]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (35924)
+ RoadSigns (36038)
+ apache-commons (36034)
+ buildings_tools (36011)
+ contourmerge (v0.1.9)
+ ejml (35924)
+ geotools (36028)
+ jackson (36034)
+ jaxb (35952)
+ jts (36004)
+ o5m (35893)
+ opendata (36025)
+ pbf (36034)
+ poly (35976)
+ reltoolbox (35976)
+ reverter (36043)
+ undelete (36011)
+ utilsplugin2 (36011)

Validator rules:
+ c:\josm\core\resources\data\validator\combinations.mapcss
+ c:\josm\core\resources\data\validator\geometry.mapcss
+ c:\josm\core\resources\data\validator\unnecessary.mapcss
+ d:\java_tools\JOSM\mygeometry.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1

Last errors/warnings:
- 00000.633 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.635 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00001.086 E: java.security.KeyStoreException: Windows-ROOT not found. Cause: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available
- 73537.402 E: java.io.FileNotFoundException: F:\osm\bilder\2022-12-20\DSC_3010.JPG (Das System kann die angegebene Datei nicht finden)
- 73574.689 E: java.io.FileNotFoundException: F:\osm\bilder\2022-12-20\DSC_3010.JPG (Das System kann die angegebene Datei nicht finden)
- 73577.826 E: java.io.FileNotFoundException: F:\osm\bilder\2022-12-20\DSC_3010.JPG (Das System kann die angegebene Datei nicht finden)
- 79137.226 E: java.io.FileNotFoundException: F:\osm\bilder\2023-01-03\DSC_2771.JPG (Das System kann die angegebene Datei nicht finden)
- 105084.428 E: java.io.FileNotFoundException: F:\osm\bilder\2023-03-03\DSC_0456.JPG (Das System kann die angegebene Datei nicht finden)

[GerdP]

add check to avoid a no-change-command on the undo/redo stack

[GerdP]

The patch also works for the case that the key was double clicked and nothing was changed before clicking OK.
If I hear no complains I'll commit this tomorrow.

[GerdP]

In 19006/josm:

fix #22814: Command stack shows "Set 1 tags for 0 objects"

• add check to avoid a no-change-command on the undo/redo stack