Map layer is not dirty after processing OSC that adds one node

[b1tw153]

What steps will reproduce the problem?

1. Launch JOSM with remote control active
2. Go to this task on MapRoulette: ​https://maproulette.org/challenge/38422/task/154616490 (or almost any other task in this challenge)
3. Select "Edit in JOSM"
4. Click the edit button
5. Allow the OSC to load in JOSM
6. Notice that the Bear Spring node has been added to the map layer
7. Notice that the upload button is gray and cannot be selected

What is the expected result?

The upload button should be green and active.

What happens instead?

The upload button is gray and inactive.

Please provide any additional information below. Attach a screenshot if possible.

Revision:18678
Build-Date:2023-03-02 13:34:23

Identification: JOSM/1.5 (18678 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 2009 (19045)
Memory Usage: 316 MB / 8164 MB (106 MB allocated, but free)
Java version: 17.0.6+10-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00) \Display1 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18678, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]
Dataset consistency test: No problems found

Plugins:
+ apache-commons (36034)
+ ejml (35924)
+ geotools (36028)
+ jackson (36034)
+ jaxb (35952)
+ jts (36004)
+ opendata (36025)
+ utilsplugin2 (36011)

Last errors/warnings:
- 00000.468 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.470 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00003.467 E: java.security.KeyStoreException: Windows-ROOT not found. Cause: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available

[taylor.smock]

OK. It looks like it is probably an interaction from loading the OSC into the layer directly. Merging the OSC from a different layer worked as expected.

EDIT:
This has a really easy fix:

src/org/openstreetmap/josm/io/OsmChangeReader.java

@@ -92 +92 @@
                     parseUnknown();
                 }
                 if (p != null && action != null) {
-                    if ("modify".equals(action)) {
+                    if ("create".equals(action) || "modify".equals(action)) {
                         p.setModified(true);
                     } else if ("delete".equals(action)) {
                         p.setDeleted(true);

Now I just have to write a test for it.

EDIT2: I found a better place to fix the problem.

[taylor.smock]

In 18693/josm:

Fix #22811: Map layer is not dirty after processing OSC that adds one node

The setRequiresUploadToServer(isModified()) calls have been replaced to be
consistent with r13161 (see #13153).