Modify

Opened 16 months ago

Last modified 16 months ago

#22755 new defect

Inconsistent behavior of ∈ (building node part of building shape)

Reported by: Famlam Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: mapcss building inside Cc:

Description (last modified by skyper)

I spotted node 8793042989 where a (closed) building way contains a node with the same building tag, i.e. a node of the way equals the way itself.

Maybe it is interesting for JOSM to add the following rule to catch such cases?

way[building][building!=no]:closed > node[building][tag("building")==parent_tag("building")] {
  throwWarning: tr("{0} node part of {0} way", "{0.key}");
}

Attachments (1)

buildingnodeonbuildingway.osm (4.2 KB ) - added by Famlam 16 months ago.
OSM data showing an example

Download all attachments as: .zip

Change History (6)

by Famlam, 16 months ago

OSM data showing an example

comment:1 by taylor.smock, 16 months ago

This is partly caught by the building inside building check. See source:trunk/resources/data/validator/geometry.mapcss@18667:186-190#L186 .

Try adding building=shed to node 8793042988 and run the validator.

I think this might be a bug with . I'd have to check the docs though.

comment:2 by skyper, 16 months ago

Description: modified (diff)
Keywords: inside added

fix link

comment:3 by Famlam, 16 months ago

Type: enhancementdefect

The behavior is indeed very inconsistent. If its the first (equaling last) node of the closed building way, it is caught by the ∈-rule. All other nodes are not matched by this rule. It should be either all nodes match, or none. (The description in the docs, "contains", doesn't specify whether that includes the border way or only the content within the bordering way)

comment:4 by Famlam, 16 months ago

Summary: building node part of building shapeInconsistent behavior of ∈ (building node part of building shape)

comment:5 by skyper, 16 months ago

Component: Core validatorCore
Keywords: mapcss added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to Famlam.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.