Tagging presets: More flexible "preset_link"

[skyper]

• I would like to be able to place a link everywhere in the preset and not just at the bottom
• Additionally, I would like to change the text similar to <optional>

What steps will reproduce the problem?

1. Have a <preset_link preset_name="Tower" text="DESCRIPTION" inline="true" \> at the top of an <item>
2. Additional have a <preset_link preset_name="Address" \> at the bottom of the item

What is the expected result?

• A <label \> with text="DESCRIPTION" and link to "Tower" preset at top.
• The link to "Address" preset with default label at the bottom

What happens instead?

Both links at the bottom (text and inline fictional)

Please provide any additional information below. Attach a screenshot if possible.

I tried to work with it but failed. See screenshot and code below. Look at the label on top with missing link.

  <item name="Big Communication Tower" icon="presets/landmark/Communication_tower-14.svg" type="node,closedway,multipolygon" preset_name_label="true">
      <link wiki="Tag:man_made=communications_tower" />
      <space />
      <label text="Big communication tower, usually over 100 meters high." />
      <label text="Use Tower for smaller ones:" />
      <preset_link preset_name="Tower" />
      <space />
      <key key="man_made" value="communications_tower" />
      <multiselect key="tower:type" text="Type of tower" values_sort="false" default="communication" rows="3">
          <list_entry value="communication" display_value="Communication tower" icon="presets/landmark/Tower_cantilever_communication.svg" />
          <list_entry value="watchtower" display_value="Watch tower" icon="presets/landmark/Tower_observation.svg" />
      </multiselect>
      <reference ref="tower_construct" />
      <reference ref="optional_public_building" />
      <preset_link preset_name="Contact (Common Schema)" />
      <preset_link preset_name="Address" />
  </item> <!-- Big Communication Tower -->

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-03-31 20:51:44 +0200 (Tue, 31 Mar 2020)
Revision:16222
Build-Date:2020-04-01 01:30:45
URL:https://josm.openstreetmap.de/svn/trunk

[skyper]

screenshot of broken preset

[simon04]

In 16280/josm:

fix #19022 - PresetLink: allow to customize label text and UI position

[simon04]

        <item name="Hotel" icon="presets/accommodation/hotel.svg" type="node,closedway,multipolygon" preset_name_label="true">
            <link wiki="Tag:tourism=hotel" />
            <space />
            <key key="tourism" value="hotel" />
            <reference ref="name_operator" />
            <combo key="stars" text="Stars" values="1,2,3,4,5,6,7" />
            <preset_link text="Add this..." preset_name="Contact (Common Schema)" />
            <preset_link text="...and this..." preset_name="Address" />
            <preset_link text="...and this..." preset_name="Payment Methods" />
            <text key="rooms" text="Rooms" />
            <text key="beds" text="Beds" />
            <reference ref="wheelchair" />
            <space />
            <reference ref="internet_smoking" />
            <space />
            <preset_link preset_name="Residential Building" />
        </item>

… yields …

[stoecker]

If you add new features you also need to update the documentation for these: wiki:TaggingPresets.

[simon04]

TaggingPresets?action=diff&version=168

[skyper]

Replying to simon04:

TaggingPresets?action=diff&version=168

I've added little more detail:
TaggingPresets?&action=diff&version=169

[simon04]

[o35422] - I18n: PresetLink: allow to customize label text

[Klumbumbus]

Milestone renamed