Changeset 19050 in josm for trunk/test/unit/org/openstreetmap/josm/actions/UploadActionTest.java

Timestamp:

2024-04-22T20:59:26+02:00 (4 weeks ago)

Author:

taylor.smock

Message:

Revert most var changes from r19048, fix most new compile warnings and checkstyle issues

Also, document why various ErrorProne checks were originally disabled and fix
generic SonarLint issues.

File:

• trunk/test/unit/org/openstreetmap/josm/actions/UploadActionTest.java (modified) (2 diffs)

trunk/test/unit/org/openstreetmap/josm/actions/UploadActionTest.java

@@ -85 +85 @@
     }
 
-    private static class UploadDialogMock extends MockUp<UploadDialog> {
+    private static final class UploadDialogMock extends MockUp<UploadDialog> {
         @Mock
         public void pack(final Invocation invocation) {
@@ -101 +101 @@
 
         @Mock
-        public final boolean isCanceled(final Invocation invocation) {
+        public boolean isCanceled(final Invocation invocation) {
             if (!GraphicsEnvironment.isHeadless()) {
                 return Boolean.TRUE.equals(invocation.proceed());