Changeset 19050 in josm for trunk/src/org/openstreetmap/josm/plugins/Plugin.java

Timestamp:

2024-04-22T20:59:26+02:00 (6 weeks ago)

Author:

taylor.smock

Message:

Revert most var changes from r19048, fix most new compile warnings and checkstyle issues

Also, document why various ErrorProne checks were originally disabled and fix
generic SonarLint issues.

File:

• trunk/src/org/openstreetmap/josm/plugins/Plugin.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/plugins/Plugin.java

@@ -24 +24 @@
  * For all purposes of loading dynamic resources, the Plugin's class loader should be used
  * (or else, the plugin jar will not be within the class path).
- *
+ * <p>
  * A plugin may subclass this abstract base class (but it is optional).
- *
+ * <p>
  * The actual implementation of this class is optional, as all functions will be called
  * via reflection. This is to be able to change this interface without the need of
@@ -32 +32 @@
  * function here (or does provide a function with a mismatching signature), it will not
  * be called. That simple.
- *
+ * <p>
  * Or in other words: See this base class as an documentation of what automatic callbacks
  * are provided (you can register yourself to more callbacks in your plugin class
  * constructor).
- *
+ * <p>
  * Subclassing Plugin and overriding some functions makes it easy for you to keep sync
  * with the correct actual plugin architecture of JOSM.
@@ -47 +47 @@
      * This is the info available for this plugin. You can access this from your
      * constructor.
-     *
+     * <p>
      * (The actual implementation to request the info from a static variable
      * is a bit hacky, but it works).
@@ -55 +55 @@
     private final IBaseDirectories pluginBaseDirectories = new PluginBaseDirectories();
 
-    private class PluginBaseDirectories implements IBaseDirectories {
+    private final class PluginBaseDirectories implements IBaseDirectories {
         private File preferencesDir;
         private File cacheDir;