Modify

Opened 13 years ago

Closed 13 years ago

#6907 closed defect (fixed)

[Patch needs rework] Error reading audio files from case sensitive filesystem

Reported by: mdk Owned by: OliverW
Priority: normal Milestone:
Component: Plugin columbuscsv Version: latest
Keywords: Cc: dk31519

Description (last modified by mdk)

When I read a Columbus CSV file from the SD-card (formatted with FAT16) I also get the audio files. But when I try to read them from my disk archive (ext4), I did't get the files. Instead there are errors like:

Open file: /home/michael/src/osm/ColumbusData/11092800.CSV (114175 bytes)
File vox00043 not found!
Fehlende Audiodatei: vox00043

The problem is, that ext4 is case sensitive and the files are named

VOX00043.WAV

and not

vox00043.wav

The reason for this is in ColumbusCSVReader.java line 366

if (isExtMode) {

voxFile = csvLine[14].toLowerCase();

} else {

voxFile = csvLine[9].toLowerCase();

}

Why is there a ".toLowerCase()"?

Attachments (1)

patch_6907.diff (1.1 KB ) - added by mdk 13 years ago.
Final patch for this bug.

Download all attachments as: .zip

Change History (12)

comment:1 by anonymous, 13 years ago

Ticket #6908 has been marked as a duplicate of this ticket.

comment:2 by skyper, 13 years ago

Ticket #5227 has been marked as a duplicate of this ticket.

comment:3 by skyper, 13 years ago

Cc: dk31519 added

comment:4 by OliverW, 13 years ago

Fixed in 26819.

comment:5 by OliverW, 13 years ago

Resolution: fixed
Status: newclosed

by mdk, 13 years ago

Attachment: patch_6907.diff added

Final patch for this bug.

comment:6 by mdk, 13 years ago

Description: modified (diff)
Resolution: fixed
Status: closedreopened
Summary: Error reading audio files from case sensitive filesystem[Patch] Error reading audio files from case sensitive filesystem

You are on the right way by checking different cases for the filename, but you add always ".wav" in lover case.

comment:7 by bastiK, 13 years ago

for reference: see [o26819] and [o26828].

comment:8 by bastiK, 13 years ago

@mdk: Please update your patch, it doesn't apply.

Could you attach a sample columbus csv file that we can keep in the repository for testing?

comment:9 by bastiK, 13 years ago

Summary: [Patch] Error reading audio files from case sensitive filesystem[Patch need rework] Error reading audio files from case sensitive filesystem

comment:10 by bastiK, 13 years ago

Summary: [Patch need rework] Error reading audio files from case sensitive filesystem[Patch needs rework] Error reading audio files from case sensitive filesystem

comment:11 by OliverW, 13 years ago

Resolution: fixed
Status: reopenedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain OliverW.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.