Opened 13 years ago
Closed 12 years ago
#6562 closed enhancement (fixed)
loading of default imagery sources sometimes fails
Reported by: | bastiK | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core | Version: | |
Keywords: | imagery | Cc: |
Description (last modified by )
[4198] broke the loading of default imagery sources:
Index: trunk/src/org/openstreetmap/josm/gui/preferences/ImageryPreference.java =================================================================== --- a/trunk/src/org/openstreetmap/josm/gui/preferences/ImageryPreference.java +++ b/trunk/src/org/openstreetmap/josm/gui/preferences/ImageryPreference.java @@ -836,6 +836,6 @@ public static void initialize() { + ImageryLayerInfo.instance.loadDefaults(false); ImageryLayerInfo.instance.load(); - ImageryLayerInfo.instance.loadDefaults(false); OffsetBookmark.loadBookmarks(); Main.main.menu.imageryMenu.refreshImageryMenu();
In combination with
public void load() { layers.clear();
this discards the layers added in loadDefaults(false).
Attachments (0)
Change History (8)
comment:1 by , 13 years ago
comment:3 by , 13 years ago
Your patch kills the attribution copy function, as this need the defaults to be loaded before the defined entries. Can't you simply move the clear() to initialize where it belongs?
comment:4 by , 13 years ago
Sorry, ignore last comment. Need to wake up first before I can read patches :-)
comment:5 by , 13 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:6 by , 13 years ago
I still have this issue from time to time due to bad connections. Strange the connection is much better with ssl than without !
Once the default list is not downloaded on your first run of JOSM and the connections fails the list will stay empty until user manually adds servers.
Would be nice if JOSM would add the default list if the list is empty (with an option to leave it empty if intended ?).
Thanks.
comment:7 by , 13 years ago
Priority: | critical → normal |
---|---|
Resolution: | fixed |
Status: | closed → reopened |
Summary: | loading of default imagery sources broken in current release → loading of default imagery sources sometimes fails |
Type: | defect → enhancement |
comment:8 by , 12 years ago
Description: | modified (diff) |
---|---|
Resolution: | → fixed |
Status: | reopened → closed |
Did not happen for a long time
In [4216/josm]: