Opened 14 years ago
Last modified 10 years ago
#6363 closed defect
Color Style cause Validator Warning (Style for inner way equals multipolygon) — at Version 10
Reported by: | SunCobalt | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 15.02 |
Component: | Core validator | Version: | |
Keywords: | Cc: | Mkyral |
Description (last modified by )
create a MP with outer and inner ways that get the same color in JOSM. Use, for example, landuse=farmland as outer and landuse=vineyard (meadown does the same) as inner. It will produce a "Style for inner way equals multipolygon" warning.
Change History (10)
comment:1 by , 14 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
comment:2 by , 14 years ago
the suggestion "You can simply fix this by applying the outer style to the relation instead, as is recommended." wasn't helpful. I did it as suggested (landuse= tag to relation) but got the wrong warning. Please try relation: http://www.openstreetmap.org/browse/relation/1592325
The wrong warning only come up for inner areas, which are visualised by the same color in JOSM. So having a MP-relation with landuse=farmland (tag in the relation) and an inner polygon with landuse=vineyard, I am getting this warning. If I have an inner polygon that is visualised in a different color like landuse=farmyard, no warning is displayed.
comment:3 by , 14 years ago
Resolution: | wontfix |
---|---|
Status: | closed → reopened |
follow-up: 5 comment:4 by , 14 years ago
Yes, right. Maybe we should degrade that warning to info level in case the style is applied to the multipolygon.
follow-up: 7 comment:5 by , 14 years ago
Replying to stoecker:
Yes, right. Maybe we should degrade that warning to info level in case the style is applied to the multipolygon.
No, there is definitively a problem in code as it does not work only with some combinations but works with others.
comment:6 by , 14 years ago
As it says: "Style for inner way equals multipolygon". It does not say tags or whatever, but style. When two styles are equal, JOSM can't distinguish them any more. When all areas are drawn alike, then this will always issue a warning.
comment:7 by , 14 years ago
comment:9 by , 13 years ago
The check "style for inner way equals multipolygon" still does not appear to take differences in tagging of the multipolygon and its inner members into account at all when issuing a warning. This leads to incorrect warnings where the colors JOSM uses for the two features happen to be identical.
I've observed some more combinations where this happens:
- amenity=school and amenity=parking
- leisure=track and leisure=pitch, even with different sport and surface tags
When switching from "internal style" to "Potlatch 2 style", these validator warnings disappear. It does not make a difference whether the tags for the multipolygon are on the relation or the outer way.
IMO this validator feature should either check for identical tags instead of identical rendering style, or be downgraded to info.
comment:10 by , 12 years ago
Description: | modified (diff) |
---|---|
Reporter: | changed from | to
You can simply fix this by applying the outer style to the relation instead, as is recommended.