Error when trying to upload

[webmaster@…]

What steps will reproduce the problem?

1. Load in a dataset that spans a bigger area than can be downloaded at once
2. Download highway=* for a given are with overpass
3. Do some edits to the dataset
4. upload those edits
5. Wait 24 hours
6. Do some more edits
7. Try to upload those edits

What is the expected result?

Data is validated and then uploaded.

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2024-04-09 18:11:42 +0200 (Tue, 09 Apr 2024)
Revision:19039
Build-Date:2024-04-10 01:31:01
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (19039 en) Linux Fedora Linux 40 (KDE Plasma)
Memory Usage: 2100 MB / 7936 MB (407 MB allocated, but free)
Java version: 21.0.1+12-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.gtk.GTKLookAndFeel
Screen: :0.0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_CA.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_CA
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: KDE
VM arguments: [-Dicedtea-web.bin.location=/opt/OpenWebStart/javaws, -Djava.util.Arrays.useLegacyMergeSort=true, --add-exports=jdk.deploy/com.sun.deploy.config=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-reads=java.naming=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.action=ALL-UNNAMED,java.desktop, --add-reads=java.base=ALL-UNNAMED,java.desktop, --add-exports=java.naming/com.sun.jndi.toolkit.url=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/sun.awt=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-exports=java.base/sun.security.validator=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.base/sun.net.www.protocol.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/jdk.internal.util.jar=ALL-UNNAMED,java.desktop, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, --add-exports=java.base/com.sun.net.ssl.internal.ssl=ALL-UNNAMED,java.desktop, --add-exports=javafx.graphics/com.sun.javafx.application=ALL-UNNAMED, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.desktop/sun.awt.X11=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,java.desktop,jdk.jsobject, --add-exports=java.base/sun.net.www.protocol.http=ALL-UNNAMED,java.desktop, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-exports=java.base/sun.security.util=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-reads=java.desktop=ALL-UNNAMED,java.naming, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-exports=java.base/sun.security.x509=ALL-UNNAMED,java.desktop, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-exports=java.desktop/javax.jnlp=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.provider=ALL-UNNAMED,java.desktop, -Djava.security.manager=allow]
Dataset consistency test: No problems found

Plugins:
+ AddrInterpolation (36226)
+ DirectDownload (36178)
+ DirectUpload (36178)
+ HouseNumberTaggingTool (36226)
+ ImproveOsm (247)
+ RoadSigns (36226)
+ apache-commons (36176)
+ areaselector (2.6.2)
+ austriaaddresshelper (88)
+ conflation (0.6.11)
+ continuosDownload (103)
+ ejml (36176)
+ geotools (36176)
+ gridify (1606242219)
+ imagery_offset_db (36226)
+ jackson (36176)
+ jaxb (36118)
+ jts (36004)
+ log4j (36241)
+ opendata (36200)
+ openqa (v0.3.3)
+ pt_assistant (632)
+ public_transport (36200)
+ reverter (36241)
+ routing (36226)
+ tageditor (36200)
+ turnlanes (36206)
+ turnlanes-tagging (0.0.5)
+ turnrestrictions (36226)
+ utilsplugin2 (36241)
+ wikipedia (605)

Tagging presets:
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/CA.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/Telecom&zip=1
+ https://raw.githubusercontent.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/TurnLanes&zip=1
+ https://www.openrailwaymap.org/josm-presets/de.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/NationalGeodeticSurveyMark&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/PublicTransportGtfs&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
+ https://www.openrailwaymap.org/styles/josm-additional.zip
- https://www.openrailwaymap.org/styles/electrified.zip
+ https://www.openrailwaymap.org/styles/standard.zip
- https://www.openrailwaymap.org/styles/signals.zip
- https://www.openrailwaymap.org/styles/maxspeed.zip
+ https://josm.openstreetmap.de/josmfile?page=Styles/Power&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SidewalksAndFootways&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
+ https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss

Last errors/warnings:
- 65024.391 E: Failed to locate image 'images/bus forward.png'
- 65027.411 E: Failed to locate image 'images/bus forward.png'
- 65027.412 E: Failed to locate image 'images/bus forward.png'
- 65027.413 E: Failed to locate image 'images/bus forward.png'
- 65305.332 E: Failed to locate image 'images/bus forward.png'
- 66770.884 E: Failed to locate image 'images/bus forward.png'
- 68681.437 W: Conflict in data - <html>This relation has been changed outside of the editor.<br>You cannot apply your changes and continue editing.<br><br>Do you want to create a conflict and close the editor?</html>
- 69125.128 E: Handled by bug report queue: java.lang.IllegalArgumentException: Cannot download new primitives (ID -11,906)
- 69333.483 E: Error header: The way with the id 1274750039 has already been deleted
- 69333.584 W: Way '‎service (highway)‎ (0 nodes)‌' is already deleted. Skipping object in upload.



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-1 (46) of JOSM
java.lang.IllegalArgumentException: Cannot download new primitives (ID -11,906)
	at org.openstreetmap.josm.gui.io.DownloadPrimitivesWithReferrersTask.<init>(DownloadPrimitivesWithReferrersTask.java:86)
	at org.openstreetmap.josm.plugins.pt_assistant.actions.IncompleteMembersDownloadRunnable.run(IncompleteMembersDownloadRunnable.java:79)
	at org.openstreetmap.josm.plugins.pt_assistant.validation.PTAssistantValidatorTest.downloadIncompleteMembers(PTAssistantValidatorTest.java:210)
	at org.openstreetmap.josm.plugins.pt_assistant.validation.PTAssistantValidatorTest.visit(PTAssistantValidatorTest.java:124)
	at org.openstreetmap.josm.data.osm.Relation.accept(Relation.java:176)
	at org.openstreetmap.josm.data.validation.Test.visit(Test.java:218)
	at org.openstreetmap.josm.data.validation.ValidationTask.realRun(ValidationTask.java:192)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.doRealRun(PleaseWaitRunnable.java:94)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.java:142)
	at org.openstreetmap.josm.actions.upload.ValidateUploadHook.checkUpload(ValidateUploadHook.java:60)
	at org.openstreetmap.josm.actions.UploadAction.lambda$checkPreUploadConditionsAsync$0(UploadAction.java:252)
	at java.base/java.util.stream.MatchOps$1MatchSink.accept(MatchOps.java:90)
	at java.base/java.util.LinkedList$LLSpliterator.tryAdvance(LinkedList.java:1263)
	at java.base/java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:129)
	at java.base/java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:527)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:513)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.MatchOps$MatchOp.evaluateSequential(MatchOps.java:230)
	at java.base/java.util.stream.MatchOps$MatchOp.evaluateSequential(MatchOps.java:196)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.allMatch(ReferencePipeline.java:637)
	at org.openstreetmap.josm.actions.UploadAction.lambda$checkPreUploadConditionsAsync$1(UploadAction.java:252)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)

[GerdP]

I've opened an issue on github: ​https://github.com/JOSM/pt_assistant/issues/65

[skyper]

Replying to webmaster@…:

4. upload those edits
5. Wait 24 hours
6. Do some more edits
7. Try to upload those edits

After 24 hours it is advisable to Update Data prior to continuing editing. Otherwise you might run into conflicts later on as you did:

Last errors/warnings:
- 68681.437 W: Conflict in data - <html>This relation has been changed outside of the editor.<br>You cannot apply your changes and continue editing.<br><br>Do you want to create a conflict and close the editor?</html>
- 69125.128 E: Handled by bug report queue: java.lang.IllegalArgumentException: Cannot download new primitives (ID -11,906)
- 69333.483 E: Error header: The way with the id 1274750039 has already been deleted
- 69333.584 W: Way '‎service (highway)‎ (0 nodes)‌' is already deleted. Skipping object in upload.

I am not sure if this is a problem with the pt_assistant plugin, JOSM core or even the user's workflow.
Note, we have some reports that JOSM does fail to properly update the data layer after a successful upload. And for sure it does not upload any changes which are only in the relation editor but not yet saved to the data layer, see #10032.

[GerdP]

My understanding of the traceback is that the plugin tries to download members for a relation with a negative id. This will never work.
Edit: Or maybe it tries to download parents of members with a negative id. Something like that.

[webmaster@…]

I did do partial uploads of the data by using the "Upload Selection" function, so that may be why it is complaining about negative id.

The data I imported into JOSM had negative ids and i was working through the data in order to import into OSM

[floscher]

I've reworked that download task now, it should be fixed with the next release.
​https://github.com/JOSM/pt_assistant/commit/698e43effe3616704befc45f8966d80944ff0ae9