Changes between Initial Version and Version 1 of Ticket #22940


Ignore:
Timestamp:
2023-05-10T16:09:46+02:00 (19 months ago)
Author:
taylor.smock
Comment:

We'd probably want to do something like this:

node[type=multipolygon] {
    throwError: tr("{0} on a node. Should be used in a relation", "{0.tag}");
    fixRemove: "type";
}

way!:closed[type=multipolygon],
way:area-style[type=multipolygon] {
    throwError: tr("{0} on a way. Should be used in a relation", "{0.tag}"); 
    fixRemove: "type";
}
way[type=multipolygon]:

Anyway, looking at taginfo:tags/type=multipolygon, it seems to be a very rare occurrence. If there are tools causing this to happen, we should fix those, since I don't think people are intentionally adding type=multipolygon to node/way objects.

And the current issues can be dealt with via a MapRoulette task.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #22940 – Description

    initial v1  
    11==== What steps will reproduce the problem?
    2 1. create a node with natural=tree type=multipolygon
    3 2. create a way with landuse=residential type=multipolygon
     21. create a node with `natural=tree` `type=multipolygon`
     32. create a way with `landuse=residential` `type=multipolygon`
    443. run the validator
    55
     
    1313
    1414==== proposed enhancement
     15{{{#!mapcss
    1516node[type=multipolygon] {
    1617    throwError: tr("{0} on a node. Should be used in a relation", "{0.tag}");
     
    2728    fixRemove: "type";
    2829}
     30}}}
    2931
    30 I didn't combine both way with way[type=multipolygon] because some wrong usage of way[type=multipolygon] mean area=yes (for ex when converting a relation type=multipolygon highway=pedestrian into a closed way)
     32I didn't combine both `way` with `way[type=multipolygon]` because some wrong usage of `way[type=multipolygon]` mean `area=yes` (for ex when converting a relation `type=multipolygon` `highway=pedestrian` into a closed way)
    3133
    3234==== Please provide any additional information below. Attach a screenshot if possible.
     
    5658WebStart package: icedtea-web:x86_64-1.7.1
    5759VM arguments: [-Dicedtea-web.bin.name=javaws.itweb, -Dicedtea-web.bin.location=/usr/bin/javaws.itweb]
    58 Dataset consistency test: No problems found
    59 
    60 Plugins:
    61 + ImproveOsm (238)
    62 + MapRoulette
    63 + apache-commons (36034)
    64 + apache-http (35924)
    65 + areaselector
    66 + austriaaddresshelper (master-4e80dc2e4261d321150187f4951684ad97342d5e)
    67 + cadastre-fr (36079)
    68 + conflation (0.6.11)
    69 + continuosDownload (105)
    70 + ejml (35924)
    71 + geotools (36068)
    72 + jackson (36034)
    73 + jaxb (35952)
    74 + jna (36005)
    75 + jts (36004)
    76 + log4j (36045)
    77 + mapwithai (794)
    78 + notesolver (0.5.0)
    79 + opendata (36079)
    80 + pt_assistant (2.1.15-19-g9aeec3c-SNAPSHOT)
    81 + reverter (36066)
    82 + scripting
    83 + todo (123)
    84 + utilsplugin2 (36079)
    85 + wikipedia (605)
    86 
    87 Tagging presets:
    88 + https://josm.openstreetmap.de/josmfile?page=Presets/Leaftype&zip=1
    89 + https://josm.openstreetmap.de/josmfile?page=Presets/Light_sources&zip=1
    90 + https://raw.github<user.name>content.com/Heiner-Sch/JOSM-preset-trees-Europe/master/JOSM-Preset_Trees.xml
    91 + https://josm.openstreetmap.de/josmfile?page=Presets/BENELUX&zip=1
    92 + https://josm.openstreetmap.de/josmfile?page=Presets/MountainbikeTrails&zip=1
    93 + https://josm.openstreetmap.de/josmfile?page=Presets/contact(socialnetworks_IMs)&zip=1
    94 + https://josm.openstreetmap.de/josmfile?page=Presets/geoimage.at&zip=1
    95 + https://github.com/Jungle-Bus/josm-presets/raw/gh-pages/jungle-stops/Preset_Jungle-Bus.zip
    96 + https://josm.openstreetmap.de/josmfile?page=Presets/MobilePhoneBaseStations&zip=1
    97 + https://raw.github<user.name>content.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml
    98 + https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
    99 + https://raw.github<user.name>content.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.xml
    100 + https://osmtools.de/josm/steps.xml
    101 + https://josm.openstreetmap.de/josmfile?page=Presets/Trees&zip=1
    102 + https://josm.openstreetmap.de/josmfile?page=Presets/WifiHotspots&zip=1
    103 + https://josm.openstreetmap.de/josmfile?page=Presets/Wikidata&zip=1
    104 + https://raw.github<user.name>content.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml
    105 
    106 Map paint styles:
    107 + https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
    108 + https://josm.openstreetmap.de/josmfile?page=Styles/Landcover&zip=1
    109 + https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
    110 
    111 Validator rules:
    112 + https://github.com/Jungle-Bus/transport_mapcss/raw/gh-pages/transport.validator.zip
    113 + https://josm.openstreetmap.de/josmfile?page=Rules/KeepRight&zip=1
    114 + https://josm.openstreetmap.de/josmfile?page=Rules/FranceSpecificRules&zip=1
    115 + https://josm.openstreetmap.de/josmfile?page=Rules/SuspiciousSwimming_Pool&zip=1
    116 + https://josm.openstreetmap.de/josmfile?page=Rules/SourceObjectTag&zip=1
    117 + https://josm.openstreetmap.de/josmfile?page=Rules/QAToolInspiredValidations&zip=1
    118 + https://josm.openstreetmap.de/josmfile?page=Rules/IndoorRules&zip=1
    119 + https://josm.openstreetmap.de/josmfile?page=Rules/MissingOpeningHours&zip=1
    120 + https://raw.github<user.name>content.com/stefan-a-bauer/josm-validators/master/mtb.validator.mapcss
    121 + https://www.openrailwaymap.org/validator/openrailwaymap.validator.mapcss
    122 + https://josm.openstreetmap.de/josmfile?page=Rules/OSMLint&zip=1
    123 + https://josm.openstreetmap.de/josmfile?page=Rules/Pictures&zip=1
    124 + https://josm.openstreetmap.de/josmfile?page=Rules/MissingWeekdays&zip=1
    125 + https://raw.github<user.name>content.com/osmlu/josm-validator-luxembourg/master/Luxembourg-Specific-Rules.validator.mapcss
    126 + https://raw.github<user.name>content.com/OpenNauticalChart/josm/master/Seamark.validator.mapcss
    127 + https://josm.openstreetmap.de/josmfile?page=Rules/OsmoseValidations&zip=1
    128 + <josm.pref>/validator/osmose.zip
    129 + https://josm.openstreetmap.de/josmfile?page=Rules/FacebookWebsite&zip=1
    130 + https://josm.openstreetmap.de/josmfile?page=Rules/InvalidWebsiteProtocol&zip=1
    131 + https://josm.openstreetmap.de/josmfile?page=Rules/PublicTransportGtfs&zip=1
    132 + https://josm.openstreetmap.de/josmfile?page=Rules/ValidatingBuildingsInHOTTMProjects&zip=1
    133 + <josm.pref>/validator/Rules_Marcmarc.addon.validator.mapcss
    134 + <josm.pref>/validator/Rules_Marcmarc.depreciated-parking.validator.mapcss
    135 + <josm.pref>/validator/Rules_Marcmarc.depreciated.validator.mapcss
    136 + <josm.pref>/validator/Rules_Marcmarc.error.validator.mapcss
    137 + <josm.pref>/validator/Rules_Marcmarc.useless.validator.mapcss
    138 + <josm.pref>/validator/Rules_Marcmarc.depreciated-wooded.validator.mapcss
    139 
    140 Last errors/warnings:
    14160}}}