Changes between Initial Version and Version 7 of Ticket #21778


Ignore:
Timestamp:
2023-02-28T22:32:37+01:00 (2 years ago)
Author:
Famlam
Comment:

Thank you taylor.smock! Unfortunately my PR only fixed the second issue listed, not the first. The Java-test still needs to be updated to include dismount. Hence I re-opened this issue. (Not sure if I should remove the milestone as the other issues about the java test have no milestone)

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #21778

    • Property Summary Validation error: oneway + oneway:conditional + bicycle:backwards:conditional → [patch][github patch] Validation error: oneway + oneway:conditional + bicycle:backwards:conditional
    • Property Status new → reopened
    • Property Milestone → 23.02

  • Ticket #21778 – Description

    initial v7  
    88Two validation errors
    991. `dismount` is not recognized as a valid access tag (I know this road, it literally says cyclists should dismount - in Dutch of course, when going downhill) [https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/data/validation/tests/ConditionalKeys.java#L31 by this test]
    10 2. It complains about `bicycle:backward:conditional=dismount @ destination` together with `oneway=yes` (from [https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/combinations.mapcss#L294 here]) without taking into account `oneway:conditional`
     102. EDIT: Fixed by r18674 (was: It complains about `bicycle:backward:conditional=dismount @ destination` together with `oneway=yes` (from [https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/combinations.mapcss#L294 here]) without taking into account `oneway:conditional`. )
    1111
    1212==== Please provide any additional information below. Attach a screenshot if possible.
    1313Suggested fixes:
    14141. add `dismount` to [https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/data/validation/tests/ConditionalKeys.java#L31 this array]: `RESTRICTION_VALUES`
    15 2. add `[!oneway:conditional]` to https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/combinations.mapcss lines 294-297
     152. EDIT: Fixed by r18674 (was: add `[!oneway:conditional]` to https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/combinations.mapcss lines 294-297 )
    1616
    1717{{{