Modify

Opened 16 years ago

Closed 15 years ago

#2156 closed defect (fixed)

Can't open the preferences under Mac OS X

Reported by: lempp@… Owned by: framm
Priority: minor Milestone:
Component: Core Version: latest
Keywords: Cc:

Description

Under Mac OS X you can't open the preferences window. There's neither a button in the toolbar nor a menu item nor does F12 work. Just look at the attached screenshots.
Affects latest and tested. Deleting the preferences file does not help.

Everything's fine under WinXP though.
Everything was fine under Mac OS a few versions ago. (like mid January)

Attachments (4)

Bild 1.png (8.8 KB ) - added by lempp@… 16 years ago.
Screenshot 1of2
Bild 2.png (12.7 KB ) - added by lempp@… 16 years ago.
Screenshot 2of2
Bild 1.2.png (49.1 KB ) - added by lempp@… 16 years ago.
Screenshot #3
macmenuworks.png (126.0 KB ) - added by jahve@… 16 years ago.
Mac menu works but application title isn't userfriendly

Download all attachments as: .zip

Change History (28)

by lempp@…, 16 years ago

Attachment: Bild 1.png added

Screenshot 1of2

by lempp@…, 16 years ago

Attachment: Bild 2.png added

Screenshot 2of2

comment:1 by anonymous, 16 years ago

Could you try older version from Download and find the last version which works for you?

I don't remember any changes regarding the prefs dialog which could cause such differences.

comment:2 by anonymous, 16 years ago

v1348 works, v1359 and newer have the defect. I can't test the versions between these two because I don't find them in http://josm.openstreetmap.de/download/

comment:3 by anonymous, 16 years ago

Hmpf. There have been no changes inbetween, which could explain that behaviour. Could you please delete all plugins in plugin-directory and redownload them.

If this does not work please attach your preferences file (strip your password/username) as zipped file.

comment:4 by xeen, 16 years ago

Have a look at http://mathphys.fsk.uni-heidelberg.de/~stefan/josm/ I uploaded the missing revisions there. Could you please check after which version it exactly fails because this will really simplify finding the issue! Note that the version won't be visible from within JOSM as I haven't setup version control correctly, so it displays "UNKNOWN".

comment:5 by anonymous, 16 years ago

1348 … OK
1349 … buggy
1350 … buggy
1351 … buggy
1352 … buggy
1353 … buggy
1354 … buggy
1355 … buggy
1356 … buggy
1357 … buggy
1358 … buggy

comment:6 by anonymous, 16 years ago

There is nothing between 1348 and 1349. This must be a side effect of something else. Does Apple have another system standard method to invoke preferences? Does this work? Probably this is somehow related to the OSX-Plattform hook.

To me it seems that hook does not allow to add a preferences menu and F12 is also registered as system hotkey.

The recent changes to toolbar also prevent a toolbar entry (but this should also be already in version 1348).

comment:7 by FourOhFour, 16 years ago

Looks like the OS is moving the preferences item to the Mac menubar. Either select it there or use command-comma.

comment:8 by anonymous, 16 years ago

No, that was possible before.

comment:9 by xeen, 16 years ago

Hm, that 1348 works but 1349 doesn't… here's a quick test, I don't know what I'm actually doing but maybe it works (this is really the only line changed in between these versions that remotely could cause this).

http://mathphys.fsk.uni-heidelberg.de/~stefan/josm/josm-custom.jar

This version contains a lot of other patches from my tree, so other stuff may not work, I'm just curious if it the prefs can be opened again.

comment:10 by lempp@…, 16 years ago

yeah xeen, that's the stuff. The toolbar button's there!

Also thanks for that workaround, FourOhFour.

But: The preferences entry in the edit menu is still missing (even in xeen's josm-custom) which made me do some research: That entry was last seen in josm-1014. 1030 has the defect. I'm afraid there's a big gap in the download archive, so I can't be more precise.

Also the info entry in the help menu was last seen in josm-1212. Mind the gap!
But the info window is still reachable as shown in screenshot #3.

by lempp@…, 16 years ago

Attachment: Bild 1.2.png added

Screenshot #3

comment:11 by xeen, 16 years ago

I'll see what I can dig up about the toolbar button tomorrow as I have no idea what I actually did. If anyone knows more than me: I just re-added line 427 in ToolbarPreferences.java (see http://josm.openstreetmap.de/changeset/1349) without removing the line below.

I'll provide the missing JOSM versions tomorrow to see when the menu item disappeared, maybe that helps understanding the issue. Lempp, do you have some kind of instant messenger installed, as a >direct connection< will make finding the issue much easier and faster.

comment:12 by lempp@…, 16 years ago

just e-mail me

comment:13 by anonymous, 16 years ago

In r1393 I added a patch which should get the toolbar value back. The menu-issue is something else, as this is part of the MacOS integration and "by design".

Does the fix solve your problem?

comment:14 by lempp@…, 16 years ago

Thank you, my anonymous helper. That fix solved my problem. (at least the one with the toolbar button)

comment:15 by anonymous, 16 years ago

I have tried r1394, but the bug is still there.

comment:16 by anonymous, 16 years ago

Well as said the problem with missing menu is something else. This is based on the MacOS integration. We can change that but I'm sure it is by-design. And I myself don't have a Mac so I cannot really decide what to do.

What I did is to reenable the Toolbar settings entry.

comment:17 by anonymous, 16 years ago

Resolution: fixed
Status: newclosed

comment:18 by anonymous, 16 years ago

Resolution: fixed
Status: closedreopened

Hmmpf, don't know why the menu entries does not appear under OSX. Seems this is a bug.

comment:19 by smsm1, 16 years ago

I don't have a problem with the preferences on Mac OS X. They are just done the Mac way.

in reply to:  18 comment:20 by jahve@…, 16 years ago

Replying to anonymous:

Hmmpf, don't know why the menu entries does not appear under OSX. Seems this is a bug.

The Mac-type menubar should show up when setting Look and feel to "Mac OS X" in preferences. At least it works for me using latest stable version, 1566.

However, the application title bug mentioned in #1589 is still around.

by jahve@…, 16 years ago

Attachment: macmenuworks.png added

Mac menu works but application title isn't userfriendly

comment:21 by anonymous, 16 years ago

Application title was working before, so this is a regression.

(Hint: OSX always displays the name of the main class there if you start a .jar directly. So at some time last year a "dummy" main class named "josm" was created. Did someone change it back to the fully pathed class?)

comment:22 by anonymous, 16 years ago

Priority: criticalminor

PS: I just checked teh source. The build.xml still correctly says '<attribute name="Main-class" value="JOSM" />', but the MANIFEST.MF says 'Main-class: org.openstreetmap.josm.gui.MainApplication' --- and that's wrong.

What tool chain is used to create the josm-latest.jar? It seems to not use the build.xml...

comment:23 by stoecker, 16 years ago

Class name should be fixed in next build.

comment:24 by stoecker, 15 years ago

Resolution: fixed
Status: reopenedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain framm.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.