#18985 closed defect (fixed)
Changeset Manager: Strange behaviour when downloading a deleted object
| Reported by: | skyper | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 20.05 |
| Component: | Core | Version: | |
| Keywords: | template_report changeset manager download deleted | Cc: | GerdP |
Description (last modified by )
What steps will reproduce the problem?
- Have a changeset with a delete node in changeset manager
- In changeset content tab sort clicking on first column header
- Select the deleted node a click on download selected object
What is the expected result?
A warning that the deleted object can not be downloaded
What happens instead?
Lots of objects are downloaded
Please provide any additional information below. Attach a screenshot if possible.
Not sure if #18566 is involved here
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2020-03-24 07:37:08 +0100 (Tue, 24 Mar 2020) Revision:16200 Build-Date:2020-03-25 02:30:51 URL:https://josm.openstreetmap.de/svn/trunk Last errors/warnings: - W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out - W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out - W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out - W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out - W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out - W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out - W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out - W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out - W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out - W: Nothing to select - <html>The selected object is not available in the current<br>edit layer 'Data Layer 3'.</html>
Attachments (0)
Change History (12)
comment:1 by , 5 years ago
| Cc: | added |
|---|
comment:2 by , 5 years ago
follow-up: 5 comment:3 by , 5 years ago
Just a moment: It seems that the selection of the object doesn't work. When I download the history for a selected node object I get one for another object in the list.
comment:4 by , 5 years ago
Tested version r15937 still works OK. Must be a regression from a recent change.
comment:5 by , 5 years ago
comment:6 by , 5 years ago
| Description: | modified (diff) |
|---|
follow-up: 8 comment:7 by , 5 years ago
I did not sort intentionally but I cannot reproduce without sorting. I'll investigate the unexpected downloading of parents tomorrow.
comment:8 by , 5 years ago
Replying to GerdP:
I'll investigate the unexpected downloading of parents tomorrow.
That seems to be intended- See r11091. DownloadPrimitivesWithReferrersTask is executed with downloadReferrers set to true, also the members of relations are downloaded because full is also set to true.
Maybe it would be better to open the "download object" dialog filled with the selected objects so that a user can decide wether parents / children are wanted or not.
I'll try to add code so that DownloadPrimitivesWithReferrersTask doesn't try to download parents or children of deleted objects.
comment:10 by , 5 years ago
| Milestone: | → 20.04 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
I think the problems mentioned in this ticket are solved.
Can't reproduce. There is no button "download selected object" but one with tool tip "Download the current version of the selected objects". When I click that I see the expected warning. OTOH I also see that JOSM tries to download the parents of the deleted node which looks wrong.
Maybe you used the right click option "Download objects"? This seems to have the same meaning, it also produces the warning.