[TaggingPreset] Make templates available for formatting key values, like for item names

[KorneySan]

Proposal is to make formatting by template available for key values like it done for item names.

This is especially usable for public transport routes naming.

In TaggingPresets there is an example for item naming:

<?xml version="1.0" encoding="UTF-8"?>
<presets>
        <item name="Public transportation" type="relation"
                name_template="Bus({operator} {ref} ?{'{from} - {via} - {to}' | '{from} - {to}' | '{from}' | '{to}'})"
                name_template_filter="type=route route=bus">
        </item>
</presets>

which set JOSM to DISPLAY a route relation name by that template. But the same is suitable for the route name by default:

    <text
        key="name"
        text="Name"
        default_template="Bus {ref}?{: '{from} → {to}'}"
        default_template_filter="type=route route=bus">
        />

The value set event should happen for example on route creation dialogue OK button press.

[skyper]

name_template is only defined for <item>, atm. E.g., this is a an enhancement for core.

[simon04]

I'm confused: the title says "formatting key values", the description says "formatting by template" (meaning for display purposes?), the description says "value set event" (change something?). Please provide the following details.

Having default_template="Bus {ref}?{: '{from} → {to}'}" in place, when creating a new relation (using the preset dialog only) without providing a name, the template should be evaluated based on the other values (which in turn might trigger a default_template as well??) and the result be set as name?

[KorneySan]

Replying to Don-vip:

Having default_template="Bus {ref}?{: '{from} → {to}'}" in place, when creating a new relation (using the preset dialog only) without providing a name, the template should be evaluated based on the other values (which in turn might trigger a default_template as well??) and the result be set as name?

Exactly!
On preset dialog closing by OK button the engine should check the name value and if it is empty AND default_template is set, it should evaluate default_template and set the result to the name.

[simon04]

Ticket #20049 has been marked as a duplicate of this ticket.

[simon04]

In 17609/josm:

see #18949 - Extract class TaggingPresetItemGuiSupport

[simon04]

In 17610/josm:

see #18949 - Tagging presets: value_template="..." for <text>

Use value_template to generate the value automatically based on other <text> values of this preset. For instance, "Bus {ref}: {from} → {to}" can be used to generate the name of a bus route relation.

[simon04]

resources/data/defaultpresets.xml

@@ -2834 +2834 @@
         </item> <!-- Public Transport Route (Rail) -->
         <item name="Public Transport Route (Bus)" icon="presets/misc/route.svg" type="relation" preset_name_label="true">
             <link wiki="Public_transport#Service_routes" />
             <space />
             <key key="type" value="route" />
             <combo key="route" text="Route type" values="bus,share_taxi,trolleybus" values_searchable="true" match="keyvalue!" />
             <key key="public_transport:version" value="2" /> <!-- only validate marked relations in order to avoid false positives -->
-            <reference ref="name_ref" />
+            <text key="name" text="Name" value_template="Bus {ref}: {from} → {to}" />
+            <text key="ref" text="Reference" />
             <optional>
                 <reference ref="public_transport_route_optionals" />
                 <combo key="reservation" text="Reservation" values="yes,no,required,recommended" />
             </optional>
             <roles>
                 <role key="stop" text="stop position" requisite="optional" type="node" member_expression="public_transport=stop_position (bus=yes OR share_taxi=yes OR trolleybus=yes)" />
                 <role key="stop_exit_only" text="stop position (exit only)" requisite="optional" type="node" member_expression="public_transport=stop_position (bus=yes OR share_taxi=yes OR trolleybus=yes)" />

[simon04]

In 17611/josm:

see #18949 - Add TaggingPresetItemGuiSupportTest

[simon04]

In 17639/josm:

see #18949 - Tagging presets: trigger value_template="..." from <combo> and <multiselect> changes

[simon04]

Documentation: TaggingPresets?action=diff&version=179

[skyper]

Thanks for this feature but sadly it does not work that nicely with defaultpresets.

• We have lots of route relations' presets with a combo for route=*. How can I get the value of route=* with a capital, first letter or even in local language?
• I often have more than one value for via. How can I split the string at the semicolon and add some chars in between?

[skyper]

Replying to skyper:

• We have lots of route relations' presets with a combo for route=*. How can I get the value of route=* with a capital, first letter or even in local language?

Tried to solve this with the syntax of name_template="" but it does not work: #20842.

[skyper]

Replying to skyper:

Replying to skyper:

• We have lots of route relations' presets with a combo for route=*. How can I get the value of route=* with a capital, first letter or even in local language?

Tried to solve this with the syntax of name_template="" but it does not work: #20842.

Thanks, now it works with r17860.

Replying to simon04:

Documentation: TaggingPresets?action=diff&version=179

As far as I understand it, the syntax of name_template="" is used which means it is not limited to values of <text /> and not even to only the object tags as e.g. parent relations and their tags could be used. Am I right?

[skyper]

Still some issues, see #20851.

[skyper]

Replying to KorneySan:

On preset dialog closing by OK button the engine should check the name value and if it is empty AND default_template is set, it should evaluate default_template and set the result to the name.

See #20861.

[simon04]

In 17899/josm:

fix #20888, see #18949 - Tagging presets (value_template): fix IllegalStateException: Attempt to mutate in notification

[Don-vip]

In 18023/josm:

fix #21117 - see #18949 - avoid infinite loop with presets with several value_template items