Opened 16 years ago
Closed 16 years ago
#1841 closed defect (fixed)
[patch] Version information of manifest not displayed
Reported by: | stephankn | Owned by: | framm |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | Core | Version: | latest |
Keywords: | Cc: | stephankn |
Description
Builds out of SVN use a different method of inserting version information. Here the manifest is used.
The classloader trys to locate the Manifest in classpath order. It is not guaranteed that the right manifest is retrieved.
It should use this one:
jar:file:/C:/Documents%20and%20Settings/Stephan/workspace/josm/core/dist/josm-custom.jar!/META-INF/MANIFEST.MF
but found that one first:
file:/C:/Program%20Files/Java/jre6/lib/ext/QTJava.zip!/META-INF/MANIFEST.MF
The patch fixes this by first determining the location of the jar containing "our" class file.
Once the "official" build process also uses the manifest for version information the call trying to fetch "REVISION" can be removed.
Another fix was the regular expression retrieving the version. This ignored the "SVN" suffix added by the build process.
Attachments (2)
Change History (4)
by , 16 years ago
Attachment: | josm-1841-manifest_lookup.patch added |
---|
comment:1 by , 16 years ago
The pattern was for numeric part on purpose, as the numeric part is used for version checks.
by , 16 years ago
Attachment: | josm-1841-manifest_and_versioncheck.patch added |
---|
Path additionally address not working check for required JOSM version
patch fixing the described problem