[PATCH] If there is a fixme and the fixme value is also a tag, we should ask if the fixme is fixed

[taylor.smock]

Example: way fixme=name name=Broadway -- the fixme may or may not be fixed.

The patch I uploaded throws a warning when an object is modified and fulfills the criteria while only throwing an informational warning if it has not been modified.

Note: I didn't see a good place to put the check in the preexisting files.

[Klumbumbus]

In 16775/josm:

fix #17296 - If the value of fixme is also a tag, ask if the fixme is fixed (patch by taylor.smock, modified)

[Klumbumbus]

In 16777/josm:

fix #17296 - support variant FIXME too

[taylor.smock]

I'm sorry that I didn't have FIXME in the original patch. :(

Thanks for looking at this patch -- I had kind of forgotten about it.

[Klumbumbus]

Replying to taylor.smock:

FIXME

Yeah, a bit annoying we have these duplicate tags in the database. However the number very slowly decreases: ​https://taghistory.raifer.tech/#***/Fixme/&***/fixme/&***/FIXME/

[skyper]

It would be even better to use case insensitive regex to catch Fixme and other variants, as well.

Yesterday, I found a tag crossing=Fixme.

Replying to Klumbumbus:

Replying to taylor.smock:

FIXME

Yeah, a bit annoying we have these duplicate tags in the database. However the number very slowly decreases:
​https://taghistory.raifer.tech/#***/Fixme/&***/FIXME/&***/fixme/

Thanks to iD deprecating a tag which is not deprecated and people modifying objects only to change FIXME to lower cases. Very annoying, especially with big relations.

[Klumbumbus]

Replying to skyper:

It would be even better to use case insensitive regex to catch Fixme and other variants, as well.

I don't think thats possible with that syntax due to the tag() expressions. I think it is not needed anyway as the numbers of fixme variants other than fixme and FIXME are very low compared to these two.

[taylor.smock]

I think it would require #17669 to be fixed at a minimum, with a caveat that as soon as a "group" becomes available, it is now available for following conditions. I don't know if this is already the case (its been awhile since I touched anything related to mapcss, including mapcss files).

[skyper]

Replying to Klumbumbus:

Replying to skyper:

It would be even better to use case insensitive regex to catch Fixme and other variants, as well.

I don't think that's possible with that syntax due to the tag() expressions.

Need to use regexp_test() or regexp_match() which have the options for case-insensitive.

I think it is not needed anyway as the numbers of fixme variants other than fixme and FIXME are very low compared to these two.

So, keep it for now.

Yesterday, I found a tag crossing=Fixme.

Mmh, I get the common FIXMES informal warning. Here either more cases are tested or case-insensitive is in use.
Probably better to remove the tag (crossing in my case) completely and add a new tag with switched key - value, e.g. Fixme=crossing.

[Klumbumbus]

In 17038/josm:

fix #19805, see #17296 - Improve "Is the fixme fixed?" validator warning