Wrongly scaled icon in photoadjust plugin

[Klumbumbus]

What steps will reproduce the problem?

0. Install the plugin
1. Edit -> Edit photo GPS data
2. Wrongly scaled icon on Undo button

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-10-14 00:31:10 +0200 (Sun, 14 Oct 2018)
Build-Date:2018-10-14 01:32:52
Revision:14326
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14326 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 1803 (17134)
Memory Usage: 1225 MB / 3641 MB (441 MB allocated, but free)
Java version: 1.8.0_181-b13, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1680x1050
Maximum Screen Size: 1680x1050
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files (x86)\josm-latest-mehr-RAM.jnlp, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=1024m,4096m, -Djnlpx.splashport=51456, -Djnlpx.jvm=<java.home>\bin\javaw.exe]
Dataset consistency test: No problems found

Plugins:
+ DirectUpload (34502)
+ HouseNumberTaggingTool (34517)
+ OpeningHoursEditor (34535)
+ apache-commons (34506)
+ apache-http (34632)
+ buildings_tools (34572)
+ editgpx (34506)
+ ejml (34389)
+ geojson (87)
+ imagery-xml-bounds (34518)
+ imagery_offset_db (34641)
+ jna (34633)
+ jogl (1.2.2)
+ jts (34524)
+ log4j (34527)
+ measurement (34529)
+ photo_geotagging (34576)
+ photoadjust (34612)
+ reltoolbox (34614)
+ reverter (34552)
+ rex (49)
+ tag2link (34559)
+ tageditor (34560)
+ tagging-preset-tester (34561)
+ terracer (34584)
+ turnlanes-tagging (272)
+ turnrestrictions (34643)
+ undelete (34568)
+ utilsplugin2 (34506)

Last errors/warnings:
- E: java.io.IOException: The requested URL https://osmlab.github.io/editor-layer-index/imagery.xmlx was not found
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: java.io.IOException: The requested URL https://github.com/Jungle-Bus/transport_mapcss/raw/master/transport.validator.zip was not found
- W: Failed to add https://github.com/Jungle-Bus/transport_mapcss/raw/master/transport.validator.zip to tag checker
- W: java.io.IOException: No file found for: https://github.com/Jungle-Bus/transport_mapcss/raw/master/transport.validator.zip
- W: Invalid jar file ''<josm.pref>\plugins\photo_geotagging.jar.new'' (exists: false, canRead: false)
- W: Invalid jar file ''<josm.pref>\plugins\photoadjust.jar.new'' (exists: false, canRead: false)

[holgermappt]

The plugin does undoButton.setIcon(ImageProvider.get("undo"));. Did something change with the undo icon?

[Klumbumbus]

It was changed to svg in r13837.

[Don-vip]

You should use the new API that takes care of correct sizes by adding this to your AbstractAction constructor:

new ImageProvider("undo").getResource().attachImageIcon(this);

[holgermappt]

This is fixed in [o34684]. Thanks for reporting this.