[PATCH] Implement check for buildings sharing nodes with res. area or ways.

[marxin]

Add new check for sharing of nodes. It's useful when doing validation for HOTOSM tasks.

[Don-vip]

Why "Building sharing point with a building" should be a warning? It's perfectly valid and common.

[marxin]

Replying to Don-vip:

Why "Building sharing point with a building" should be a warning? It's perfectly valid and common.

You are right that for many cities it's valid. But as mentioned, HOTOSM tasks very often handle low-developed areas where such pattern means in 99% of cases a mistake done by user. If you mind, I would disable the warning by default and HOTOSM validators will enable that on request.

[Klumbumbus]

Replying to Don-vip:

Why "Building sharing point with a building" should be a warning? It's perfectly valid and common.

Yes, this test should not be in JOSM by default (even not as info level).

[marxin]

Replying to Klumbumbus:

Replying to Don-vip:

Why "Building sharing point with a building" should be a warning? It's perfectly valid and common.

Yes, this test should not be in JOSM by default (even not as info level).

Agree. Will it be then acceptable with the change?

[Don-vip]

Replying to marxin:

Agree. Will it be then acceptable with the change?

I'm not in favour of having something disabled in core for most of our users. You should rather implement this check as a mapCSS rule dedicated to HOTOSM, see examples in Rules

[Klumbumbus]

Replying to Don-vip:

I'm not in favour of having something disabled in core for most of our users. You should rather implement this check as a mapCSS rule dedicated to HOTOSM, see examples in Rules

Yes, sounds better.

[marxin]

I can confirm following mapcss patterns works for me. One exception is situation of 2 buildings that share a point:

diff --git a/data/validator/geometry.mapcss b/data/validator/geometry.mapcss
index 9dc1831b7..dac71416b 100644
--- a/data/validator/geometry.mapcss
+++ b/data/validator/geometry.mapcss
@@ -189,6 +189,23 @@ area:closed:areaStyle[landuse!=residential][tag("landuse") = parent_tag("landuse
   throwWarning: tr("Overlapping Identical Landuses");
 }
 
+area:closed[building][building!=no] > node {
+  set node_in_building;
+}
+
+area:closed:areaStyle[landuse=residential][landuse] > node.node_in_building {
+  throwWarning: tr("Building sharing point with a residential area");
+}
+
+way[highway] > node.node_in_building {
+  throwWarning: tr("Building sharing point with a highway");
+}
+
+area:closed[building][building!=no] ⧉
+area:closed[building][building!=no] {
+  throwWarning: tr("Building sharing point with a building");
+}
+
 /* see ticket:#9522 */
 node[tag("amenity") = parent_tag("amenity")] ∈ *[amenity][amenity != parking] {
   throwWarning: tr("{0} inside {1}", concat("amenity=", tag("amenity")), concat("amenity=", tag("amenity")));

Can you please help me how to do it for the buildings?
Thanks

[skyper]

Ping.

@marxin: Are you still working on this?

[anonymous]

No, I left the project some time ago..

[GerdP]

Can we close this as wontfix? The suggested test sounds not useful to me. If useful for HOTOSM it might be implemented in a plugin or special mapcss rules.

[marxin]

Yes, please close it.