Add compatibility with Java 9

[Don-vip]

Java 9 is well advanced in its development, early builds are now available. ​Jigsaw project is now merged into main tree.

I have added basic Java 9 support in r8777:8778, r8793, r8795, r8796:8797 but making JOSM work with Jigsaw is another challenge.

This ticket aims to list all problems encountered.

1. xmltask does not work ==> cannot build OSX package ==> ​fork created
2. ​Proguard does not work ==> cannot build optimized jar
3. ​Groovy does not work ==> cannot run some tests + cannot build taginfo files ==> fixed
4. ResourceBundle.getBundle("sun.awt.resources.awt") results in an internal error ==> bug ​reported to Oracle ==> fixed
5. Findbugs does not recognize new version string ==> ​bug and PR created ==> fixed
6. ​JEP 272 removes com.apple.eawt package ==> need to update PlatformHookOsx ==> partially fixed, nedd more tests about deprecated methods, full screen, dock image
7. ​javabug:6850612 deprecates Class.newInstance ==> replace it by Class.getConstructor().newInstance() ==> fixed
8. ​javabug:8154801 deprecates java.util.Observer / java.util.Observable ==> replace it by javax.swing.ChangeListener ==> fixed
9. Ant does not work anymore ==> ​Bug created + workaround done in r10259
10. ​javabug:8152912 deprecates XMLReaderFactory ==> fixed
11. Groovy bug: ​https://issues.apache.org/jira/browse/GROOVY-7879

Unit tests:

1. jacoco has problems with nashorn: Method jdk.dynalink.linker.LinkerServices.$jacocoInit()[Z must be InterfaceMethodref constant ​log ==> See #13150 for fix
   1. Could not initialize class org.openstreetmap.josm.data.validation.tests.OpeningHourTest and Could not initialize class org.openstreetmap.josm.data.validation.OsmValidator (they are shomehow destroyed by a combination of jacoco + nashorn)
2. EqualsVerifier fails in 2 unit tests
3. Projections seem to be off by the last digit. ​log

Plugins:

1. Geotools does not work ==> ​https://osgeo-org.atlassian.net/browse/GEOT-5289
2. Apache Commons does not compile ==> ​https://issues.apache.org/jira/browse/COLLECTIONS-593

[Don-vip]

In 8816/josm:

see #11924 - JDK9 Jigsaw: workaround for ​https://bugs.openjdk.java.net/browse/JI-9025152

[Don-vip]

In 8817/josm:

see #11924 - JDK9 Jigsaw: do not run code in headless environment (for jenkins unit tests)

[Don-vip]

In 8826/josm:

see #11924 - update xmltask to a new modern version built from ​https://github.com/don-vip/xmltask

[Don-vip]

In 8843/josm:

see #11924 - allow openjdk-9-jre in Debian control file

[Don-vip]

All plugins load fine with Java 9 except ImportImagePlugin, which relies on geotools:

23:45:31.948 [main] FATAL org.openstreetmap.josm.plugins.ImportImagePlugin.ImportImagePlugin - Error while loading plugin
java.lang.IllegalArgumentException: org.opengis.referencing.datum.DatumFactory is not an ImageIO SPI class
	at javax.imageio.spi.ServiceRegistry.checkClassAllowed(ServiceRegistry.java:733) ~[?:?]
	at javax.imageio.spi.ServiceRegistry.<init>(ServiceRegistry.java:138) ~[?:?]
	at org.geotools.factory.FactoryRegistry.<init>(FactoryRegistry.java:155) ~[geotools.jar:?]
	at org.geotools.factory.FactoryRegistry.<init>(FactoryRegistry.java:146) ~[geotools.jar:?]
	at org.geotools.factory.FactoryCreator.<init>(FactoryCreator.java:82) ~[geotools.jar:?]
	at org.geotools.referencing.ReferencingFactoryFinder.getServiceRegistry(ReferencingFactoryFinder.java:115) ~[geotools.jar:?]
	at org.geotools.referencing.ReferencingFactoryFinder.getFactories(ReferencingFactoryFinder.java:180) ~[geotools.jar:?]
	at org.geotools.referencing.ReferencingFactoryFinder.getCRSAuthorityFactories(ReferencingFactoryFinder.java:455) ~[geotools.jar:?]
	at org.geotools.referencing.DefaultAuthorityFactory.getSupportedCodes(DefaultAuthorityFactory.java:125) ~[geotools.jar:?]
	at org.geotools.referencing.CRS.getSupportedCodes(CRS.java:396) ~[geotools.jar:?]
	at org.openstreetmap.josm.plugins.ImportImagePlugin.PluginOperations.loadCRSData(PluginOperations.java:366) ~[ImportImagePlugin.jar:?]
	at org.openstreetmap.josm.plugins.ImportImagePlugin.ImportImagePlugin.<init>(ImportImagePlugin.java:88) [ImportImagePlugin.jar:?]

I have no idea what's the problem yet. Maybe linked to ​JEP 262.

[Don-vip]

Found it, it's a change of behaviour from ​javabug:8068749:

Java SE has been changed so that javax.imageio.spi.ServiceRegistry no longer allows service providers of other than Image I/O service types to be loaded. This is a behavioral change. Existing application binaries that attempt to use ServiceRegistry for non-Image-I/O services will cause IllegalArgumentException to be thrown at runtime. Such applications should be migrated to use java.util.ServiceLoader instead of javax.imageio.spi.ServiceRegistry.

[Don-vip]

Bug reported to GeoTools: ​https://osgeo-org.atlassian.net/browse/GEOT-5289

[Don-vip]

In 9199/josm:

see #11924 - add compatibility with new Java 9 version scheme (MAJOR.MINOR.SECURITY, see JEP 223)

[Don-vip]

In 9202/josm:

see #11924 - add robustness for short versions "9" and "9-ea"

[mdk]

3. ​Groovy does not work ==> cannot run some tests + cannot build taginfo files

As far as I could see, this problem is fixed in Groovy v2.4.6.

[mdk]

4. ResourceBundle.getBundle("sun.awt.resources.awt") results in an internal error ==> bug ​reported to Oracle

Also this problem seems to be fixed since 2015-11-10 (see ​https://bugs.openjdk.java.net/browse/JDK-8136804)

[Don-vip]

Yes, The Oracle bug is fixed in latest JDK9/Jigsaw builds. However Groovy 2.4.6 is not released yet.

[Don-vip]

In 9330/josm:

see #11924 - update to Groovy 2.4.6-SNAPSHOT (rev 23ad731c49dceda51e5ff324d1cfed48d7d65c49 - 2016-01-05) downloaded from CI server, to get fixes for:

• ​https://issues.apache.org/jira/browse/GROOVY-7587
• ​https://issues.apache.org/jira/browse/GROOVY-7716

There's no schedule about 2.4.6 official release, and authors say they "have only very little time these days to actually do the change", see ​https://issues.apache.org/jira/browse/GROOVY-7291?focusedCommentId=15083011&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15083011

The jar has been downloaded from ​http://ci.groovy-lang.org/repository/download/Groovy_Jdk7Build/30993:id/target/distributions/apache-groovy-binary-2.4.6-SNAPSHOT.zip%21/groovy-2.4.6-SNAPSHOT/embeddable/groovy-all-2.4.6-SNAPSHOT.jar

[Don-vip]

In 9332/josm:

see #11924 - if available, use java.runtime.version instead of java.version in status report to get build number (useful for Early Access builds)

[Don-vip]

In 9333/josm:

see #12186, #11924 - update projection regression test file for Java 9

generated on Windows with:

java version "9-ea"
Java(TM) SE Runtime Environment (build 9-ea+99-2015-12-23-183325.javare.4146.nc)
Java HotSpot(TM) 64-Bit Server VM (build 9-ea+99-2015-12-23-183325.javare.4146.nc, mixed mode)

[Don-vip]

In 9344/josm:

see #11924 - fix one javadoc warning with JDK9, add more unit tests

[Don-vip]

In 9599/josm:

see #11924 - add assertions to check if java.locale.providers enables CLDR as default because of JEP 252 in Java 9 (unit tests depending on default Java date formatting are failing)

[Don-vip]

In 9605/josm:

see #11924 - use ISO date format in unit tests to avoid differences between JDK7/8 and 9

[Don-vip]

In 9908/josm:

see #12186, #11924 - update projection regression test file for Java 9

generated on Windows with:

java version "9-ea"
Java(TM) SE Runtime Environment (build 9-ea+107-2016-02-24-182456.javare.4520.nc)
Java HotSpot(TM) 64-Bit Server VM (build 9-ea+107-2016-02-24-182456.javare.4520.nc, mixed mode)

[Don-vip]

In 10048/josm:

see #11924 - add -XaddExports:java.base/sun.security.x509=ALL-UNNAMED JVM option for JDK9 tests (see ​http://mreinhold.org/blog/jigsaw-module-system). Requires Ant 1.9.1 or later

[Don-vip]

In 10049/josm:

see #11924 - remove tab

[Don-vip]

In 10052/josm:

see #11924 - reduce double precision in unit tests to avoid tiny differences with JDK9

[Don-vip]

In 10056/josm:

see #11924 - use correct "if" syntax

[Don-vip]

In 10057/josm:

see #11924 - add -XaddExports:java.base/sun.security.util=ALL-UNNAMED

[Don-vip]

In 10058/josm:

see #11924 - Package.getPackage is deprecated in Java 9

[Don-vip]

In 10059/josm:

see #11924 - write proper html code to see it it resolves unit test failing only with jdk9

[Don-vip]

In 10060/josm:

see #11924 - remove deprecated code, reduce double precision in unit tests to avoid tiny differences with JDK9

[Don-vip]

In 10061/josm:

see #11924 - reduce double precision in unit tests to avoid tiny differences with JDK9

[Don-vip]

In 10064/josm:

see #12652, see #11924 - re-add a unit test in BugReportExceptionHandler, empty test class causes an error with Java 9

[Don-vip]

In 10065/josm:

see #11924 - rework projection regression test for java 9

[Don-vip]

In 10178/josm:

see #11924 - add compatibility with JEP 272 for Java 9 on OSX

[Don-vip]

In 10208/josm:

see #11924 - Java 9 - JDK-6850612 deprecates Class.newInstance() ==> replace it by Class.getConstructor().newInstance()

[Don-vip]

In 10209/josm:

see #11924 - Java 9 - fixes more deprecation warnings

[Don-vip]

In 10210/josm:

see #11924 - Java 9 - replace calls to deprecated classes java.util.Observable / java.util.Observer by a new class ChangeNotifier + swing's ChangeListener

[Don-vip]

In 10257/josm:

see #11924 - test possible workaround for ​https://bz.apache.org/bugzilla/show_bug.cgi?id=59556

[Don-vip]

In 10258/josm:

see #11924 - correct workaround for ​https://bz.apache.org/bugzilla/show_bug.cgi?id=59556

[Don-vip]

In 10259/josm:

see #11924 - JVM args ignored when same JVM is used

[Don-vip]

In 10260/josm:

see #11924 - use the new -XaddExports syntax specified in JEP 261

[Don-vip]

In 10262/josm:

see #11924 - add -XaddExports to access javax.xml.bind.DatatypeConverter used in JMapViewer

[Don-vip]

In 10264/josm:

see #11924 - add -addmods to access javax.xml.bind module used in JMapViewer

[Don-vip]

In 10265/josm:

see #11924 - use correct syntax

[Don-vip]

In 10267/josm:

see #11924 - use correct module

[Don-vip]

In 10269/josm:

see #11924 - remove unneeded addmods option

[Don-vip]

In 10270/josm:

see #11924 - update to Jacoco 0.7.7-20160523.090959-28 snapshot to add java 9 bytecode compatibility

[Don-vip]

In 10276/josm:

see #11924 - should be the minimal and correct addmods option

[Don-vip]

In 10289/josm:

see #12881, see #11924 - force generics to avoid Java 9 compilation error

[Don-vip]

In 10348/josm:

see #11924 - update to FindBugs 3.1.0_preview1 to add Java 9 support

[Don-vip]

In 10425/josm:

see #11924 - update to FindBugs 3.1.0_preview2

[Don-vip]

Core works relatively fine with Java 9. I have started to look at plugins, as expected they don't even compile. First error lies in Apache Commons code: ​https://issues.apache.org/jira/browse/COLLECTIONS-593

[michael2402]

I found some more problems in the unit tests.

[Don-vip]

In 10546/josm:

fix #13150, see #11924 - exclude nashorn classes from jacoco coverage to avoid lot of unit test failures (patch by michael2402)

[Don-vip]

In 10631/josm:

see #11924 - use jacoco-0.7.8-20160724.185238-10 snapshot to include ​https://github.com/jacoco/jacoco/pull/428 to fix failing unit tests since ​https://bugs.openjdk.java.net/browse/JDK-8145148

[Don-vip]

In 10741/josm:

see #11924 - XMLReaderFactory has been deprecated in Java 9, see ​https://bugs.openjdk.java.net/browse/JDK-8152912

[Don-vip]

In 10746/josm:

see #11390, see #11924 - replace javax.xml.bind.DatatypeConverter (not visible by default in Java 9) by java.util.Base64 (new in Java 8)

[Don-vip]

In 10821/josm:

see #11924 - update to jacoco-0.7.8-20160816.021912-12 (contains fix for ​https://github.com/jacoco/jacoco/pull/434 required for Java 9)