#11047 closed enhancement (fixed)
changeset: no length check for the source field
| Reported by: | aseerel4c26 | Owned by: | team |
|---|---|---|---|
| Priority: | minor | Milestone: | 15.01 |
| Component: | Core | Version: | tested |
| Keywords: | tags changeset source | Cc: |
Description (last modified by )
apparently there is no length check for the "source" field for changesets although it looks like the "comment" field. So, it also should behave like it.
- Revision: 7906
- Linux
- Java version: 1.8.0_31, Oracle Corporation, OpenJDK 64-Bit Server VM
What steps will reproduce the problem?
- make some data changes and click the upload button
- type too many letters (more than 255, IIRC) into the source field
- hit "upload"
What is the expected result?
the same like for the "comment" field: not even possible to enter too many characters
What happens instead?
error from server which leads to the error message:
Error message(untranslated): ChangesetTag 28523682,source: v: is too long (maximum is 255 characters) ("josm bug 11047 - lllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllll")
Workaround: At least the (long) comment is saved by JOSM, so it can be recovered with the drop-down button and shortened.
Attachments (0)
Change History (3)
comment:1 by , 10 years ago
| Description: | modified (diff) |
|---|---|
| Keywords: | changeset source added |
| Milestone: | → 15.01 |
comment:2 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:3 by , 10 years ago
thanks, works! tested with josm 7995.
While testing it I noticed a small inconvenience: there is no user feedback why pasting a long text does not work. It just is not pasted. However, likely it is not worth the effort to implement an unobtrusive user feedback (e.g. a flashing red right text box border) if too long text is tried to type or paste. (no new bug therefore)
In 7995/josm: