# # ChangeLog for trunk/tools/pmd/josm-ruleset.xml in josm # # Generated by Trac 1.6 # 2024-11-29T09:02:16+01:00 Tue, 19 Dec 2023 16:09:19 GMT taylor.smock [18918] * trunk/resources/data/defaultpresets.xml (modified) * trunk/resources/data/tagging-preset.xsd (modified) * trunk/src/org/openstreetmap/josm/data/osm/OsmUtils.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/tests/TagChecker.java (modified) * trunk/src/org/openstreetmap/josm/gui/NoteInputDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/mappaint/Environment.java (modified) * trunk/src/org/openstreetmap/josm/gui/mappaint/mapcss/PlaceholderExpression.java (modified) * trunk/src/org/openstreetmap/josm/gui/oauth/TestAccessTokenTask.java (modified) * trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPreset.java (modified) * trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetValidation.java (modified) * trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/ComboMultiSelect.java (modified) * trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/KeyedItem.java (modified) * trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/PresetListEntry.java (modified) * trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/RegionSpecific.java (added) * trunk/src/org/openstreetmap/josm/io/imagery/WMSImagery.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/validation/tests/TagCheckerTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetItemTest.java (added) * trunk/test/unit/org/openstreetmap/josm/gui/tagging/presets/items/CheckGroupTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/tagging/presets/items/CheckTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/tagging/presets/items/ComboTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/tagging/presets/items/ItemSeparatorTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/tagging/presets/items/KeyTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/tagging/presets/items/LabelTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/tagging/presets/items/LinkTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/tagging/presets/items/MultiSelectTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/tagging/presets/items/OptionalTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/tagging/presets/items/PresetLinkTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/tagging/presets/items/RegionSpecificTest.java (added) * trunk/test/unit/org/openstreetmap/josm/gui/tagging/presets/items/RolesTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/tagging/presets/items/SpaceTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/tagging/presets/items/TextTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/testutils/annotations/TaggingPresets.java (modified) * trunk/tools/pmd/josm-ruleset.xml (modified) Fix #23290: Validate the regions a tag is expected to be in (patch by ... Tue, 10 Jan 2023 23:08:25 GMT taylor.smock [18629] * trunk/ivy.xml (modified) * trunk/src/org/openstreetmap/josm/tools/Tag2Link.java (modified) * trunk/tools/ivy.xml (modified) * trunk/tools/pmd/josm-ruleset.xml (modified) Fix #22641: Update tag2link in dependencies (patch by gaben, modified ... Tue, 12 Jul 2022 15:16:14 GMT taylor.smock [18514] * trunk/ivy.xml (modified) * trunk/tools/ivy.xml (modified) * trunk/tools/pmd/josm-ruleset.xml (modified) Dependency updates ivy.xml: * metadata-extractor: 2.17.0 -> 2.18.0 ... Mon, 20 Dec 2021 13:12:10 GMT Don-vip [18332] * trunk/build.xml (modified) * trunk/ivy.xml (modified) * trunk/src/org/openstreetmap/josm/actions/OpenFileAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/mapmode/ExtrudeAction.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/DefaultNameFormatter.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/AbstractMapRenderer.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/routines/DomainValidator.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/tests/Addresses.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialog.java (modified) * trunk/src/org/openstreetmap/josm/io/ozi/OziWptReader.java (modified) * trunk/src/org/openstreetmap/josm/tools/HttpClient.java (modified) * trunk/test/unit/org/openstreetmap/josm/testutils/ThrowableRootCauseMatcher.java (modified) * trunk/tools/checkstyle/src/org/openstreetmap/josm/TopLevelJavadocCheck.java (modified) * trunk/tools/ivy.xml (modified) * trunk/tools/pmd/josm-ruleset.xml (modified) see #21596 - Update dependencies in ivy.xml and tools/ivy.xml (patch ... Fri, 13 Dec 2019 21:12:24 GMT Don-vip [15588] * trunk/src/org/openstreetmap/josm/actions/JosmAction.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/OsmPrimitive.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/OsmValidator.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/tests/MapCSSTagChecker.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/MapPaintDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/CustomConfigurator.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/importexport/GeoJSONImporter.java (modified) * trunk/src/org/openstreetmap/josm/gui/mappaint/mapcss/MapCSSStyleSource.java (modified) * trunk/src/org/openstreetmap/josm/io/BoundingBoxDownloader.java (modified) * trunk/src/org/openstreetmap/josm/io/CachedFile.java (modified) * trunk/src/org/openstreetmap/josm/io/Compression.java (modified) * trunk/src/org/openstreetmap/josm/io/GpxReader.java (modified) * trunk/src/org/openstreetmap/josm/io/OsmServerLocationReader.java (modified) * trunk/src/org/openstreetmap/josm/io/remotecontrol/RemoteControlHttpServer.java (modified) * trunk/src/org/openstreetmap/josm/io/remotecontrol/RequestProcessor.java (modified) * trunk/src/org/openstreetmap/josm/plugins/PluginListParser.java (modified) * trunk/tools/checkstyle/META-INF/MANIFEST.MF (modified) * trunk/tools/checkstyle/checkstyle-all.jar (modified) * trunk/tools/checkstyle/josm_checks.xml (modified) * trunk/tools/checkstyle/josm_filters.xml (modified) * trunk/tools/pmd/asm-6.2.1.jar (deleted) * trunk/tools/pmd/asm-7.1.jar (added) * trunk/tools/pmd/designer.bat (modified) * trunk/tools/pmd/flowless-0.6.jar (deleted) * trunk/tools/pmd/josm-ruleset.xml (modified) * trunk/tools/pmd/pmd-core-6.10.0.jar (deleted) * trunk/tools/pmd/pmd-core-6.20.0.jar (added) * trunk/tools/pmd/pmd-java-6.10.0.jar (deleted) * trunk/tools/pmd/pmd-java-6.20.0.jar (added) * trunk/tools/pmd/pmd-ui-6.10.0.jar (deleted) * trunk/tools/pmd/pmd-ui-6.19.0.jar (added) * trunk/tools/pmd/reactfx-2.0-M5.jar (deleted) * trunk/tools/pmd/richtextfx-0.9.0.jar (deleted) * trunk/tools/pmd/undofx-2.0.0.jar (deleted) * trunk/tools/pmd/wellbehavedfx-0.3.3.jar (deleted) * trunk/tools/spotbugs/bcel-6.2.jar (deleted) * trunk/tools/spotbugs/bcel-6.3.jar (added) * trunk/tools/spotbugs/dom4j-2.1.0.jar (deleted) * trunk/tools/spotbugs/dom4j-2.1.1.jar (added) * trunk/tools/spotbugs/spotbugs-annotations.jar (modified) * trunk/tools/spotbugs/spotbugs-ant.jar (modified) * trunk/tools/spotbugs/spotbugs.jar (modified) tools update: checkstyle 8.27, pmd 6.20, spotbugs 3.1.12 Fri, 04 Jan 2019 21:24:55 GMT simon04 [14638] * trunk/build.xml (modified) * trunk/scripts/BuildProjectionDefinitions.java (modified) * trunk/scripts/TagInfoExtract.java (modified) * trunk/tools/pmd/josm-ruleset.xml (modified) Run PMD on scripts/ and apply fixes Thu, 27 Dec 2018 16:45:37 GMT Don-vip [14604] * trunk/.classpath (modified) * trunk/build.xml (modified) * trunk/test/lib/awaitility-3.1.2.jar (deleted) * trunk/test/lib/awaitility-3.1.5.jar (added) * trunk/test/lib/equalsverifier-2.5.1.jar (deleted) * trunk/test/lib/equalsverifier-3.1.2.jar (added) * trunk/test/lib/jmockit-1.43.jar (deleted) * trunk/test/lib/jmockit.jar (added) * trunk/test/lib/system-rules-1.16.1.jar (deleted) * trunk/test/lib/system-rules-1.19.0.jar (added) * trunk/test/lib/wiremock-standalone-2.18.0.jar (deleted) * trunk/test/lib/wiremock-standalone-2.20.0.jar (added) * trunk/test/unit/org/openstreetmap/josm/actions/CombineWayActionTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/MapStatusTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/testutils/mockers/ExtendedDialogMocker.java (modified) * trunk/tools/checkstyle/checkstyle-all.jar (modified) * trunk/tools/groovy/groovy-2.5.1.jar (deleted) * trunk/tools/groovy/groovy-2.5.5.jar (added) * trunk/tools/groovy/groovy-ant-2.5.1.jar (deleted) * trunk/tools/groovy/groovy-ant-2.5.5.jar (added) * trunk/tools/groovy/groovy-cli-commons-2.5.1.jar (deleted) * trunk/tools/groovy/groovy-cli-commons-2.5.5.jar (added) * trunk/tools/groovy/groovy-test-2.5.1.jar (deleted) * trunk/tools/groovy/groovy-test-2.5.5.jar (added) * trunk/tools/groovy/groovy-xml-2.5.1.jar (deleted) * trunk/tools/groovy/groovy-xml-2.5.5.jar (added) * trunk/tools/pmd/asm-6.2.1.jar (added) * trunk/tools/pmd/asm-6.2.jar (deleted) * trunk/tools/pmd/commons-io-2.4.jar (deleted) * trunk/tools/pmd/commons-io-2.6.jar (added) * trunk/tools/pmd/commons-lang3-3.7.jar (deleted) * trunk/tools/pmd/commons-lang3-3.8.1.jar (added) * trunk/tools/pmd/josm-ruleset.xml (modified) * trunk/tools/pmd/pmd-core-6.10.0.jar (added) * trunk/tools/pmd/pmd-core-6.6.0.jar (deleted) * trunk/tools/pmd/pmd-java-6.10.0.jar (added) * trunk/tools/pmd/pmd-java-6.6.0.jar (deleted) * trunk/tools/pmd/pmd-ui-6.10.0.jar (added) * trunk/tools/pmd/pmd-ui-6.6.0.jar (deleted) * trunk/tools/spotbugs/asm-6.2.jar (deleted) * trunk/tools/spotbugs/asm-7.0.jar (added) * trunk/tools/spotbugs/asm-analysis-6.2.jar (deleted) * trunk/tools/spotbugs/asm-analysis-7.0.jar (added) * trunk/tools/spotbugs/asm-commons-6.2.jar (deleted) * trunk/tools/spotbugs/asm-commons-7.0.jar (added) * trunk/tools/spotbugs/asm-tree-6.2.jar (deleted) * trunk/tools/spotbugs/asm-tree-7.0.jar (added) * trunk/tools/spotbugs/asm-util-6.2.jar (deleted) * trunk/tools/spotbugs/asm-util-7.0.jar (added) * trunk/tools/spotbugs/asm-xml-6.2.jar (deleted) * trunk/tools/spotbugs/jFormatString-3.0.0.jar (deleted) * trunk/tools/spotbugs/spotbugs-annotations.jar (modified) * trunk/tools/spotbugs/spotbugs-ant.jar (modified) * trunk/tools/spotbugs/spotbugs.jar (modified) tools update: awaitility 3.1.5, equalsverifier 3.1.2, jmockit 1.44, ... Fri, 31 Aug 2018 19:59:54 GMT Don-vip [14209] * trunk/src/org/openstreetmap/josm/data/gpx/GpxImageCorrelation.java (modified) * trunk/src/org/openstreetmap/josm/data/gpx/GpxImageEntry.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/geoimage/CorrelateGpxWithImages.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/gpx/GpxImageEntryTest.java (added) * trunk/tools/pmd/josm-ruleset.xml (modified) see #16681 - spotbugs / pmd Tue, 08 May 2018 13:22:31 GMT Don-vip [13719] * trunk/tools/pmd/asm-6.0.jar (deleted) * trunk/tools/pmd/asm-6.1.1.jar (added) * trunk/tools/pmd/josm-ruleset.xml (modified) * trunk/tools/pmd/pmd-core-6.2.0.jar (deleted) * trunk/tools/pmd/pmd-core-6.4.0-SNAPSHOT.jar (added) * trunk/tools/pmd/pmd-java-6.2.0.jar (deleted) * trunk/tools/pmd/pmd-java-6.4.0-SNAPSHOT.jar (added) * trunk/tools/pmd/pmd-ui-6.2.0.jar (deleted) * trunk/tools/pmd/pmd-ui-6.3.0.jar (added) update to PMD 6.3.0 + ad4166e30079b676e22459108692f78759405ed8 See ... Mon, 02 Apr 2018 21:20:00 GMT Don-vip [13595] * trunk/tools/groovy-all.jar (modified) * trunk/tools/japicc/japi-compliance-checker.pl (modified) * trunk/tools/japicc/modules/Internals/APIDump.pm (modified) * trunk/tools/japicc/modules/Internals/Basic.pm (modified) * trunk/tools/japicc/modules/Internals/Descriptor.pm (modified) * trunk/tools/japicc/modules/Internals/Filter.pm (modified) * trunk/tools/japicc/modules/Internals/Input.pm (modified) * trunk/tools/japicc/modules/Internals/Logging.pm (modified) * trunk/tools/japicc/modules/Internals/Mangling.pm (modified) * trunk/tools/japicc/modules/Internals/Path.pm (modified) * trunk/tools/japicc/modules/Internals/RegTests.pm (modified) * trunk/tools/japicc/modules/Internals/SysFiles.pm (modified) * trunk/tools/japicc/modules/Internals/TypeAttr.pm (modified) * trunk/tools/japicc/modules/Internals/Utils.pm (modified) * trunk/tools/japicc/modules/RulesBin.xml (modified) * trunk/tools/japicc/modules/RulesSrc.xml (modified) * trunk/tools/pmd/josm-ruleset.xml (modified) * trunk/tools/pmd/pmd-core-6.1.0.jar (deleted) * trunk/tools/pmd/pmd-core-6.2.0.jar (added) * trunk/tools/pmd/pmd-java-6.1.0.jar (deleted) * trunk/tools/pmd/pmd-java-6.2.0.jar (added) * trunk/tools/pmd/pmd-ui-6.1.0.jar (deleted) * trunk/tools/pmd/pmd-ui-6.2.0.jar (added) tools update: Groovy 2.4.15, PMD 6.2.0, JAPICC 2.4 Sun, 17 Dec 2017 23:46:58 GMT Don-vip [13220] * trunk/src/org/openstreetmap/josm/gui/layer/geoimage/CorrelateGpxWithImages.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/geoimage/ImageDisplay.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/geoimage/ImageEntry.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/geoimage/ImageViewerDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/KeyedItem.java (modified) * trunk/tools/pmd/josm-ruleset.xml (modified) * trunk/tools/spotbugs/josm-filter.xml (modified) see #15574: - additionally refactors ImageDisplay to use ImageEntry ... Sun, 17 Dec 2017 00:25:46 GMT Don-vip [13207] * trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/MapRendererFactory.java (modified) * trunk/src/org/openstreetmap/josm/data/projection/ProjectionCLI.java (modified) * trunk/src/org/openstreetmap/josm/gui/mappaint/RenderingCLI.java (modified) * trunk/src/org/openstreetmap/josm/gui/oauth/OsmOAuthAuthorizationClient.java (modified) * trunk/src/org/openstreetmap/josm/io/ChangesetClosedException.java (modified) * trunk/src/org/openstreetmap/josm/io/OsmApi.java (modified) * trunk/tools/pmd/antlr-runtime-3.5.2.jar (added) * trunk/tools/pmd/flowless-0.6.jar (added) * trunk/tools/pmd/josm-ruleset.xml (modified) * trunk/tools/pmd/pmd-ui-6.0.0.jar (added) * trunk/tools/pmd/reactfx-2.0-M5.jar (added) * trunk/tools/pmd/richtextfx-0.8.1.jar (added) * trunk/tools/pmd/undofx-1.3.1.jar (added) * trunk/tools/pmd/wellbehavedfx-0.3.jar (added) enable PMD rule `PreserveStackTrace` + add missing jars to run new ... Sat, 16 Dec 2017 23:42:54 GMT Don-vip [13206] * trunk/src/org/openstreetmap/josm/actions/AbstractMergeAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/AddImageryLayerAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/OpenLocationAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/PurgeAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/RestartAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/SplitWayAction.java (modified) * trunk/src/org/openstreetmap/josm/command/SequenceCommand.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/Relation.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/Way.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/StyledMapRenderer.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/relations/Multipolygon.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/routines/InetAddressValidator.java (modified) * trunk/src/org/openstreetmap/josm/gui/datatransfer/PrimitiveTransferable.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/SaveLayersDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/AbstractTileSourceLayer.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/NoteLayer.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/WMSLayer.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/geoimage/CorrelateGpxWithImages.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/geoimage/GeoImageLayer.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/gpx/DownloadWmsAlongTrackAction.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/gpx/GpxDrawHelper.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/markerlayer/MarkerLayer.java (modified) * trunk/src/org/openstreetmap/josm/gui/preferences/imagery/AddWMSLayerPanel.java (modified) * trunk/src/org/openstreetmap/josm/gui/preferences/projection/CodeProjectionChoice.java (modified) * trunk/src/org/openstreetmap/josm/gui/preferences/projection/ProjectionPreference.java (modified) * trunk/src/org/openstreetmap/josm/gui/preferences/projection/UTMProjectionChoice.java (modified) * trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/Check.java (modified) * trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/ComboMultiSelect.java (modified) * trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/Text.java (modified) * trunk/src/org/openstreetmap/josm/gui/widgets/NativeFileChooser.java (modified) * trunk/src/org/openstreetmap/josm/tools/template_engine/TemplateParser.java (modified) * trunk/tools/pmd/josm-ruleset.xml (modified) enable PMD rule `OptimizableToArrayCall` Sat, 16 Dec 2017 23:26:08 GMT Don-vip [13205] * trunk/src/org/openstreetmap/josm/data/osm/Filter.java (modified) * trunk/tools/pmd/josm-ruleset.xml (modified) enable PMD rule `StringToString` Sat, 16 Dec 2017 23:17:20 GMT Don-vip [13204] * trunk/src/org/openstreetmap/josm/data/cache/JCSCacheManager.java (modified) * trunk/src/org/openstreetmap/josm/data/projection/datum/NTV2Proj4DirGridShiftFileSource.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/CustomConfigurator.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/DownloadFileTask.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/importexport/NoteExporter.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/importexport/ValidatorErrorExporter.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/importexport/WMSLayerExporter.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/importexport/WMSLayerImporter.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/geoimage/CorrelateGpxWithImages.java (modified) * trunk/src/org/openstreetmap/josm/gui/mappaint/RenderingCLI.java (modified) * trunk/src/org/openstreetmap/josm/io/CacheCustomContent.java (modified) * trunk/src/org/openstreetmap/josm/io/CachedFile.java (modified) * trunk/src/org/openstreetmap/josm/io/Compression.java (modified) * trunk/src/org/openstreetmap/josm/io/session/SessionReader.java (modified) * trunk/src/org/openstreetmap/josm/io/session/SessionWriter.java (modified) * trunk/src/org/openstreetmap/josm/plugins/PluginInformation.java (modified) * trunk/src/org/openstreetmap/josm/plugins/ReadLocalPluginInformationTask.java (modified) * trunk/src/org/openstreetmap/josm/tools/I18n.java (modified) * trunk/src/org/openstreetmap/josm/tools/PlatformHookUnixoid.java (modified) * trunk/src/org/openstreetmap/josm/tools/PlatformHookWindows.java (modified) * trunk/src/org/openstreetmap/josm/tools/RightAndLefthandTraffic.java (modified) * trunk/tools/pmd/josm-ruleset.xml (modified) enable new PMD rule `AvoidFileStream` - see ... Sat, 16 Dec 2017 20:06:42 GMT Don-vip [13202] * trunk/build.xml (modified) * trunk/src/org/openstreetmap/josm/gui/history/HistoryBrowserModel.java (modified) * trunk/src/org/openstreetmap/josm/tools/HiDPISupport.java (modified) * trunk/tools/pmd (modified) * trunk/tools/pmd/asm-5.0.4.jar (deleted) * trunk/tools/pmd/asm-6.0.jar (added) * trunk/tools/pmd/commons-lang3-3.4.jar (deleted) * trunk/tools/pmd/commons-lang3-3.7.jar (added) * trunk/tools/pmd/designer.bat (modified) * trunk/tools/pmd/josm-ruleset.xml (modified) * trunk/tools/pmd/pmd-core-5.8.1.jar (deleted) * trunk/tools/pmd/pmd-core-6.0.0.jar (added) * trunk/tools/pmd/pmd-java-5.8.1.jar (deleted) * trunk/tools/pmd/pmd-java-6.0.0.jar (added) * trunk/tools/pmd/saxon-9.1.0.8-dom.jar (added) * trunk/tools/pmd/saxon-9.1.0.8.jar (added) update to PMD 6.0.0 Tue, 19 Sep 2017 15:04:52 GMT Don-vip [12877] * trunk/tools/pmd/josm-ruleset.xml (modified) see #15315 - disable `AvoidCatchingNPE` Sun, 30 Jul 2017 15:07:42 GMT Don-vip [12542] * trunk/src/org/openstreetmap/josm/actions/ExpertToggleAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/ExtensionFileFilter.java (modified) * trunk/src/org/openstreetmap/josm/actions/OrthogonalizeAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/search/SearchAction.java (modified) * trunk/src/org/openstreetmap/josm/data/SystemOfMeasurement.java (modified) * trunk/src/org/openstreetmap/josm/data/cache/JCSCachedTileLoaderJob.java (modified) * trunk/src/org/openstreetmap/josm/data/imagery/TMSCachedTileLoaderJob.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/AbstractPrimitive.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/DataSet.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/OsmValidator.java (modified) * trunk/src/org/openstreetmap/josm/gui/DefaultNameFormatter.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/UploadDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresets.java (modified) * trunk/src/org/openstreetmap/josm/io/OverpassDownloadReader.java (modified) * trunk/src/org/openstreetmap/josm/io/remotecontrol/AddTagsDialog.java (modified) * trunk/src/org/openstreetmap/josm/io/session/SessionReader.java (modified) * trunk/tools/pmd/josm-ruleset.xml (modified) partial revert of r12537 Sat, 29 Jul 2017 23:00:55 GMT Don-vip [12539] * trunk/src/org/openstreetmap/josm/data/imagery/TMSCachedTileLoader.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/StyledMapRenderer.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/tests/InternetTags.java (modified) * trunk/src/org/openstreetmap/josm/gui/mappaint/styleelement/StyleElement.java (modified) * trunk/tools/pmd/josm-ruleset.xml (modified) PMD - enable naming rules Wed, 17 May 2017 00:57:03 GMT Don-vip [12199] * trunk/src/org/openstreetmap/josm/data/gpx/WayPoint.java (modified) * trunk/src/org/openstreetmap/josm/data/preferences/AbstractProperty.java (modified) * trunk/tools/pmd/josm-ruleset.xml (modified) checkstyle/PMD/findbugs Sun, 16 Apr 2017 13:13:44 GMT Don-vip [11930] * trunk/src/org/openstreetmap/josm/data/validation/routines/InetAddressValidator.java (modified) * trunk/tools/pmd/josm-ruleset.xml (modified) PMD - enable subset of optimizations rules Sun, 16 Apr 2017 12:50:24 GMT Don-vip [11929] * trunk/src/org/openstreetmap/josm/tools/template_engine/TemplateParser.java (modified) * trunk/tools/pmd/josm-ruleset.xml (modified) PMD - disable "InefficientEmptyStringCheck" Sun, 19 Mar 2017 01:26:34 GMT Don-vip [11746] * trunk/src/org/openstreetmap/josm/actions/JoinAreasAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/SessionLoadAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/ShowStatusReportAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/audio/AudioBackAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/audio/AudioFastSlowAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/audio/AudioFwdAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/audio/AudioPlayPauseAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/downloadtasks/DownloadOsmChangeTask.java (modified) * trunk/src/org/openstreetmap/josm/data/AutosaveTask.java (modified) * trunk/src/org/openstreetmap/josm/data/Preferences.java (modified) * trunk/src/org/openstreetmap/josm/data/cache/JCSCacheManager.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/DatasetConsistencyTest.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/StyledMapRenderer.java (modified) * trunk/src/org/openstreetmap/josm/data/preferences/PreferencesWriter.java (modified) * trunk/src/org/openstreetmap/josm/data/projection/CustomProjection.java (modified) * trunk/src/org/openstreetmap/josm/data/projection/Projections.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/OsmValidator.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/tests/TagChecker.java (modified) * trunk/src/org/openstreetmap/josm/gui/JosmUserIdentityManager.java (modified) * trunk/src/org/openstreetmap/josm/gui/MapStatus.java (modified) * trunk/src/org/openstreetmap/josm/gui/MapView.java (modified) * trunk/src/org/openstreetmap/josm/gui/MapViewState.java (modified) * trunk/src/org/openstreetmap/josm/gui/PleaseWaitRunnable.java (modified) * trunk/src/org/openstreetmap/josm/gui/datatransfer/AbstractStackTransferHandler.java (modified) * trunk/src/org/openstreetmap/josm/gui/datatransfer/ClipboardUtils.java (modified) * trunk/src/org/openstreetmap/josm/gui/datatransfer/OsmTransferHandler.java (modified) * trunk/src/org/openstreetmap/josm/gui/datatransfer/importers/PrimitiveDataPaster.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/DialogsPanel.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetContentPanel.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/relation/MemberTableModel.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/relation/sort/WayConnectionTypeCalculator.java (modified) * trunk/src/org/openstreetmap/josm/gui/history/HistoryBrowserDialogManager.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/SaveLayerTask.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/LayerManager.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/geoimage/CorrelateGpxWithImages.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/geoimage/ImageEntry.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/imagery/TileSourceDisplaySettings.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/markerlayer/AudioMarker.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/markerlayer/PlayHeadMarker.java (modified) * trunk/src/org/openstreetmap/josm/gui/preferences/PreferenceTabbedPane.java (modified) * trunk/src/org/openstreetmap/josm/gui/preferences/map/MapPaintPreference.java (modified) * trunk/src/org/openstreetmap/josm/gui/progress/PleaseWaitProgressMonitor.java (modified) * trunk/src/org/openstreetmap/josm/gui/tagging/ac/AutoCompletionManager.java (modified) * trunk/src/org/openstreetmap/josm/gui/util/GuiHelper.java (modified) * trunk/src/org/openstreetmap/josm/gui/widgets/JosmPasswordField.java (modified) * trunk/src/org/openstreetmap/josm/io/BoundingBoxDownloader.java (modified) * trunk/src/org/openstreetmap/josm/io/NameFinder.java (modified) * trunk/src/org/openstreetmap/josm/io/NmeaReader.java (modified) * trunk/src/org/openstreetmap/josm/io/remotecontrol/handler/ImportHandler.java (modified) * trunk/src/org/openstreetmap/josm/io/remotecontrol/handler/LoadAndZoomHandler.java (modified) * trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java (modified) * trunk/src/org/openstreetmap/josm/tools/AudioPlayer.java (modified) * trunk/src/org/openstreetmap/josm/tools/OsmUrlToBounds.java (modified) * trunk/src/org/openstreetmap/josm/tools/WindowGeometry.java (modified) * trunk/src/org/openstreetmap/josm/tools/bugreport/BugReport.java (modified) * trunk/src/org/openstreetmap/josm/tools/bugreport/BugReportDialog.java (modified) * trunk/src/org/openstreetmap/josm/tools/bugreport/ReportedException.java (modified) * trunk/tools/pmd/josm-ruleset.xml (modified) PMD - Strict Exceptions Fri, 17 Mar 2017 22:03:26 GMT Don-vip [11739] * trunk/src/org/openstreetmap/josm/actions/MergeLayerAction.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/tests/MultipolygonTest.java (modified) * trunk/src/org/openstreetmap/josm/gui/JosmUserIdentityManager.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/geoimage/CorrelateGpxWithImages.java (modified) * trunk/src/org/openstreetmap/josm/tools/bugreport/ReportedException.java (modified) * trunk/tools/pmd/josm-ruleset.xml (modified) enable more PMD rules Fri, 10 Mar 2017 01:28:00 GMT Don-vip [11713] * trunk (modified) * trunk/build.xml (modified) * trunk/src/org/openstreetmap/josm/Main.java (modified) * trunk/src/org/openstreetmap/josm/actions/AutoScaleAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/ImageryAdjustAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/LassoModeAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/mapmode/AddNoteAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/mapmode/DeleteAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/mapmode/DrawAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/mapmode/ExtrudeAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/mapmode/ImproveWayAccuracyAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/mapmode/MapMode.java (modified) * trunk/src/org/openstreetmap/josm/actions/mapmode/ParallelWayAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/mapmode/PlayHeadDragMode.java (modified) * trunk/src/org/openstreetmap/josm/actions/mapmode/SelectAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/mapmode/ZoomAction.java (modified) * trunk/src/org/openstreetmap/josm/gui/MainApplication.java (modified) * trunk/src/org/openstreetmap/josm/gui/MainFrame.java (modified) * trunk/src/org/openstreetmap/josm/gui/MainPanel.java (modified) * trunk/src/org/openstreetmap/josm/gui/MapFrame.java (modified) * trunk/src/org/openstreetmap/josm/gui/MapMover.java (modified) * trunk/src/org/openstreetmap/josm/gui/MapView.java (modified) * trunk/src/org/openstreetmap/josm/gui/datatransfer/importers/OsmLinkPaster.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/NotesDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/ValidatorDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetCacheManager.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/GpxLayer.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/MapViewPaintable.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/gpx/GpxDrawHelper.java (modified) * trunk/src/org/openstreetmap/josm/gui/mappaint/mapcss/Condition.java (modified) * trunk/src/org/openstreetmap/josm/gui/mappaint/mapcss/ExpressionFactory.java (modified) * trunk/src/org/openstreetmap/josm/gui/mappaint/mapcss/MapCSSParser.jj (modified) * trunk/src/org/openstreetmap/josm/gui/preferences/display/LafPreference.java (modified) * trunk/src/org/openstreetmap/josm/gui/progress/ProgressMonitor.java (modified) * trunk/test/unit/org/openstreetmap/josm/actions/mapmode/AddNoteActionTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/actions/mapmode/DeleteActionTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/actions/mapmode/ExtrudeActionTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/actions/mapmode/ImproveWayAccuracyActionTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/actions/mapmode/MapViewMock.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/layer/gpx/GpxDrawHelperTest.java (modified) * trunk/tools/pmd (added) * trunk/tools/pmd/asm-5.0.4.jar (added) * trunk/tools/pmd/commons-io-2.4.jar (added) * trunk/tools/pmd/commons-lang3-3.4.jar (added) * trunk/tools/pmd/designer.bat (added) * trunk/tools/pmd/jaxen-1.1.6.jar (added) * trunk/tools/pmd/josm-ruleset.xml (added) * trunk/tools/pmd/pmd-core-5.5.4.jar (added) * trunk/tools/pmd/pmd-java-5.5.4.jar (added) add Ant target to run PMD (only few rules for now), fix violations