Changeset 9996 in josm for trunk/src/org/openstreetmap

Timestamp:

2016-03-14T23:06:43+01:00 (9 years ago)

Author:

Don-vip

Message:

sonar - use JLabel.setLabelFor where applicable + add/update unit tests

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• MapFrame.java (modified) (2 diffs)
• conflict/pair/properties/PropertiesMerger.java (modified) (3 diffs)
• dialogs/MapPaintDialog.java (modified) (4 diffs)
• io/UploadAndSaveProgressRenderer.java (modified) (3 diffs)
• io/UploadParameterSummaryPanel.java (modified) (1 diff)
• tagging/presets/items/ComboMultiSelect.java (modified) (1 diff)
• tagging/presets/items/Text.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/MapFrame.java

@@ -137 +137 @@
     public SelectionListDialog selectionListDialog;
     public PropertiesDialog propertiesDialog;
+    public MapPaintDialog mapPaintDialog;
     public NotesDialog noteDialog;
 
@@ -246 +247 @@
         addToggleDialog(filterDialog = new FilterDialog());
         addToggleDialog(new ChangesetDialog(), true);
-        addToggleDialog(new MapPaintDialog());
+        addToggleDialog(mapPaintDialog = new MapPaintDialog());
         addToggleDialog(noteDialog = new NotesDialog());
         toolBarToggle.setFloatable(false);

trunk/src/org/openstreetmap/josm/gui/conflict/pair/properties/PropertiesMerger.java

@@ -84 +84 @@
         JLabel lblMyVersion = new JLabel(tr("My version"));
         lblMyVersion.setToolTipText(tr("Properties in my dataset, i.e. the local dataset"));
+        lblMyVersion.setLabelFor(mineVersionInfo);
         add(lblMyVersion, gc);
 
@@ -95 +96 @@
         JLabel lblTheirVersion = new JLabel(tr("Their version"));
         lblTheirVersion.setToolTipText(tr("Properties in their dataset, i.e. the server dataset"));
+        lblMyVersion.setLabelFor(theirVersionInfo);
         add(lblTheirVersion, gc);
 
@@ -106 +108 @@
         gc.gridx = 5;
         add(theirVersionInfo, gc);
-
     }
 

trunk/src/org/openstreetmap/josm/gui/dialogs/MapPaintDialog.java

@@ -572 +572 @@
             final JTabbedPane tabs = new JTabbedPane();
 
-            tabs.add("Info", buildInfoPanel(s));
             JLabel lblInfo = new JLabel(tr("Info"));
+            lblInfo.setLabelFor(tabs.add("Info", buildInfoPanel(s)));
             lblInfo.setFont(lblInfo.getFont().deriveFont(Font.PLAIN));
             tabs.setTabComponentAt(0, lblInfo);
@@ -583 +583 @@
 
             final JPanel pSource = new JPanel(new GridBagLayout());
-            tabs.addTab("Source", pSource);
             JLabel lblSource = new JLabel(tr("Source"));
+            lblSource.setLabelFor(tabs.add("Source", pSource));
             lblSource.setFont(lblSource.getFont().deriveFont(Font.PLAIN));
             tabs.setTabComponentAt(3, lblSource);
@@ -615 +615 @@
             if (items.isEmpty()) {
                 JLabel lblErrors = new JLabel(tr(title));
+                lblErrors.setLabelFor(pErrors);
                 lblErrors.setFont(lblInfo.getFont().deriveFont(Font.PLAIN));
                 lblErrors.setEnabled(false);
@@ -621 +622 @@
             } else {
                 JLabel lblErrors = new JLabel(tr(title), icon, JLabel.HORIZONTAL);
+                lblErrors.setLabelFor(pErrors);
                 tabs.setTabComponentAt(pos, lblErrors);
             }

trunk/src/org/openstreetmap/josm/gui/io/UploadAndSaveProgressRenderer.java

@@ -17 +17 @@
 class UploadAndSaveProgressRenderer extends JPanel implements ProgressRenderer, PropertyChangeListener {
 
-    private JLabel lblTaskTitle;
-    private JLabel lblCustomText;
-    private JProgressBar progressBar;
+    private final JLabel lblTaskTitle = new JLabel("");
+    private final JLabel lblCustomText = new JLabel("");
+    private final JProgressBar progressBar = new JProgressBar(JProgressBar.HORIZONTAL);
 
     /**
@@ -39 +39 @@
         gc.weighty = 0.0;
         gc.insets = new Insets(5, 0, 0, 5);
-        add(lblTaskTitle = new JLabel(""), gc);
+        add(lblTaskTitle, gc);
+        lblTaskTitle.setLabelFor(lblCustomText);
 
-        gc.gridx = 0;
         gc.gridy = 1;
-        gc.fill = GridBagConstraints.HORIZONTAL;
-        gc.weightx = 1.0;
-        gc.weighty = 0.0;
-        gc.insets = new Insets(5, 0, 0, 5);
-        add(lblCustomText = new JLabel(""), gc);
+        add(lblCustomText, gc);
+        lblCustomText.setLabelFor(progressBar);
 
-        gc.gridx = 0;
         gc.gridy = 2;
-        gc.fill = GridBagConstraints.HORIZONTAL;
-        gc.weightx = 1.0;
-        gc.weighty = 0.0;
-        gc.insets = new Insets(5, 0, 0, 5);
-        add(progressBar = new JProgressBar(JProgressBar.HORIZONTAL), gc);
+        add(progressBar, gc);
     }
 
@@ -91 +83 @@
     public void propertyChange(PropertyChangeEvent evt) {
         if (evt.getPropertyName().equals(SaveLayersModel.MODE_PROP)) {
-            Mode mode = (Mode) evt.getNewValue();
-            switch(mode) {
-                case EDITING_DATA: setVisible(false); break;
-                case UPLOADING_AND_SAVING: setVisible(true); break;
-            }
+            setVisible(Mode.UPLOADING_AND_SAVING.equals(evt.getNewValue()));
         }
         getParent().validate();

trunk/src/org/openstreetmap/josm/gui/io/UploadParameterSummaryPanel.java

@@ -118 +118 @@
         lblWarning = new JLabel("");
         lblWarning.setVisible(false);
+        lblWarning.setLabelFor(jepMessage);
         lblWarning.setIcon(ImageProvider.get("warning-small"));
         lblWarning.setBorder(BorderFactory.createEmptyBorder(5, 5, 5, 5));

trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/ComboMultiSelect.java

@@ -388 +388 @@
         p.add(label, GBC.std().insets(0, 0, 10, 0));
         addToPanelAnchor(p, default_, presetInitiallyMatches);
+        label.setLabelFor(component);
         component.setToolTipText(getKeyTooltipText());
 
         return true;
-
     }
 

trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/Text.java

@@ -180 +180 @@
         final JLabel label = new JLabel(locale_text + ':');
         label.setToolTipText(getKeyTooltipText());
+        label.setLabelFor(value);
         p.add(label, GBC.std().insets(0, 0, 10, 0));
         p.add(value, GBC.eol().fill(GBC.HORIZONTAL));