Changeset 9835 in josm for trunk

Timestamp:

2016-02-19T18:24:58+01:00 (9 years ago)

Author:

Klumbumbus

Message:

fix #12500 - deprecate sport=skating in favor of sport=ice_skating and sport=roller_skating; roller_skating icon see [o32077]

Location:

trunk

Files:

• data/defaultpresets.xml (modified) (3 diffs)
• data/validator/deprecated.mapcss (modified) (1 diff)
• styles/standard/elemstyles.mapcss (modified) (2 diffs)

trunk/data/defaultpresets.xml

@@ -187 +187 @@
     </chunk>
     <chunk id="sport">
-            <combo key="sport" text="Sport" values="multi,archery,athletics,american_football,australian_football,baseball,basketball,beachvolleyball,billiards,boules,bowls,canadian_football,canoe,climbing,cricket,croquet,cycling,dog_racing,equestrian,field_hockey,gaelic_games,golf,gymnastics,handball,horse_racing,ice_hockey,karting,model_aerodrome,motocross,motor,pelota,racquet,rc_car,rugby_league,rugby_union,running,safety_training,shooting,skateboard,skating,soccer,swimming,table_tennis,tennis,volleyball,9pin,10pin" values_context="sport" />
+            <combo key="sport" text="Sport" values="multi,archery,athletics,american_football,australian_football,baseball,basketball,beachvolleyball,billiards,boules,bowls,canadian_football,canoe,climbing,cricket,croquet,cycling,dog_racing,equestrian,field_hockey,gaelic_games,golf,gymnastics,handball,horse_racing,ice_hockey,karting,model_aerodrome,motocross,motor,pelota,racquet,rc_car,rugby_league,rugby_union,running,safety_training,shooting,skateboard,ice_skating,roller_skating,soccer,swimming,table_tennis,tennis,volleyball,9pin,10pin" values_context="sport" />
     </chunk>
     <chunk id="fee">
@@ -5396 +5396 @@
             <key key="leisure" value="track" />
             <text key="name" text="Name" />
-            <combo key="sport" text="Sport" values="athletics,cycling,dog_racing,equestrian,horse_racing,running,skating" values_context="sport" />
+            <combo key="sport" text="Sport" values="athletics,cycling,dog_racing,equestrian,horse_racing,running,roller_skating,ice_skating" values_context="sport" />
         </item> <!-- Racetrack -->
         <group name="Golf" icon="styles/standard/sport/golf/golf.svg">
@@ -5635 +5635 @@
             <combo key="leisure" text="Type" values="pitch,sports_centre,stadium" />
         </item> <!-- Gymnastics -->
-        <item name="Skating" icon="presets/skating.png" type="node,closedway,multipolygon" preset_name_label="true">
-            <link href="http://wiki.openstreetmap.org/wiki/Tag:sport=skating"
-                  uk.href="http://wiki.openstreetmap.org/wiki/Uk:Tag:sport=skating" />
-            <space />
-            <key key="sport" value="skating" />
+        <item name="Ice Skating" icon="presets/skating.png" type="node,closedway,multipolygon" preset_name_label="true">
+            <link href="http://wiki.openstreetmap.org/wiki/Tag:sport=ice_skating" />
+            <space />
+            <key key="sport" value="ice_skating" />
             <text key="name" text="Name" />
             <combo key="leisure" text="Type" values="ice_rink,pitch,sports_centre,stadium" default="ice_rink" />
-        </item> <!-- Skating -->
+        </item> <!-- Ice Skating -->
+        <item name="Roller Skating" icon="styles/standard/sport/roller_skating.svg" type="node,closedway,multipolygon" preset_name_label="true">
+            <link href="http://wiki.openstreetmap.org/wiki/Tag:sport=roller_skating"/>
+            <space />
+            <key key="sport" value="roller_skating" />
+            <text key="name" text="Name" />
+            <combo key="leisure" text="Type" values="pitch,sports_centre,stadium" />
+        </item> <!-- Roller Skating -->
         <item name="Skateboard" icon="styles/standard/sport/skateboard.png" type="node,closedway,multipolygon" preset_name_label="true">
             <link href="http://wiki.openstreetmap.org/wiki/Tag:sport=skateboard"

trunk/data/validator/deprecated.mapcss

@@ -792 +792 @@
   throwWarning: tr("questionable key (ending with a number): {0}", "{0.key}");
 }
+
+/* #12500 */
+*[sport=skating] {
+  throwWarning: tr("{0} is deprecated", "{0.tag}");
+  suggestAlternative: "sport=ice_skating";
+  suggestAlternative: "sport=roller_skating";
+}

trunk/styles/standard/elemstyles.mapcss

@@ -4301 +4301 @@
 area[sport=pelota],
 area[sport=racquet],
-area[sport=skating],
+area[sport=ice_skating],
+area[sport=roller_skating],
 area[sport=skateboard] {
     fill-color: sport#bde3cb;
@@ -4320 +4321 @@
     text: auto;
 }
+node[sport=ice_skating] {
+    icon-image: "sport/skating.png";
+    set icon_z17;
+    text: auto;
+}
+node[sport=roller_skating] {
+    icon-image: "sport/roller_skating.svg";
+    set icon_z17;
+    text: auto;
+}
 node[sport=skating] {
-    icon-image: "sport/skating.png";
+    icon-image: "misc/deprecated.png";
     set icon_z17;
     text: auto;