Changeset 9786 in josm

Timestamp:

2016-02-11T23:37:07+01:00 (9 years ago)

Author:

bastiK

Message:

new mappaint performance test
tests different features separately

Location:

trunk

Files:

• src/org/openstreetmap/josm/data/osm/visitor/paint/StyledMapRenderer.java (modified) (6 diffs)
• src/org/openstreetmap/josm/gui/mappaint/StyleSetting.java (modified) (2 diffs)
• test/data/styles/filter.mapcss (added)
• test/performance/org/openstreetmap/josm/PerformanceTestUtils.java (modified) (4 diffs)
• test/performance/org/openstreetmap/josm/gui/mappaint/MapRendererPerformanceTest.java (added)

trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/StyledMapRenderer.java

@@ -33 +33 @@
 import java.util.List;
 import java.util.Map;
+import java.util.Map.Entry;
 import java.util.concurrent.ForkJoinPool;
 import java.util.concurrent.ForkJoinTask;
@@ -237 +238 @@
     }
 
+    /**
+     * Saves benchmark data for tests.
+     */
+    public static class BenchmarkData {
+        public long generateTime;
+        public long sortTime;
+        public long drawTime;
+        public Map<Class<? extends StyleElement>, Integer> styleElementCount;
+        public boolean skipDraw;
+
+        private void recordElementStats(List<StyleRecord> srs) {
+            styleElementCount = new HashMap<>();
+            for (StyleRecord r : srs) {
+                Class<? extends StyleElement> klass = r.style.getClass();
+                Integer count = styleElementCount.get(klass);
+                if (count == null) {
+                    count = 0;
+                }
+                styleElementCount.put(klass, count + 1);
+            }
+
+        }
+    }
+    /* can be set by tests, if detailed benchmark data is requested */
+    public BenchmarkData benchmarkData = null;
+
     private static Map<Font, Boolean> IS_GLYPH_VECTOR_DOUBLE_TRANSLATION_BUG = new HashMap<>();
 
@@ -1868 +1895 @@
         BBox bbox = bounds.toBBox();
         getSettings(renderVirtualNodes);
-        boolean benchmark = Main.isTraceEnabled() || Main.pref.getBoolean("mappaint.render.benchmark", false);
+        boolean benchmarkOutput = Main.isTraceEnabled() || Main.pref.getBoolean("mappaint.render.benchmark", false);
+        boolean benchmark = benchmarkOutput || benchmarkData != null;
 
         data.getReadLock().lock();
@@ -1874 +1902 @@
             highlightWaySegments = data.getHighlightedWaySegments();
 
-            long timeStart = 0, timePhase1 = 0, timeFinished;
+            long timeStart = 0, timeGenerateDone = 0, timeSortingDone = 0, timeFinished;
             if (benchmark) {
                 timeStart = System.currentTimeMillis();
@@ -1897 +1925 @@
 
             if (benchmark) {
-                timePhase1 = System.currentTimeMillis();
-                System.err.print("phase 1 (calculate styles): " + Utils.getDurationString(timePhase1 - timeStart));
+                timeGenerateDone = System.currentTimeMillis();
+                if (benchmarkOutput) {
+                    System.err.print("phase 1 (calculate styles): " + Utils.getDurationString(timeGenerateDone - timeStart));
+                }
+                if (benchmarkData != null) {
+                    benchmarkData.generateTime = timeGenerateDone - timeStart;
+                }
             }
 
             Collections.sort(allStyleElems); // TODO: try parallel sort when switching to Java 8
+
+            if (benchmarkData != null) {
+                timeSortingDone = System.currentTimeMillis();
+                benchmarkData.sortTime = timeSortingDone - timeGenerateDone;
+                if (benchmarkData.skipDraw) {
+                    benchmarkData.recordElementStats(allStyleElems);
+                    return;
+                }
+            }
 
             for (StyleRecord r : allStyleElems) {
@@ -1916 +1958 @@
             if (benchmark) {
                 timeFinished = System.currentTimeMillis();
-                System.err.println("; phase 2 (draw): " + Utils.getDurationString(timeFinished - timePhase1) +
-                    "; total: " + Utils.getDurationString(timeFinished - timeStart) +
-                    " (scale: " + circum + " zoom level: " + Selector.GeneralSelector.scale2level(circum) + ')');
+                if (benchmarkData != null) {
+                    benchmarkData.drawTime = timeFinished - timeGenerateDone;
+                    benchmarkData.recordElementStats(allStyleElems);
+                }
+                if (benchmarkOutput) {
+                    System.err.println("; phase 2 (draw): " + Utils.getDurationString(timeFinished - timeGenerateDone) +
+                        "; total: " + Utils.getDurationString(timeFinished - timeStart) +
+                        " (scale: " + circum + " zoom level: " + Selector.GeneralSelector.scale2level(circum) + ')');
+                }
             }
 

trunk/src/org/openstreetmap/josm/gui/mappaint/StyleSetting.java

@@ -60 +60 @@
                 @Override
                 public void actionPerformed(ActionEvent e) {
-                    boolean b = item.isSelected();
-                    if (b == def) {
-                        Main.pref.put(prefKey, null);
-                    } else {
-                        Main.pref.put(prefKey, b);
-                    }
+                    setValue(item.isSelected());
                     Main.worker.submit(new MapPaintStyles.MapPaintStyleLoader(Arrays.asList(parentStyle)));
                 }
@@ -95 +90 @@
             return Boolean.valueOf(val);
         }
+
+        public void setValue(Object o) {
+            if (o == null || !(o instanceof Boolean)) {
+                throw new IllegalArgumentException();
+            }
+            boolean b = (Boolean) o;
+            if (b == def) {
+                Main.pref.put(prefKey, null);
+            } else {
+                Main.pref.put(prefKey, b);
+            }
+        }
     }
 }

trunk/test/performance/org/openstreetmap/josm/PerformanceTestUtils.java

@@ -3 +3 @@
 
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+
+import org.openstreetmap.josm.io.XmlWriter;
 
 /**
@@ -14 +16 @@
      */
     public static class PerformanceTestTimer {
-        private String name;
-        private long time;
+        private final String name;
+        private final long time;
         private boolean measurementPlotsPlugin = false;
 
@@ -37 +39 @@
             long dTime = (System.nanoTime() - time) / 1000000;
             if (measurementPlotsPlugin) {
-                System.out.println(String.format("<measurement><name>%s (ms)</name><value>%.1f</value></measurement>", name, (double) dTime));
+                measurementPlotsPluginOutput(name + "(ms)", dTime);
             } else {
                 System.out.println("TIMER " + name + ": " + dTime + "ms");
@@ -58 +60 @@
         return new PerformanceTestTimer(name);
     }
+
+    /**
+     * Emit one data value for the Jenkins Measurement Plots Plugin.
+     * 
+     * The plugin collects the values over multiple builds and plots them in a diagram.
+     * 
+     * @see https://wiki.jenkins-ci.org/display/JENKINS/Measurement+Plots+Plugin
+     * @param name the name / title of the measurement
+     * @param value the value
+     */
+    public static void measurementPlotsPluginOutput(String name, double value) {
+        System.out.println("<measurement><name>"+XmlWriter.encode(name)+"</name><value>"+value+"</value></measurement>");
+    }
 }