Changeset 9606 in josm for trunk/src/org/openstreetmap

Timestamp:

2016-01-24T03:50:35+01:00 (9 years ago)

Author:

Don-vip

Message:

add more unit tests

Location:

trunk/src/org/openstreetmap/josm/gui/download

Files:

• BookmarkSelection.java (modified) (2 diffs)
• BoundingBoxSelection.java (modified) (1 diff)
• PlaceSelection.java (modified) (7 diffs)
• TileSelection.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/download/BookmarkSelection.java

@@ -105 +105 @@
     public void addGui(final DownloadDialog gui) {
         JPanel dlg = new JPanel(new GridBagLayout());
-        gui.addDownloadAreaSelector(dlg, tr("Bookmarks"));
+        if (gui != null)
+            gui.addDownloadAreaSelector(dlg, tr("Bookmarks"));
         GridBagConstraints gc = new GridBagConstraints();
 
@@ -113 +114 @@
             public void valueChanged(ListSelectionEvent e) {
                 Bookmark b = bookmarks.getSelectedValue();
-                if (b != null) {
+                if (b != null && gui != null) {
                     gui.boundingBoxChanged(b.getArea(), BookmarkSelection.this);
                 }

trunk/src/org/openstreetmap/josm/gui/download/BoundingBoxSelection.java

@@ -121 +121 @@
         showUrl.addFocusListener(new SelectAllOnFocusHandler(showUrl));
 
-        gui.addDownloadAreaSelector(dlg, tr("Bounding Box"));
+        if (gui != null)
+            gui.addDownloadAreaSelector(dlg, tr("Bounding Box"));
         this.parent = gui;
     }

trunk/src/org/openstreetmap/josm/gui/download/PlaceSelection.java

@@ -62 +62 @@
 import org.xml.sax.helpers.DefaultHandler;
 
+/**
+ * Place selector.
+ * @since 1329
+ */
 public class PlaceSelection implements DownloadSelection {
     private static final String HISTORY_KEY = "download.places.history";
@@ -145 +149 @@
         panel.add(scrollPane, BorderLayout.CENTER);
 
-        gui.addDownloadAreaSelector(panel, tr("Areas around places"));
+        if (gui != null)
+            gui.addDownloadAreaSelector(panel, tr("Areas around places"));
 
         scrollPane.setPreferredSize(scrollPane.getPreferredSize());
@@ -151 +156 @@
         tblSearchResults.getSelectionModel().addListSelectionListener(new ListSelectionHandler());
         tblSearchResults.addMouseListener(new MouseAdapter() {
-            @Override public void mouseClicked(MouseEvent e) {
+            @Override
+            public void mouseClicked(MouseEvent e) {
                 if (e.getClickCount() > 1) {
                     SearchResult sr = model.getSelectedSearchResult();
-                    if (sr == null) return;
-                    parent.startDownload(sr.getDownloadArea());
+                    if (sr != null) {
+                        parent.startDownload(sr.getDownloadArea());
+                    }
                 }
             }
@@ -410 +417 @@
         @Override
         public int getRowCount() {
-            if (data == null) return 0;
-            return data.size();
+            return data != null ? data.size() : 0;
         }
 
         @Override
         public Object getValueAt(int row, int column) {
-            if (data == null) return null;
-            return data.get(row);
+            return data != null ? data.get(row) : null;
         }
 
@@ -444 +449 @@
         private TableColumn col3;
         private TableColumn col4;
+
+        NamedResultTableColumnModel() {
+            createColumns();
+        }
+
         protected final void createColumns() {
-            TableColumn col = null;
+            TableColumn col;
             NamedResultCellRenderer renderer = new NamedResultCellRenderer();
 
@@ -485 +495 @@
             col4.setHeaderValue(fourth);
             fireColumnMarginChanged();
-        }
-
-        NamedResultTableColumnModel() {
-            createColumns();
         }
     }
@@ -555 +561 @@
             renderColor(isSelected);
 
-            if (value == null) return this;
+            if (value == null)
+                return this;
             SearchResult sr = (SearchResult) value;
             switch(column) {

trunk/src/org/openstreetmap/josm/gui/download/TileSelection.java

@@ -37 +37 @@
     @Override
     public void addGui(final DownloadDialog gui) {
-        gui.addDownloadAreaSelector(chooser, tr("Tile Numbers"));
+        if (gui != null)
+            gui.addDownloadAreaSelector(chooser, tr("Tile Numbers"));
         parent = gui;
     }