Changeset 9510 in josm for trunk/src/org/openstreetmap

Timestamp:

2016-01-17T20:09:12+01:00 (9 years ago)

Author:

bastiK

Message:

applied #12391 - saving renamed layer replaces name (patch by kolesar + cosmetic changes)

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/RenameLayerAction.java (modified) (2 diffs)
• actions/SaveActionBase.java (modified) (1 diff)
• gui/dialogs/LayerListDialog.java (modified) (1 diff)
• gui/layer/Layer.java (modified) (8 diffs)

trunk/src/org/openstreetmap/josm/actions/RenameLayerAction.java

@@ -86 +86 @@
                 if (Main.platform.rename(file, newFile)) {
                     layer.setAssociatedFile(newFile);
-                    nameText = newFile.getName();
+                    if (!layer.isRenamed()) {
+                        nameText = newFile.getName();
+                    }
                 } else {
                     JOptionPane.showMessageDialog(
@@ -98 +100 @@
             }
         }
-        layer.setName(nameText);
+        layer.rename(nameText);
         Main.parent.repaint();
     }

trunk/src/org/openstreetmap/josm/actions/SaveActionBase.java

@@ -93 +93 @@
                 return false;
             }
-            layer.setName(file.getName());
+            if (!layer.isRenamed()) {
+                layer.setName(file.getName());
+            }
             layer.setAssociatedFile(file);
             if (layer instanceof OsmDataLayer) {

trunk/src/org/openstreetmap/josm/gui/dialogs/LayerListDialog.java

@@ -1601 +1601 @@
                     break;
                 case 2:
-                    l.setName((String) value);
+                    l.rename((String) value);
                     break;
                 default: throw new RuntimeException();

trunk/src/org/openstreetmap/josm/gui/layer/Layer.java

@@ -62 +62 @@
     /**
      * Special class that can be returned by getMenuEntries when JSeparator needs to be created
-     *
      */
     public static class SeparatorLayerAction extends AbstractAction implements LayerAction {
@@ -90 +89 @@
     public static final int ICON_SIZE = 16;
 
-    /** keeps track of property change listeners */
+    /**
+     * keeps track of property change listeners
+     */
     protected PropertyChangeSupport propertyChangeSupport;
 
     /**
      * The visibility state of the layer.
-     *
      */
     private boolean visible = true;
@@ -101 +101 @@
     /**
      * The opacity of the layer.
-     *
      */
     private double opacity = 1;
@@ -107 +106 @@
     /**
      * The layer should be handled as a background layer in automatic handling
-     *
      */
     private boolean background;
@@ -113 +111 @@
     /**
      * The name of this layer.
-     *
-     */
-    private  String name;
+     */
+    private String name;
+
+    /**
+     * This is set if user renamed this layer.
+     */
+    private boolean renamed = false;
 
     /**
@@ -264 +266 @@
      * Sets the name of the layer
      *
-     *@param name the name. If null, the name is set to the empty string.
-     *
+     * @param name the name. If null, the name is set to the empty string.
      */
     public final void setName(String name) {
@@ -276 +277 @@
             propertyChangeSupport.firePropertyChange(NAME_PROP, oldValue, this.name);
         }
+    }
+
+    /**
+     * Rename layer and set renamed flag to mark it as renamed (has user given name).
+     *
+     * @param name the name. If null, the name is set to the empty string.
+     */
+    public final void rename(String name) {
+        renamed = true;
+        setName(name);
+    }
+
+    /**
+     * Replies true if this layer was renamed by user
+     *
+     * @return true if this layer was renamed by user
+     */
+    public boolean isRenamed() {
+        return renamed;
     }
 
@@ -427 +447 @@
     /**
      * The action to save a layer
-     *
      */
     public static class LayerSaveAction extends AbstractAction {