Changeset 9450 in josm for trunk/src/org

Timestamp:

2016-01-14T19:26:02+01:00 (9 years ago)

Author:

stoecker

Message:

see #12191, only color code the changed part - possible improvement: with a bit more logic changed keys with unchanged values could be detected and added into one line instead of a replace/add pair (e.g. key-typo fixes)

File:

• trunk/src/org/openstreetmap/josm/gui/history/TagTableCellRenderer.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/gui/history/TagTableCellRenderer.java

@@ -26 +26 @@
     }
 
-    protected void setBackgroundReadable(String key, HistoryBrowserModel.TagTableModel model, boolean isSelected) {
+    protected void setBackgroundReadable(String key, HistoryBrowserModel.TagTableModel model, boolean isSelected, boolean isValue) {
         Color bgColor = UIManager.getColor("Table.background");
         if (!model.hasTag(key) && model.isCurrentPointInTime()
@@ -34 +34 @@
                 || !model.hasTag(key) && model.isReferencePointInTime()) {
             bgColor = TwoColumnDiff.Item.DiffItemType.INSERTED.getColor();
-        } else if (model.hasTag(key) && model.oppositeHasTag(key) && !model.hasSameValueAsOpposite(key)) {
+        } else if (isValue && model.hasTag(key) && model.oppositeHasTag(key) && !model.hasSameValueAsOpposite(key)) {
             bgColor = TwoColumnDiff.Item.DiffItemType.CHANGED.getColor();
         }
@@ -59 +59 @@
             setText(model.hasTag(key) ? key : "");
             setToolTipText(getText());
-            setBackgroundReadable(key, model, isSelected);
+            setBackgroundReadable(key, model, isSelected, false);
             break;
         case 1:
@@ -65 +65 @@
             setText(model.hasTag(key) ? model.getValue(key) : "");
             setToolTipText(getText());
-            setBackgroundReadable(key, model, isSelected);
+            setBackgroundReadable(key, model, isSelected, true);
             break;
         }