Changeset 9447 in josm

Timestamp:

2016-01-14T18:23:23+01:00 (9 years ago)

Author:

simon04

Message:

see #12335 - Improve "Zoom to layer" and "Zoom to download" enabled states (patch by kolesar)

File:

• trunk/src/org/openstreetmap/josm/actions/AutoScaleAction.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/actions/AutoScaleAction.java

@@ -221 +221 @@
      */
     protected Layer getFirstSelectedLayer() {
+        if (Main.main.getActiveLayer() == null) {
+            return null;
+        }
         List<Layer> layers = LayerListDialog.getInstance().getModel().getSelectedLayers();
         if (layers.isEmpty())
@@ -246 +249 @@
             break;
         case "layer":
-            if (Main.main.getActiveLayer() == null)
-                return null;
             // try to zoom to the first selected layer
             Layer l = getFirstSelectedLayer();
@@ -290 +291 @@
                 lastZoomTime = -1;
             }
-            DataSet dataset = Main.main.getCurrentDataSet();
+            final DataSet dataset = getCurrentDataSet();
             if (dataset != null) {
                 List<DataSource> dataSources = new ArrayList<>(dataset.getDataSources());
@@ -323 +324 @@
             break;
         case "layer":
-            if (!Main.isDisplayingMapView() || Main.map.mapView.getAllLayersAsList().isEmpty()) {
-                setEnabled(false);
-            } else {
-                // FIXME: should also check for whether a layer is selected in the layer list dialog
-                setEnabled(true);
-            }
+            setEnabled(getFirstSelectedLayer() != null);
             break;
         case "conflict":
             setEnabled(Main.map != null && Main.map.conflictDialog.getSelectedConflict() != null);
+            break;
+        case "download":
+            setEnabled(getCurrentDataSet() != null && !getCurrentDataSet().getDataSources().isEmpty());
             break;
         case "problem":
@@ -414 +413 @@
                 }
             }
+            updateEnabledState();
         }
     }