Changeset 9086 in josm for trunk/src/org

Timestamp:

2015-12-05T15:38:14+01:00 (9 years ago)

Author:

Don-vip

Message:

fix #12153 - Changing sorting order in Tags/Memberships window and clicking in one tag, edits the wrong tag

Location:

trunk/src/org/openstreetmap/josm/gui/dialogs/properties

Files:

• PropertiesDialog.java (modified) (14 diffs)
• TagEditHelper.java (modified) (6 diffs)

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialog.java

@@ -172 +172 @@
      * This sub-object is responsible for all adding and editing of tags
      */
-    private final transient TagEditHelper editHelper = new TagEditHelper(tagData, valueCount);
+    private final transient TagEditHelper editHelper = new TagEditHelper(tagTable, tagData, valueCount);
 
     private final transient DataSetListenerAdapter dataChangedAdapter = new DataSetListenerAdapter(this);
@@ -561 +561 @@
     }
 
-    private int findRow(TableModel model, Object value) {
+    private int findViewRow(JTable table, TableModel model, Object value) {
         for (int i = 0; i < model.getRowCount(); i++) {
             if (model.getValueAt(i, 0).equals(value))
-                return i;
+                return table.convertRowIndexToView(i);
         }
         return -1;
@@ -639 +639 @@
         selectedTag = editHelper.getChangedKey(); // select last added or last edited key by default
         if (selectedTag == null && tagTable.getSelectedRowCount() == 1) {
-            selectedTag = (String) tagData.getValueAt(tagTable.getSelectedRow(), 0);
+            selectedTag = editHelper.getDataKey(tagTable.getSelectedRow());
         }
         if (membershipTable.getSelectedRowCount() == 1) {
@@ -737 +737 @@
 
         int selectedIndex;
-        if (selectedTag != null && (selectedIndex = findRow(tagData, selectedTag)) != -1) {
+        if (selectedTag != null && (selectedIndex = findViewRow(tagTable, tagData, selectedTag)) != -1) {
             tagTable.changeSelection(selectedIndex, 0, false, false);
-        } else if (selectedRelation != null && (selectedIndex = findRow(membershipData, selectedRelation)) != -1) {
+        } else if (selectedRelation != null && (selectedIndex = findViewRow(membershipTable, membershipData, selectedRelation)) != -1) {
             membershipTable.changeSelection(selectedIndex, 0, false, false);
         } else if (hasTags) {
@@ -791 +791 @@
      * @return The current selected tag
      */
-    @SuppressWarnings("unchecked")
     public Tag getSelectedProperty() {
         int row = tagTable.getSelectedRow();
         if (row == -1) return null;
-        Map<String, Integer> map = (TreeMap<String, Integer>) tagData.getValueAt(row, 1);
+        Map<String, Integer> map = editHelper.getDataValues(row);
         return new Tag(
-                tagData.getValueAt(row, 0).toString(),
+                editHelper.getDataKey(row),
                 map.size() > 1 ? "" : map.keySet().iterator().next());
     }
@@ -952 +951 @@
             int nextKeyIndex = rows[0];
             for (int row : rows) {
-                String key = tagData.getValueAt(row, 0).toString();
+                String key = editHelper.getDataKey(row);
                 if (row == nextKeyIndex + 1) {
                     nextKeyIndex = row; // no gap yet
@@ -970 +969 @@
                     nextKeyIndex++;
                 }
-                nextKey = (String) tagData.getValueAt(nextKeyIndex, 0);
+                nextKey = editHelper.getDataKey(nextKeyIndex);
             }
 
@@ -978 +977 @@
             membershipTable.clearSelection();
             if (nextKey != null) {
-                tagTable.changeSelection(findRow(tagData, nextKey), 0, false, false);
+                tagTable.changeSelection(findViewRow(tagTable, tagData, nextKey), 0, false, false);
             }
         }
@@ -1010 +1009 @@
             tagTable.clearSelection();
             if (nextRelation != null) {
-                membershipTable.changeSelection(findRow(membershipData, nextRelation), 0, false, false);
+                membershipTable.changeSelection(findViewRow(membershipTable, membershipData, nextRelation), 0, false, false);
             }
         }
@@ -1115 +1114 @@
                 if (tagTable.getSelectedRowCount() == 1) {
                     row = tagTable.getSelectedRow();
-                    String key = Utils.encodeUrl(tagData.getValueAt(row, 0).toString());
-                    @SuppressWarnings("unchecked")
-                    Map<String, Integer> m = (Map<String, Integer>) tagData.getValueAt(row, 1);
+                    String key = Utils.encodeUrl(editHelper.getDataKey(row));
+                    Map<String, Integer> m = editHelper.getDataValues(row);
                     String val = Utils.encodeUrl(m.entrySet().iterator().next().getKey());
 
@@ -1206 +1204 @@
 
         @Override
-        @SuppressWarnings("unchecked")
         public void actionPerformed(ActionEvent e) {
             final String url;
             if (tagTable.getSelectedRowCount() == 1) {
                 final int row = tagTable.getSelectedRow();
-                final String key = Utils.encodeUrl(tagData.getValueAt(row, 0).toString());
-                Map<String, Integer> values = (Map<String, Integer>) tagData.getValueAt(row, 1);
+                final String key = Utils.encodeUrl(editHelper.getDataKey(row));
+                Map<String, Integer> values = editHelper.getDataValues(row);
                 if (values.size() == 1) {
                     url = TAGINFO_URL_PROP.get() + "tags/" + key /* do not URL encode key, otherwise addr:street does not work */
@@ -1239 +1236 @@
             if (tagTable.getSelectedRowCount() != 1)
                 return;
-            String key = tagData.getValueAt(tagTable.getSelectedRow(), 0).toString();
+            String key = editHelper.getDataKey(tagTable.getSelectedRow());
             Collection<OsmPrimitive> sel = Main.main.getInProgressSelection();
             String clipboard = Utils.getClipboardContent();
@@ -1260 +1257 @@
 
             for (int row: rows) {
-                String key = tagData.getValueAt(row, 0).toString();
+                String key = editHelper.getDataKey(row);
                 if (sel.isEmpty())
                     return;
@@ -1342 +1339 @@
             if (tagTable.getSelectedRowCount() != 1)
                 return;
-            String key = tagData.getValueAt(tagTable.getSelectedRow(), 0).toString();
+            String key = editHelper.getDataKey(tagTable.getSelectedRow());
             Collection<OsmPrimitive> sel = Main.main.getInProgressSelection();
             if (sel.isEmpty())

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/TagEditHelper.java

@@ -53 +53 @@
 import javax.swing.JPanel;
 import javax.swing.JPopupMenu;
+import javax.swing.JTable;
 import javax.swing.KeyStroke;
 import javax.swing.ListCellRenderer;
@@ -86 +87 @@
  */
 class TagEditHelper {
+    private final JTable tagTable;
     private final DefaultTableModel tagData;
     private final Map<String, Map<String, Integer>> valueCount;
@@ -116 +118 @@
     };
 
-    TagEditHelper(DefaultTableModel propertyData, Map<String, Map<String, Integer>> valueCount) {
+    TagEditHelper(JTable tagTable, DefaultTableModel propertyData, Map<String, Map<String, Integer>> valueCount) {
+        this.tagTable = tagTable;
         this.tagData = propertyData;
         this.valueCount = valueCount;
+    }
+
+    public final String getDataKey(int viewRow) {
+        return tagData.getValueAt(tagTable.convertRowIndexToModel(viewRow), 0).toString();
+    }
+
+    @SuppressWarnings("unchecked")
+    public final Map<String, Integer> getDataValues(int viewRow) {
+        return (Map<String, Integer>) tagData.getValueAt(tagTable.convertRowIndexToModel(viewRow), 1);
     }
 
@@ -152 +164 @@
         if (sel == null || sel.isEmpty()) return;
 
-        String key = tagData.getValueAt(row, 0).toString();
+        String key = getDataKey(row);
         objKey = key;
 
-        @SuppressWarnings("unchecked")
-        final EditTagDialog editDialog = new EditTagDialog(key,
-                (Map<String, Integer>) tagData.getValueAt(row, 1), focusOnKey);
+        final EditTagDialog editDialog = new EditTagDialog(key, getDataValues(row), focusOnKey);
         editDialog.showDialog();
         if (editDialog.getValue() != 1) return;
@@ -567 +577 @@
                 }
                 for (int i = 0; i < tagData.getRowCount(); ++i) {
-                    if (item.getValue().equals(tagData.getValueAt(i, 0))) {
+                    if (item.getValue().equals(getDataKey(i))) {
                         if (itemToSelect == item) {
                             itemToSelect = null;
@@ -831 +841 @@
             // performing this action leads to autocomplete to the next key (see #7671 comments)
             for (int j = 0; j < tagData.getRowCount(); ++j) {
-                if (t.getKey().equals(tagData.getValueAt(j, 0))) {
+                if (t.getKey().equals(getDataKey(j))) {
                     action.setEnabled(false);
                     break;